Skip to content

Commit 8cc6345

Browse files
committed
Migrate to dev04
1 parent d1d934e commit 8cc6345

22 files changed

Lines changed: 272 additions & 359 deletions

app/build.gradle

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ android {
3232
buildFeatures {
3333
compose true
3434
}
35-
35+
composeOptions {
36+
kotlinCompilerExtensionVersion "0.1.0-dev04"
37+
}
3638
}
3739

3840
dependencies {
@@ -42,12 +44,12 @@ dependencies {
4244
implementation 'androidx.appcompat:appcompat:1.1.0'
4345
implementation 'androidx.core:core-ktx:1.1.0'
4446
implementation "androidx.lifecycle:lifecycle-livedata:2.1.0"
45-
implementation 'androidx.ui:ui-framework:0.1.0-dev03'
46-
implementation 'androidx.ui:ui-layout:0.1.0-dev03'
47-
implementation 'androidx.ui:ui-foundation:0.1.0-dev03'
48-
implementation 'androidx.ui:ui-material:0.1.0-dev03'
49-
implementation 'androidx.ui:ui-tooling:0.1.0-dev03'
50-
implementation 'com.github.zsoltk:compose-router:0.3.1'
47+
implementation 'androidx.ui:ui-framework:0.1.0-dev04'
48+
implementation 'androidx.ui:ui-layout:0.1.0-dev04'
49+
implementation 'androidx.ui:ui-foundation:0.1.0-dev04'
50+
implementation 'androidx.ui:ui-material:0.1.0-dev04'
51+
implementation 'androidx.ui:ui-tooling:0.1.0-dev04'
52+
implementation 'com.github.zsoltk:compose-router:0.4.0'
5153
implementation "io.reactivex.rxjava2:rxjava:2.2.17"
5254
implementation "io.reactivex.rxjava2:rxandroid:2.1.1"
5355
testImplementation 'junit:junit:4.12'
Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,9 @@
11
package com.github.zsoltk.pokedex
22

3-
import android.graphics.Paint
4-
import android.graphics.Rect
5-
import androidx.compose.Composable
6-
import androidx.compose.memo
7-
import androidx.compose.unaryPlus
8-
import androidx.ui.core.Draw
93
import androidx.ui.graphics.Color
10-
import androidx.ui.layout.Arrangement
11-
import androidx.ui.layout.Container
12-
import androidx.ui.layout.Row
13-
import androidx.ui.material.ColorPalette
14-
import androidx.ui.tooling.preview.Preview
4+
import androidx.ui.material.lightColorPalette
155

16-
val lightThemeColors = ColorPalette(
6+
val lightThemeColors = lightColorPalette(
177
primary = Color.White,
188
primaryVariant = Color(0xFFC20029),
199
onPrimary = Color.Black,
@@ -26,17 +16,3 @@ val lightThemeColors = ColorPalette(
2616
error = Color(0xFFD00036),
2717
onError = Color.White
2818
)
29-
30-
@Preview
31-
@Composable
32-
fun bla() {
33-
val paint = +memo { Paint().apply { color = 0xFFFA6555.toInt() } }
34-
Container(expanded = true) {
35-
Row(arrangement = Arrangement.Center) {
36-
Draw { canvas, parentSize ->
37-
// paint.color = +colorResource(R.color.red)
38-
canvas.nativeCanvas.drawRect(Rect(0, 0, 100, 4), paint)
39-
}
40-
}
41-
}
42-
}

app/src/main/java/com/github/zsoltk/pokedex/common/HorizontalRuler.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package com.github.zsoltk.pokedex.common
22

33
import androidx.compose.Composable
4-
import androidx.ui.core.Dp
5-
import androidx.ui.core.dp
64
import androidx.ui.graphics.Color
75
import androidx.ui.layout.Arrangement
86
import androidx.ui.layout.Container
9-
import androidx.ui.layout.ExpandedWidth
7+
import androidx.ui.layout.LayoutWidth
108
import androidx.ui.layout.Row
11-
import androidx.ui.layout.WidthSpacer
9+
import androidx.ui.layout.Spacer
1210
import androidx.ui.material.surface.Surface
11+
import androidx.ui.unit.Dp
12+
import androidx.ui.unit.dp
1313

1414
@Composable
1515
fun HorizontalRuler(
@@ -19,7 +19,7 @@ fun HorizontalRuler(
1919
centered: Boolean = true
2020
) {
2121
Row(
22-
modifier = ExpandedWidth,
22+
modifier = LayoutWidth.Fill,
2323
arrangement = if (centered) Arrangement.Center else Arrangement.Begin
2424
) {
2525
Surface(color = color) {
@@ -28,7 +28,7 @@ fun HorizontalRuler(
2828
width = width,
2929
height = height
3030
) {
31-
WidthSpacer(width = 1.dp)
31+
Spacer(modifier = LayoutWidth(1.dp))
3232
}
3333
}
3434
}

app/src/main/java/com/github/zsoltk/pokedex/common/Image.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
package com.github.zsoltk.pokedex.common
22

33
import androidx.compose.Composable
4-
import androidx.compose.unaryPlus
54
import androidx.ui.foundation.DrawImage
65
import androidx.ui.graphics.Color
76
import androidx.ui.res.loadImageResource
87

98
@Composable
109
fun LoadImage(imageResId: Int, tint: Color? = null) {
11-
(+loadImageResource(imageResId)).resource.resource?.let {
10+
loadImageResource(imageResId).resource.resource?.let {
1211
DrawImage(
1312
image = it,
1413
tint = tint

app/src/main/java/com/github/zsoltk/pokedex/common/Observe.kt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package com.github.zsoltk.pokedex.common
22

33
import androidx.annotation.CheckResult
4+
import androidx.compose.Composable
45
import androidx.compose.effectOf
56
import androidx.compose.memo
67
import androidx.compose.onCommit
8+
import androidx.compose.remember
79
import androidx.compose.state
810
import androidx.lifecycle.LiveData
911
import androidx.lifecycle.Observer
@@ -18,16 +20,17 @@ sealed class AsyncState<T> {
1820

1921
/**
2022
* Based on https://medium.com/swlh/android-mvi-with-jetpack-compose-b0890f5156ac
23+
* Adapted for 0.1.0-dev04
2124
*/
22-
@CheckResult(suggest = "+")
23-
fun <T> observe(data: LiveData<T>) = effectOf<T?> {
24-
var result by +state { data.value }
25-
val observer = +memo { Observer<T> { result = it } }
25+
@Composable
26+
fun <T> observe(data: LiveData<T>): T? {
27+
var result by state { data.value }
28+
val observer = remember { Observer<T> { result = it } }
2629

27-
+onCommit(data) {
30+
onCommit(data) {
2831
data.observeForever(observer)
2932
onDispose { data.removeObserver(observer) }
3033
}
3134

32-
result
35+
return result
3336
}

app/src/main/java/com/github/zsoltk/pokedex/common/PokeBall.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ package com.github.zsoltk.pokedex.common
22

33
import androidx.compose.Composable
44
import androidx.ui.core.Opacity
5-
import androidx.ui.core.dp
65
import androidx.ui.graphics.Color
76
import androidx.ui.layout.Container
87
import androidx.ui.tooling.preview.Preview
8+
import androidx.ui.unit.dp
99
import com.github.zsoltk.pokedex.R
1010

1111
@Composable

app/src/main/java/com/github/zsoltk/pokedex/common/PokeBallBackground.kt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
package com.github.zsoltk.pokedex.common
22

33
import androidx.compose.Composable
4-
import androidx.compose.unaryPlus
54
import androidx.ui.core.Alignment
6-
import androidx.ui.core.dp
75
import androidx.ui.layout.Container
8-
import androidx.ui.layout.StackChildren
6+
import androidx.ui.layout.EdgeInsets
97
import androidx.ui.res.colorResource
8+
import androidx.ui.unit.dp
109
import com.github.zsoltk.pokedex.R
1110

1211
@Composable
13-
fun StackChildren.PokeBallBackground() {
14-
positioned(
15-
topInset =(-70).dp,
16-
rightInset = (-90).dp
12+
fun PokeBallBackground() {
13+
Container(
14+
alignment = Alignment.TopRight,
15+
padding = EdgeInsets(top = (-70).dp, right = (-90).dp),
16+
expanded = true
1717
) {
1818
Container(
1919
width = 240.dp,
@@ -22,7 +22,7 @@ fun StackChildren.PokeBallBackground() {
2222
alignment = Alignment.TopRight
2323
) {
2424
PokeBallLarge(
25-
+colorResource(
25+
colorResource(
2626
R.color.grey_100
2727
)
2828
)

app/src/main/java/com/github/zsoltk/pokedex/common/PokemonTypeLabels.kt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
11
package com.github.zsoltk.pokedex.common
22

33
import androidx.compose.Composable
4-
import androidx.compose.unaryPlus
5-
import androidx.ui.core.Dp
64
import androidx.ui.core.Text
7-
import androidx.ui.core.TextUnit
8-
import androidx.ui.core.dp
9-
import androidx.ui.core.sp
105
import androidx.ui.foundation.shape.corner.RoundedCornerShape
116
import androidx.ui.graphics.Color
12-
import androidx.ui.layout.FixedSpacer
7+
import androidx.ui.layout.LayoutHeight
8+
import androidx.ui.layout.LayoutWidth
139
import androidx.ui.layout.Padding
10+
import androidx.ui.layout.Spacer
1411
import androidx.ui.material.surface.Surface
1512
import androidx.ui.res.colorResource
1613
import androidx.ui.text.TextStyle
1714
import androidx.ui.text.font.FontFamily
15+
import androidx.ui.unit.Dp
16+
import androidx.ui.unit.TextUnit
17+
import androidx.ui.unit.dp
18+
import androidx.ui.unit.sp
1819
import com.github.zsoltk.pokedex.R
1920

2021
data class TypeLabelMetrics(
@@ -39,7 +40,7 @@ fun PokemonTypeLabels(types: List<String>?, metrics: TypeLabelMetrics) {
3940
) {
4041
PokemonTypeLabel(it, metrics)
4142
}
42-
FixedSpacer(width = metrics.elementSpacing, height = metrics.elementSpacing)
43+
Spacer(modifier = LayoutWidth(metrics.elementSpacing) + LayoutHeight(metrics.elementSpacing))
4344
}
4445
}
4546

@@ -56,7 +57,7 @@ fun PokemonTypeLabel(text: String, metrics: TypeLabelMetrics) {
5657
style = TextStyle(
5758
fontFamily = FontFamily("Roboto"),
5859
fontSize = metrics.fontSize,
59-
color = +colorResource(R.color.white_1000)
60+
color = colorResource(R.color.white_1000)
6061
)
6162
)
6263
}

app/src/main/java/com/github/zsoltk/pokedex/common/RemoveOnDev04.kt

Lines changed: 0 additions & 82 deletions
This file was deleted.

app/src/main/java/com/github/zsoltk/pokedex/common/Rotate.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import androidx.animation.Infinite
55
import androidx.animation.LinearEasing
66
import androidx.animation.transitionDefinition
77
import androidx.compose.Composable
8+
import androidx.ui.animation.Transition
89
import androidx.ui.core.Draw
910

1011
private val rotation = FloatPropKey()

0 commit comments

Comments
 (0)