Skip to content

Commit 610f90b

Browse files
authored
4.x: Remove unnecessary comments from DropwizardMetricsListener (helidon-io#8658)
1 parent 66fa802 commit 610f90b

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

dbclient/metrics-hikari/src/main/java/io/helidon/dbclient/metrics/hikari/DropwizardMetricsListener.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2020, 2023 Oracle and/or its affiliates.
2+
* Copyright (c) 2020, 2024 Oracle and/or its affiliates.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -39,11 +39,9 @@ public class DropwizardMetricsListener implements MetricRegistryListener {
3939

4040
private static final String SCOPE = io.helidon.metrics.api.Meter.Scope.VENDOR;
4141

42-
/** Local logger instance. */
4342
private static final System.Logger LOGGER = System.getLogger(DropwizardMetricsListener.class.getName());
4443

4544
private final String prefix;
46-
// Helidon metrics registry
4745
private final LazyValue<MeterRegistry> registry = LazyValue.create(Metrics::globalRegistry);
4846

4947
private DropwizardMetricsListener(String prefix) {
@@ -89,43 +87,31 @@ public void onCounterRemoved(String name) {
8987

9088
@Override
9189
public void onHistogramAdded(String name, Histogram histogram) {
92-
// LOGGER.log(Level.TRACE, () -> String.format("Histogram added: %s", name));
93-
// registry.get().register(prefix + name, new JdbcMetricsHistogram(histogram));
9490
LOGGER.log(Level.TRACE, () -> String.format("Ignoring histogram added: %s", name));
9591
}
9692

9793
@Override
9894
public void onHistogramRemoved(String name) {
99-
// LOGGER.log(Level.TRACE, () -> String.format("Histogram removed: %s", name));
100-
// registry.get().remove(prefix + name);
10195
LOGGER.log(Level.TRACE, () -> String.format("Ignoring histogram removed: %s", name));
10296
}
10397

10498
@Override
10599
public void onMeterAdded(String name, Meter meter) {
106-
// LOGGER.log(Level.TRACE, () -> String.format("Meter added: %s", name));
107-
// registry.get().register(prefix + name, new JdbcMetricsMeter(meter));
108100
LOGGER.log(Level.TRACE, () -> String.format("Ignoring meter added: %s", name));
109101
}
110102

111103
@Override
112104
public void onMeterRemoved(String name) {
113-
// LOGGER.log(Level.TRACE, () -> String.format("Meter removed: %s", name));
114-
// registry.get().remove(prefix + name);
115105
LOGGER.log(Level.TRACE, () -> String.format("Ignoring meter removed: %s", name));
116106
}
117107

118108
@Override
119109
public void onTimerAdded(String name, Timer timer) {
120-
// LOGGER.log(Level.TRACE, () -> String.format("Timer added: %s", name));
121-
// registry.get().register(prefix + name, new JdbcMetricsTimer(timer));
122110
LOGGER.log(Level.TRACE, () -> String.format("Ignoring timer added: %s", name));
123111
}
124112

125113
@Override
126114
public void onTimerRemoved(String name) {
127-
// LOGGER.log(Level.TRACE, () -> String.format("Timer removed: %s", name));
128-
// registry.get().remove(prefix + name);
129115
LOGGER.log(Level.TRACE, () -> String.format("Ignoring histogram removed: %s", name));
130116
}
131117

0 commit comments

Comments
 (0)