Skip to content

Commit c974591

Browse files
author
Tomáš Kraus
committed
Issue helidon-io#8613 - Review notes applied.
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
1 parent af38817 commit c974591

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientBuilderBase.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ public abstract class DbClientBuilderBase<T extends DbClientBuilderBase<T>>
5050
*/
5151
protected DbClientBuilderBase() {
5252
this.clientServices = new LinkedList<>();
53-
this.missingMapParametersAsNull = false;
5453
}
5554

5655
@Override

dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientContext.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ public abstract static class BuilderBase<B extends BuilderBase<B, T>, T extends
122122
* Creates an instance of base builder for {@link DbClientContext}.
123123
*/
124124
protected BuilderBase() {
125-
this.missingMapParametersAsNull = false;
126125
}
127126

128127
/**

dbclient/jdbc/src/main/java/io/helidon/dbclient/jdbc/JdbcStatement.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,16 @@ private PreparedStatement prepareNamedStatement(String stmtName, String stmt, Ma
148148
for (String name : namesOrder) {
149149
if (parameters.containsKey(name)) {
150150
Object value = parameters.get(name);
151-
LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> %s", i, name, value));
151+
if (LOGGER.isLoggable(Level.TRACE)) {
152+
LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> %s", i, name, value));
153+
}
152154
setParameter(preparedStatement, i, value);
153155
i++;
154156
} else {
155157
if (context().missingMapParametersAsNull()) {
156-
LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> null", i, name));
158+
if (LOGGER.isLoggable(Level.TRACE)) {
159+
LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> null", i, name));
160+
}
157161
setParameter(preparedStatement, i, null);
158162
i++;
159163
} else {
@@ -174,7 +178,9 @@ private PreparedStatement prepareIndexedStatement(String stmtName, String stmt,
174178
preparedStatement = prepareStatement(stmtName, stmt);
175179
int i = 1; // JDBC set position parameter starts from 1.
176180
for (Object value : parameters) {
177-
LOGGER.log(Level.TRACE, String.format("Indexed parameter %d: %s", i, value));
181+
if (LOGGER.isLoggable(Level.TRACE)) {
182+
LOGGER.log(Level.TRACE, String.format("Indexed parameter %d: %s", i, value));
183+
}
178184
setParameter(preparedStatement, i, value);
179185
i++;
180186
}

0 commit comments

Comments
 (0)