Commits

Branch selector

 master

User selector

All users

All time

Commit history

Commits on Dec 15, 2020

• Move large comments snapshot assertions in appropriate 'test_imageWithComments' test function

  MaksimSoldatov

  committed
  3e8a5c1

  Copy full SHA for 3e8a5c1

• Changed argument name in snapshot helper function declaration, for giving additional context.

  MaksimSoldatov

  committed
  b7ce7f7

  Copy full SHA for b7ce7f7

• Removed redundant 'class' constraint for 'FeedImageCommentsLoadingView', 'FeedImageCommentsErrorView', 'FeedImageCommentsView'

  MaksimSoldatov

  committed
  9c611e0

  Copy full SHA for 9c611e0

• Removed redundant images

  MaksimSoldatov

  committed
  9011190

  Copy full SHA for 9011190

• Changed extraLarge implementation

  MaksimSoldatov

  committed
  0ce1fd2

  Copy full SHA for 0ce1fd2

• Checking the correctness of data display

  MaksimSoldatov

  committed
  cb28b1f

  Copy full SHA for cb28b1f

• Remove 'class' constraint for 'FeedImageCommentsViewControllerDelegate' protocol

  MaksimSoldatov

  committed
  cc2da90

  Copy full SHA for cc2da90

• Reverted changes for Feed (handling only 200 response statusCode). Handling 2xx status code for Comments

  MaksimSoldatov

  committed
  cbe6796

  Copy full SHA for cbe6796

• Removed redundant property 'currentDate' from 'FeedImageCommentsPresenter'

  MaksimSoldatov

  committed
  feab963

  Copy full SHA for feab963

• Made immutable properties in 'FeedImageCommentsPresenter' to constants

  MaksimSoldatov

  committed
  7fc7da7

  Copy full SHA for 7fc7da7

• Removed 'inout' parameters

  MaksimSoldatov

  committed
  e3777c7

  Copy full SHA for e3777c7

Commits on Dec 13, 2020

• Added Dynamic Font

  MaksimSoldatov

  committed
  63cccda

  Copy full SHA for 63cccda

Commits on Dec 12, 2020

• Changed error label color

  MaksimSoldatov

  committed
  5e0f3d2

  Copy full SHA for 5e0f3d2

• Move 'Comments API' and 'Comments Presentation' on module level

  MaksimSoldatov

  committed
  528e76c

  Copy full SHA for 528e76c

• Make comment cell non-selectable

  MaksimSoldatov

  committed
  27ed92e

  Copy full SHA for 27ed92e

• Guarantee that presenting comment data will be presented correctly

  MaksimSoldatov

  committed
  a6d134f

  Copy full SHA for a6d134f

• Move 'timeAgoDisplay' function to appropriate function, and made it private

  MaksimSoldatov

  committed
  8e1e53d

  Copy full SHA for 8e1e53d

• Make 'errorMessage' private property

  MaksimSoldatov

  committed
  406a482

  Copy full SHA for 406a482

• Delivers successfully loaded comments in correct order

  MaksimSoldatov

  committed
  7b17007

  Copy full SHA for 7b17007

• Delivers items when got not empty success response

  MaksimSoldatov

  committed
  e834428

  Copy full SHA for e834428

• Add range 200...299 statusCode conformance

  MaksimSoldatov

  committed
  ec10306

  Copy full SHA for ec10306

• Cancel task in 'deinit' method

  MaksimSoldatov

  committed
  6f4b7d5

  Copy full SHA for 6f4b7d5

• Make url property private in 'FeedImageCommentsPresentationAdapter'

  MaksimSoldatov

  committed
  2c2aabe

  Copy full SHA for 2c2aabe

• Reverted zombie objects checker

  MaksimSoldatov

  committed
  99b9952

  Copy full SHA for 99b9952

Commits on Dec 1, 2020

• Move helpers methods in own files

  MaksimSoldatov

  committed
  d9d5c5d

  Copy full SHA for d9d5c5d

• - Display comments for selected object

  Show description for 5091582
  MaksimSoldatov

  committed
  5091582

  Copy full SHA for 5091582

• Added didSelect function handler

  MaksimSoldatov

  committed
  77c14f7

  Copy full SHA for 77c14f7

• Move FeedImageCommentsPresentationAdapter

  MaksimSoldatov

  committed
  c471df8

  Copy full SHA for c471df8

• Cancel executing request when user view disappear

  MaksimSoldatov

  committed
  42a3dd4

  Copy full SHA for 42a3dd4

• Guarantee dispatch completion of FeedImageCommentsLoader in Main

  MaksimSoldatov

  committed
  b1dff5d

  Copy full SHA for b1dff5d

• Refactor FeedImageCommentsUIComposer

  Show description for 2bd881f
  MaksimSoldatov

  committed
  2bd881f

  Copy full SHA for 2bd881f

• Display error view until reload

  MaksimSoldatov

  committed
  a9d4dcd

  Copy full SHA for a9d4dcd

• Feed loading error does not affect current rendered state

  MaksimSoldatov

  committed
  8f9dcbb

  Copy full SHA for 8f9dcbb

• - Remove duplicates code

  Show description for ec88a9a
  MaksimSoldatov

  committed
  ec88a9a

  Copy full SHA for ec88a9a

Commits on Nov 30, 2020

• Refactoring weak references in FeedImageCommentsPresenter

  MaksimSoldatov

  committed
  8861949

  Copy full SHA for 8861949