Build log fix (helidon-io#7128)

* Explicitly set context class loader for Pico annotation processor, so we do not get slf4j warnings
Add slf4j jdk library to Pico tools, so the binder is available

* TypeName is now built, so equals and hashCode work as expected.

Author: tomas-langer

pico/processor/src/main/java/io/helidon/pico/processor/PicoAnnotationProcessor.java

@@ -161,8 +161,23 @@ public void init(ProcessingEnvironment processingEnv) {
     }
 
     @Override
-    public boolean process(Set<? extends TypeElement> annotations,
+    public final boolean process(Set<? extends TypeElement> annotations,
                            RoundEnvironment roundEnv) {
+
+        Thread thread = Thread.currentThread();
+        ClassLoader previousClassloader = thread.getContextClassLoader();
+        thread.setContextClassLoader(PicoAnnotationProcessor.class.getClassLoader());
+
+        // we want everything to execute in the classloader of this type, so service loaders
+        // use the classpath of the annotation processor, and not some "random" classloader, such as a maven one
+        try {
+            return doProcess(annotations, roundEnv);
+        } finally {
+            thread.setContextClassLoader(previousClassloader);
+        }
+    }
+
+    protected boolean doProcess(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
         utils().roundEnv(roundEnv);
 
         if (disableBaseProcessing && getClass() == PicoAnnotationProcessor.class) {
@@ -179,7 +194,8 @@ public boolean process(Set<? extends TypeElement> annotations,
             allElementsOfInterestInThisModule.addAll(elementsOfInterestInThisRound);
 
             // cumulatively collect the types to process in the module
-            gatherTypeInfosToProcessInThisModule(typeInfoToCreateActivatorsForInThisModule, allElementsOfInterestInThisModule);
+            gatherTypeInfosToProcessInThisModule(typeInfoToCreateActivatorsForInThisModule,
+                                                 allElementsOfInterestInThisModule);
 
             // optionally intercept and validate the model
             Set<TypeInfo> filtered = interceptorAndValidate(typeInfoToCreateActivatorsForInThisModule.values());

pico/tools/pom.xml

@@ -65,6 +65,11 @@
             <groupId>com.github.jknack</groupId>
             <artifactId>handlebars</artifactId>
         </dependency>
+        <dependency>
+            <!-- required as handlebars use slf4j -->
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-jdk14</artifactId>
+        </dependency>
         <dependency>
             <groupId>io.github.classgraph</groupId>
             <artifactId>classgraph</artifactId>

pico/tools/src/main/java/io/helidon/pico/tools/InterceptorCreatorDefault.java

@@ -1097,7 +1097,8 @@ private static TypeName toInterceptorTypeName(String serviceTypeName) {
         TypeName typeName = TypeName.create(serviceTypeName);
         return TypeName.builder()
                 .packageName(typeName.packageName())
-                .className(typeName.className() + INNER_INTERCEPTOR_CLASS_NAME);
+                .className(typeName.className() + INNER_INTERCEPTOR_CLASS_NAME)
+                .build();
     }
 
     /**