Skip to content

Commit 58d993c

Browse files
selvanaircron2
authored andcommitted
Fix name of the registry parameter for MAC address
- Replace registry entry MAC by NetworkAddress. - Add a directive to remove any old entry named MAC to support upgrade. No validation of input is done. Windows accepts MAC as 12 hex characters with an optional hyphen between bytes but not colons. Also the MAC should be a valid "locally administered address". Signed-off-by: Selva Nair <selva.nair@gmail.com>
1 parent 06533c4 commit 58d993c

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

src/OemVista.inf.in

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
CopyFiles = @PRODUCT_TAP_WIN_COMPONENT_ID@.driver, @PRODUCT_TAP_WIN_COMPONENT_ID@.files
8989
AddReg = @PRODUCT_TAP_WIN_COMPONENT_ID@.reg
9090
AddReg = @PRODUCT_TAP_WIN_COMPONENT_ID@.params.reg
91+
DelReg = @PRODUCT_TAP_WIN_COMPONENT_ID@.params.delreg
9192
Characteristics = @PRODUCT_TAP_WIN_CHARACTERISTICS@
9293
*IfType = 53 ; IF_TYPE_PROP_VIRTUAL
9394
*MediaType = 0x0 ; NdisMedium802_3
@@ -117,16 +118,19 @@
117118
HKR, Ndi\params\MediaStatus, Optional, 0, "0"
118119
HKR, Ndi\params\MediaStatus\enum, "0", 0, "Application Controlled"
119120
HKR, Ndi\params\MediaStatus\enum, "1", 0, "Always Connected"
120-
HKR, Ndi\params\MAC, ParamDesc, 0, "MAC Address"
121-
HKR, Ndi\params\MAC, Type, 0, "edit"
122-
HKR, Ndi\params\MAC, Optional, 0, "1"
121+
HKR, Ndi\params\NetworkAddress, ParamDesc, 0, "MAC Address"
122+
HKR, Ndi\params\NetworkAddress, Type, 0, "edit"
123+
HKR, Ndi\params\NetworkAddress, Optional, 0, "1"
123124
HKR, Ndi\params\AllowNonAdmin, ParamDesc, 0, "Non-Admin Access"
124125
HKR, Ndi\params\AllowNonAdmin, Type, 0, "enum"
125126
HKR, Ndi\params\AllowNonAdmin, Default, 0, "1"
126127
HKR, Ndi\params\AllowNonAdmin, Optional, 0, "0"
127128
HKR, Ndi\params\AllowNonAdmin\enum, "0", 0, "Not Allowed"
128129
HKR, Ndi\params\AllowNonAdmin\enum, "1", 0, "Allowed"
129130

131+
[@PRODUCT_TAP_WIN_COMPONENT_ID@.params.delreg]
132+
HKR, Ndi\params\MAC
133+
130134
;----------------------------------------------------------------
131135
; Service Section
132136
;----------------------------------------------------------------

0 commit comments

Comments
 (0)