Skip to content

Commit 75c150b

Browse files
authored
Merge pull request ros2#188 from ros2/ament_cmake_pytest
use ament_cmake_pytest instead of ament_cmake_nose
2 parents a45d255 + 480cf16 commit 75c150b

12 files changed

Lines changed: 20 additions & 13 deletions

File tree

composition/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ if(BUILD_TESTING)
156156
find_package(ament_lint_auto REQUIRED)
157157
ament_lint_auto_find_test_dependencies()
158158

159+
find_package(ament_cmake_pytest REQUIRED)
159160
find_package(rmw_implementation_cmake REQUIRED)
160161

161162
file(GENERATE
@@ -186,7 +187,7 @@ if(BUILD_TESTING)
186187
file(GENERATE
187188
OUTPUT test_composition${target_suffix}_$<CONFIG>.py
188189
INPUT test_composition${target_suffix}.py.genexp)
189-
ament_add_nose_test(test_composition${target_suffix}
190+
ament_add_pytest_test(test_composition${target_suffix}
190191
"${CMAKE_CURRENT_BINARY_DIR}/test_composition${target_suffix}_$<CONFIG>.py"
191192
ENV RMW_IMPLEMENTATION=${rmw_implementation}
192193
APPEND_ENV AMENT_PREFIX_PATH=${CMAKE_CURRENT_BINARY_DIR}/test_ament_index/$<CONFIG>

composition/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<exec_depend>rosidl_default_runtime</exec_depend>
2626
<exec_depend>std_msgs</exec_depend>
2727

28-
<test_depend>ament_cmake_nose</test_depend>
28+
<test_depend>ament_cmake_pytest</test_depend>
2929
<test_depend>ament_lint_auto</test_depend>
3030
<test_depend>ament_lint_common</test_depend>
3131
<test_depend>launch</test_depend>

demo_nodes_cpp/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ if(BUILD_TESTING)
6262
find_package(ament_lint_auto REQUIRED)
6363
ament_lint_auto_find_test_dependencies()
6464

65+
find_package(ament_cmake_pytest REQUIRED)
6566
find_package(rmw_implementation_cmake REQUIRED)
6667

6768
# Add each test case. Multi-executable tests can be specified in
@@ -105,7 +106,7 @@ if(BUILD_TESTING)
105106
INPUT "${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}${target_suffix}.py.configured"
106107
)
107108

108-
ament_add_nose_test(test_tutorial_${exe_list_underscore}${target_suffix}
109+
ament_add_pytest_test(test_tutorial_${exe_list_underscore}${target_suffix}
109110
"${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}${target_suffix}_$<CONFIG>.py"
110111
TIMEOUT 30
111112
ENV

demo_nodes_cpp/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<exec_depend>sensor_msgs</exec_depend>
2929
<exec_depend>std_msgs</exec_depend>
3030

31-
<test_depend>ament_cmake_nose</test_depend>
31+
<test_depend>ament_cmake_pytest</test_depend>
3232
<test_depend>ament_lint_auto</test_depend>
3333
<test_depend>ament_lint_common</test_depend>
3434
<test_depend>launch</test_depend>

demo_nodes_cpp_native/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ if(rmw_fastrtps_cpp_FOUND)
3535
find_package(ament_lint_auto REQUIRED)
3636
ament_lint_auto_find_test_dependencies()
3737

38+
find_package(ament_cmake_pytest REQUIRED)
39+
3840
set(tutorial_executables "talker")
3941

4042
set(DEMO_NODES_CPP_EXPECTED_OUTPUT "")
@@ -58,7 +60,7 @@ if(rmw_fastrtps_cpp_FOUND)
5860
INPUT "${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}.py.configured"
5961
)
6062

61-
ament_add_nose_test(test_tutorial_${exe_list_underscore}
63+
ament_add_pytest_test(test_tutorial_${exe_list_underscore}
6264
"${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}_$<CONFIG>.py"
6365
TIMEOUT 30
6466
ENV

demo_nodes_cpp_native/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<depend>rmw_fastrtps_cpp</depend>
1616
<depend>std_msgs</depend>
1717

18-
<test_depend>ament_cmake_nose</test_depend>
18+
<test_depend>ament_cmake_pytest</test_depend>
1919
<test_depend>ament_lint_auto</test_depend>
2020
<test_depend>ament_lint_common</test_depend>
2121
<test_depend>launch</test_depend>

image_tools/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ if(BUILD_TESTING)
5050
find_package(ament_lint_auto REQUIRED)
5151
ament_lint_auto_find_test_dependencies()
5252

53+
find_package(ament_cmake_pytest REQUIRED)
5354
find_package(rmw_implementation_cmake REQUIRED)
5455

5556
# These are the regex's for validating the output of the executables.
@@ -70,7 +71,7 @@ if(BUILD_TESTING)
7071
OUTPUT test_showimage_cam2image${target_suffix}_$<CONFIG>.py
7172
INPUT test_showimage_cam2image${target_suffix}.py.genexp)
7273

73-
ament_add_nose_test(test_showimage_cam2image${target_suffix}
74+
ament_add_pytest_test(test_showimage_cam2image${target_suffix}
7475
"${CMAKE_CURRENT_BINARY_DIR}/test_showimage_cam2image${target_suffix}_$<CONFIG>.py"
7576
ENV
7677
RCL_ASSERT_RMW_ID_MATCHES=${rmw_implementation}

image_tools/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<exec_depend>sensor_msgs</exec_depend>
1919
<exec_depend>std_msgs</exec_depend>
2020

21-
<test_depend>ament_cmake_nose</test_depend>
21+
<test_depend>ament_cmake_pytest</test_depend>
2222
<test_depend>ament_lint_auto</test_depend>
2323
<test_depend>ament_lint_common</test_depend>
2424
<test_depend>launch</test_depend>

intra_process_demo/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ if(BUILD_TESTING)
9999
find_package(ament_lint_auto REQUIRED)
100100
ament_lint_auto_find_test_dependencies()
101101

102+
find_package(ament_cmake_pytest REQUIRED)
102103
find_package(rmw_implementation_cmake REQUIRED)
103104

104105
# Add each test case. Multi-executable tests can be specified in
@@ -131,7 +132,7 @@ if(BUILD_TESTING)
131132
INPUT "${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}${target_suffix}.py.configured"
132133
)
133134

134-
ament_add_nose_test(test_demo_${exe_list_underscore}${target_suffix}
135+
ament_add_pytest_test(test_demo_${exe_list_underscore}${target_suffix}
135136
"${CMAKE_CURRENT_BINARY_DIR}/test_${exe_list_underscore}${target_suffix}_$<CONFIG>.py"
136137
TIMEOUT 30
137138
ENV

intra_process_demo/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<exec_depend>rclcpp</exec_depend>
1919
<exec_depend>sensor_msgs</exec_depend>
2020

21-
<test_depend>ament_cmake_nose</test_depend>
21+
<test_depend>ament_cmake_pytest</test_depend>
2222
<test_depend>ament_lint_auto</test_depend>
2323
<test_depend>ament_lint_common</test_depend>
2424
<test_depend>launch</test_depend>

0 commit comments

Comments
 (0)