fix: resolve all lint errors and warnings (#154)

* fix: resolve all lint errors and warnings

Fix 46 no-explicit-any errors, unused imports/params, require-yield,
useless escapes, and useless fallback spreads across 32 files. Exclude
generated .astro/ directory from linting.

* fix: remove unused _ prefixed parameters instead of dangling them

* style: format

Author: RhysSullivan

.oxlintrc.jsonc

@@ -1,4 +1,5 @@
 {
+  "ignorePatterns": [".astro/"],
   "rules": {
     "typescript/no-explicit-any": "error",
   },

apps/cli/src/build.ts

@@ -280,6 +280,7 @@ const buildBinaries = async (targets: Target[], mode: BuildMode) => {
         entrypoints: [join(cliRoot, "src/main.ts")],
         minify: mode === "production",
         compile: {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Bun compile target string is dynamically constructed
           target: bunTarget(target) as any,
           outfile: join(binDir, binaryName(target)),
         },
@@ -554,8 +555,8 @@ const repositoryUrl = typeof packageJson.repository === "string"
   ? packageJson.repository
   : packageJson.repository && packageJson.repository.url;
 const githubBase = String(packageJson.homepage || repositoryUrl || "https://github.com/RhysSullivan/executor")
-  .replace(/^git\+/, "")
-  .replace(/\.git$/, "");
+  .replace(/^git[+]/, "")
+  .replace(/.git$/, "");
 const version = packageJson.version;
 
 const platformMap = { darwin: "darwin", linux: "linux", win32: "windows" };

apps/cli/src/main.ts

@@ -14,13 +14,19 @@ if (typeof Bun !== "undefined" && (await Bun.file(wasmOnDisk).exists())) {
   const variant = {
     type: "sync" as const,
     importFFI: () =>
-      import("@jitl/quickjs-wasmfile-release-sync/ffi").then((m: any) => m.QuickJSFFI),
+      import("@jitl/quickjs-wasmfile-release-sync/ffi").then(
+        (m: Record<string, unknown>) => m.QuickJSFFI,
+      ),
     importModuleLoader: () =>
-      import("@jitl/quickjs-wasmfile-release-sync/emscripten-module").then((m: any) => {
-        const original = m.default;
-        return (moduleArg: any = {}) => original({ ...moduleArg, wasmBinary });
-      }),
+      import("@jitl/quickjs-wasmfile-release-sync/emscripten-module").then(
+        (m: Record<string, unknown>) => {
+          const original = m.default as (...args: unknown[]) => unknown;
+          return (moduleArg: Record<string, unknown> = {}) =>
+            original({ ...moduleArg, wasmBinary });
+        },
+      ),
   };
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- quickjs-emscripten variant type is not publicly exported
   const mod = await newQuickJSWASMModule(variant as any);
   setQuickJSModule(mod);
 }
@@ -200,7 +206,7 @@ const callCommand = Command.make(
         }
       } else {
         console.log(result.text);
-        const executionId = (result.structured as any)?.executionId;
+        const executionId = (result.structured as Record<string, unknown> | undefined)?.executionId;
         if (executionId) {
           console.log(
             `\nTo resume:\n  ${cliPrefix} resume --execution-id ${executionId} --action accept`,

apps/cloud/src/auth/workos.ts

@@ -40,7 +40,7 @@ const make = Effect.gen(function* () {
         cookiePassword,
       });
 
-      const result = yield* use((wos) => session.authenticate());
+      const result = yield* use(() => session.authenticate());
 
       if (result.authenticated) {
         return {
@@ -58,7 +58,7 @@ const make = Effect.gen(function* () {
       if (result.reason === "no_session_cookie_provided") return null;
 
       // Try refreshing
-      const refreshed = yield* use((wos) => session.refresh()).pipe(
+      const refreshed = yield* use(() => session.refresh()).pipe(
         Effect.orElseSucceed(() => ({ authenticated: false as const })),
       );
 
@@ -117,7 +117,7 @@ const make = Effect.gen(function* () {
           sessionData,
           cookiePassword,
         });
-        const refreshed = yield* use((wos) =>
+        const refreshed = yield* use(() =>
           session.refresh(organizationId ? { organizationId } : undefined),
         );
         if (!refreshed.authenticated || !("sealedSession" in refreshed)) return null;

apps/cloud/src/mcp.ts

@@ -5,8 +5,6 @@
 import { env } from "cloudflare:workers";
 import { createRemoteJWKSet, jwtVerify } from "jose";
 
-import type { McpSessionInit } from "./mcp-session";
-
 // ---------------------------------------------------------------------------
 // Constants
 // ---------------------------------------------------------------------------

apps/cloud/src/routes/__root.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { HeadContent, Outlet, Scripts, createRootRoute } from "@tanstack/react-router";
+import { HeadContent, Scripts, createRootRoute } from "@tanstack/react-router";
 import { AutumnProvider } from "autumn-js/react";
 import { ExecutorProvider } from "@executor/react/api/provider";
 import { AuthProvider, useAuth } from "../web/auth";

apps/cloud/src/routes/billing_.plans.tsx

@@ -95,7 +95,6 @@ function PlansPage() {
               const isCanceling = eligibility?.canceling ?? false;
               const isCurrent = status === "active" && !isCanceling;
               const isScheduled = status === "scheduled";
-              const isActionable = action !== "none";
               const label = isCanceling ? "Resume" : (ACTION_LABELS[action] ?? "Select");
               const isUpgradeAction = action === "upgrade" || action === "activate";
 

apps/cloud/src/web/shell.tsx

@@ -1,9 +1,9 @@
 import { Link, Outlet, useLocation } from "@tanstack/react-router";
 import { useEffect, useRef, useState } from "react";
-import { useAtomRefresh, useAtomValue, Result } from "@effect-atom/atom-react";
-import { sourcesAtom, toolsAtom } from "@executor/react/api/atoms";
+import { useAtomValue, Result } from "@effect-atom/atom-react";
+import { sourcesAtom } from "@executor/react/api/atoms";
 import { useScope } from "@executor/react/api/scope-context";
-import { Button } from "@executor/react/components/button";
+
 import { AUTH_PATHS } from "../auth/api";
 import { useAuth } from "./auth";
 
@@ -169,9 +169,6 @@ function SidebarContent(props: { pathname: string; onNavigate?: () => void; show
 export function Shell() {
   const location = useLocation();
   const pathname = location.pathname;
-  const scopeId = useScope();
-  const refreshSources = useAtomRefresh(sourcesAtom(scopeId));
-  const refreshTools = useAtomRefresh(toolsAtom(scopeId));
   const lastPathname = useRef(pathname);
   const [mobileSidebarOpen, setMobileSidebarOpen] = useState(false);
   if (lastPathname.current !== pathname) {

apps/desktop/scripts/bundle-cli.js

@@ -2,7 +2,7 @@
  * Builds the executor CLI binary and copies it into the desktop app's
  * resources/ folder so electron-builder can bundle it as a sidecar.
  */
-const { execSync, spawnSync } = require("node:child_process");
+const { spawnSync } = require("node:child_process");
 const { existsSync, mkdirSync, cpSync, chmodSync } = require("node:fs");
 const { resolve, join } = require("node:path");
 

apps/local/src/routes/__root.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { Outlet, createRootRoute } from "@tanstack/react-router";
+import { createRootRoute } from "@tanstack/react-router";
 import { ExecutorProvider } from "@executor/react/api/provider";
 import { Shell } from "../web/shell";