4.x: Archive archetype test projects (helidon-io#10720)

* Archive archetype test projects
Update archetype README.md
Fix micronaut data tests configuration for pipelines

* Fix merge pattern, use test-project as the artifactId for static test projects

Author: romain-grecourt

.github/workflows/validate.yml

@@ -282,7 +282,9 @@ jobs:
         with:
           build-cache: read-only
           native-image: ${{ matrix.packaging == 'native' }}
-          test-artifact-name: tests-archetypes-${{ matrix.group }}-${{ matrix.packaging }}
+          artifact-name: archetypes-${{ matrix.group }}-${{ matrix.packaging }}-projects
+          artifact-path: |
+            archetypes/**/target/tests/**
           run: |
             mvn ${MVN_ARGS} \
               -f archetypes/archetypes/pom.xml \
@@ -303,7 +305,9 @@ jobs:
       - uses: ./.github/actions/common
         with:
           build-cache: read-only
-          test-artifact-name: tests-legacy-archetypes
+          artifact-name: archetypes-legacy-projects
+          artifact-path: |
+            archetypes/**/target/tests/**
           run: |
             mvn ${MVN_ARGS} \
               -f archetypes/pom.xml \
@@ -366,9 +370,18 @@ jobs:
               -Pnative-image \
               -am \
               verify
+  archetype-results:
+    runs-on: ubuntu-22.04
+    needs: [ archetypes, legacy-archetypes ]
+    name: archetype/results
+    steps:
+      - uses: actions/upload-artifact/merge@v4
+        with:
+          name: archetype-projects
+          pattern: "archetypes-*-projects"
   test-results:
     runs-on: ubuntu-22.04
-    needs: [ _tests, archetypes, legacy-archetypes, _tck, packaging, _native-image ]
+    needs: [ _tests, _tck, packaging, _native-image ]
     name: tests/results
     steps:
       - uses: actions/upload-artifact/merge@v4
@@ -377,7 +390,7 @@ jobs:
           pattern: "tests-*"
   gate:
     runs-on: ubuntu-22.04
-    needs: [ copyright, checkstyle, shellcheck, docs, javadoc, _spotbugs, test-results ]
+    needs: [ copyright, checkstyle, shellcheck, docs, javadoc, _spotbugs, archetype-results, test-results ]
     steps:
       - shell: bash
         run: |

archetypes/README.md

@@ -1,7 +1,8 @@
 # Archetypes Development
 
-Helidon provides a set of archetypes to bootstrap end user's application development journey. They are implemented here based on 
-[Archetype V2 engine] (https://github.com/helidon-io/helidon-build-tools/wiki/Archetype-Engine-V2)
+Helidon provides a set of archetypes to bootstrap end user's application development journey.
+
+See https://github.com/helidon-io/helidon-build-tools/wiki/Archetype-Engine-V2
 
 ## Build
 
@@ -11,24 +12,26 @@ From the root `archetypes` directory, just issue
 mvn clean install
 ```
 
-This will build all archetypes (including legacy) and run tests. To save time, during development cycle, you can skip test using
+This will build all archetypes (including legacy) and run tests.
 
+To save time, during development cycle, you can skip test using:
 ```bash
-mvn clean install  -Darchetype.test.skip=true
+mvn clean install -DskipTests -e
 ```
 
-## Test
+The build output shows instructions on how to use the archetypes locally.
 
-Archetypes build generates `cli-data` that you can provide to installed [Helidon CLI](../README.md#helidon-cli).
+## Smoke Tests
 
-```bash
-helidon init --reset --url file:///<path-to>/helidon/archetypes/helidon/target/cli-data
+Generate the projects and validate the pom files.
+```shell
+mvn clean install -Darchetype.test.testGoal=clean -e
 ```
 
-Once the archetype is selected the other options have defaults (and allows user to make selections) and the project is generated in a directory named after the `artifactId` value.
-
-```bash
-cd `artifactId`
+Download the previous archetype test projects and diff them:
+```shell
+.projects-diff.sh \
+  --actual=./target/tests \
+  --orig=$HOME/Download/archetype-tests \
+  diff_projects
 ```
-
-Now, just follow instructions in the generated README file.

archetypes/archetypes/pom.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
 
-    Copyright (c) 2020, 2023 Oracle and/or its affiliates.
+    Copyright (c) 2020, 2025 Oracle and/or its affiliates.
 
     Licensed under the Apache License, Version 2.0 (the "License");
     you may not use this file except in compliance with the License.
@@ -85,6 +85,9 @@
                                     </patterns>
                                 </validation>
                             </validations>
+                            <externalValues>
+                                <artifactId>test-project</artifactId>
+                            </externalValues>
                         </configuration>
                     </execution>
                 </executions>

archetypes/legacy/pom.xml

@@ -88,7 +88,7 @@
                         <configuration>
                             <generateTests>false</generateTests>
                             <externalValues>
-                                <artifactId>myproject</artifactId>
+                                <artifactId>test-project</artifactId>
                             </externalValues>
                         </configuration>
                     </execution>

integrations/micronaut/data/pom.xml

@@ -206,13 +206,6 @@
                             </execution>
                         </executions>
                     </plugin>
-                    <plugin>
-                        <groupId>org.apache.maven.plugins</groupId>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <skipTests>false</skipTests>
-                        </configuration>
-                    </plugin>
                 </plugins>
             </build>
         </profile>
@@ -222,17 +215,9 @@
             <activation>
                 <jdk>!21</jdk>
             </activation>
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.apache.maven.plugins</groupId>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <skipTests>true</skipTests>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
+            <properties>
+                <skipTests>true</skipTests>
+            </properties>
         </profile>
     </profiles>
 </project>