download: Fix error reporting on download errors

cfergeau · praveenkumar · commit 0a882d3cfa19 · 2021-11-16T21:02:43.000+05:30
The code is checking for resp.Err() != nil, but returning err rather
than resp.Err()
diff --git a/pkg/download/download.go b/pkg/download/download.go
@@ -35,7 +35,7 @@ func Download(uri, destination string, mode os.FileMode, sha256sum []byte) (stri
 	resp := <-respCh
 
 	if resp.Err() != nil {
-		return "", err
+		return "", resp.Err()
 	}
 
 	if err := os.Chmod(resp.Filename, mode); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func Download(uri, destination string, mode os.FileMode, sha256sum []byte) (stri`
`35`	`35`	`resp := <-respCh`
`36`	`36`
`37`	`37`	`if resp.Err() != nil {`
`38`		`- return "", err`
	`38`	`+ return "", resp.Err()`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if err := os.Chmod(resp.Filename, mode); err != nil {`