drivers: don't start the VM when creating it

Drivers were changed to not start the VM when calling Create().
crc has to do it now.

crc can now better control what happens at creation time.

Author: guillaumerose

pkg/crc/machine/hyperkit/constants.go

@@ -6,7 +6,7 @@ import "fmt"
 
 const (
 	MachineDriverCommand = "crc-driver-hyperkit"
-	MachineDriverVersion = "0.12.11"
+	MachineDriverVersion = "0.12.14"
 	HyperKitCommand      = "hyperkit"
 	HyperKitVersion      = "v0.20200224-44-gb54460"
 )

pkg/crc/machine/libvirt/constants.go

@@ -16,7 +16,7 @@ const (
 
 const (
 	MachineDriverCommand = "crc-driver-libvirt"
-	MachineDriverVersion = "0.12.14"
+	MachineDriverVersion = "0.12.15"
 )
 
 var (

pkg/drivers/hyperv/hyperv.go

@@ -203,8 +203,7 @@ func (d *Driver) Create() error {
 		return err
 	}
 
-	log.Debugf("Starting VM...")
-	return d.Start()
+	return nil
 }
 
 func (d *Driver) chooseVirtualSwitch() (string, error) {

pkg/libmachine/libmachine.go

@@ -117,6 +117,10 @@ func (api *Client) performCreate(ctx context.Context, h *host.Host) error {
 		return fmt.Errorf("Error in driver during machine creation: %s", err)
 	}
 
+	if err := h.Driver.Start(); err != nil {
+		return fmt.Errorf("Error in driver during machine start: %s", err)
+	}
+
 	if err := api.Save(h); err != nil {
 		return fmt.Errorf("Error saving host to store after attempting creation: %s", err)
 	}