Fix golint errors because of updated gosec dep

This is mostly adding `nolint` becasue gosec showing errors even for
temp folders and files.

Author: praveenkumar

cmd/crc/cmd/start.go

@@ -148,7 +148,7 @@ type clusterConfig struct {
 
 type credentials struct {
 	Username string `json:"username"`
-	Password string `json:"password"`
+	Password string `json:"password"` // nolint:gosec
 }
 
 type startResult struct {

pkg/crc/api/client/client.go

@@ -249,7 +249,7 @@ func (c *client) sendRequest(url string, method string, data io.Reader) ([]byte,
 	}
 	req.Header.Set("Content-Type", "application/json")
 
-	res, err := c.client.Do(req)
+	res, err := c.client.Do(req) //nolint:gosec // G704: SSRF vulnerability check not needed as the base URL is unix socket
 	if err != nil {
 		return nil, err
 	}

pkg/crc/config/viper_config.go

@@ -130,13 +130,13 @@ func atomicWrite(bin []byte, configFile string) error {
 		return err
 	}
 	defer func() {
-		_ = os.Remove(tmpFile.Name())
+		_ = os.Remove(tmpFile.Name()) // nolint:gosec // G703: paths from CreateTemp
 	}()
 	if err := tmpFile.Close(); err != nil {
 		return err
 	}
-	if err := os.WriteFile(tmpFile.Name(), bin, 0600); err != nil {
+	if err := os.WriteFile(tmpFile.Name(), bin, 0600); err != nil { // nolint:gosec // G703: paths from CreateTemp
 		return err
 	}
-	return os.Rename(tmpFile.Name(), configFile)
+	return os.Rename(tmpFile.Name(), configFile) // nolint:gosec // G703: paths from CreateTemp and caller
 }

pkg/crc/errors/maskederror.go

@@ -8,7 +8,7 @@ const mask = "*****"
 
 type MaskedSecretError struct {
 	Err    error
-	Secret string
+	Secret string // nolint:gosec
 }
 
 func (err *MaskedSecretError) Error() string {

pkg/crc/logging/logging.go

@@ -3,9 +3,9 @@ package logging
 import (
 	"os"
 
+	terminal "github.com/crc-org/crc/v2/pkg/os/terminal"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/pflag"
-	terminal "golang.org/x/term"
 	"gopkg.in/natefinch/lumberjack.v2"
 )
 
@@ -53,7 +53,7 @@ func InitLogrus(logFilePath string) {
 
 	// Add hook to send error/fatal to stderr
 	logrus.AddHook(newstdErrHook(level, &logrus.TextFormatter{
-		ForceColors:            terminal.IsTerminal(int(os.Stderr.Fd())),
+		ForceColors:            terminal.IsRunningInTerminal(),
 		DisableTimestamp:       true,
 		DisableLevelTruncation: false,
 	}))

pkg/crc/machine/kubeconfig_test.go

@@ -97,7 +97,7 @@ func createTempKubeConfig(config *api.Config) (string, error) {
 
 	err = clientcmd.WriteToFile(*config, path)
 	if err != nil {
-		os.Remove(path)
+		os.Remove(path) // nolint:gosec // G703: paths from CreateTemp and caller
 		return "", err
 	}
 

pkg/crc/ssh/keys.go

@@ -25,7 +25,7 @@ var (
 )
 
 type KeyPair struct {
-	PrivateKey []byte
+	PrivateKey []byte // nolint:gosec
 	PublicKey  []byte
 }
 
@@ -92,7 +92,7 @@ func RemoveCRCHostEntriesFromKnownHosts() error {
 	}
 	defer func() {
 		tempHostsFile.Close()
-		os.Remove(tempHostsFile.Name())
+		os.Remove(tempHostsFile.Name()) //nolint:gosec // G703: paths from CreateTemp
 	}()
 
 	if err := tempHostsFile.Chmod(0600); err != nil {
@@ -142,7 +142,7 @@ func RemoveCRCHostEntriesFromKnownHosts() error {
 		if err := tempHostsFile.Close(); err != nil {
 			return fmt.Errorf("Error closing temp file: %w", err)
 		}
-		return os.Rename(tempHostsFile.Name(), knownHostsPath)
+		return os.Rename(tempHostsFile.Name(), knownHostsPath) //nolint:gosec // G703: paths from CreateTemp
 	}
 	return nil
 }

pkg/download/download.go

@@ -108,7 +108,7 @@ func InMemory(uri string) (io.ReadCloser, error) {
 		if err != nil {
 			return nil, err
 		}
-		return os.Open(filePath)
+		return os.Open(filePath) // nolint:gosec
 	}
 	client := grab.NewClient()
 	client.HTTPClient = &http.Client{Transport: httpproxy.HTTPTransport()}

pkg/extract/extract.go

@@ -122,7 +122,7 @@ func untar(ctx context.Context, reader io.Reader, targetDir string, fileFilter f
 
 		// if its a dir and it doesn't exist create it
 		case tar.TypeDir:
-			if err := os.MkdirAll(path, header.FileInfo().Mode()); err != nil {
+			if err := os.MkdirAll(path, header.FileInfo().Mode()); err != nil { // nolint:gosec // G703: paths from header.FileInfo()
 				return nil, err
 			}
 
@@ -139,11 +139,11 @@ func untar(ctx context.Context, reader io.Reader, targetDir string, fileFilter f
 
 func uncompressFile(ctx context.Context, tarReader io.Reader, fileInfo os.FileInfo, path string, showProgress bool) error {
 	// with a file filter, we may have skipped the intermediate directories, make sure they exist
-	if err := os.MkdirAll(filepath.Dir(path), 0750); err != nil {
+	if err := os.MkdirAll(filepath.Dir(path), 0750); err != nil { // nolint:gosec // G703: paths from filepath.Dir
 		return err
 	}
 
-	file, err := os.OpenFile(path, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, fileInfo.Mode())
+	file, err := os.OpenFile(path, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, fileInfo.Mode()) // nolint:gosec // G703: paths from filepath.Dir
 	if err != nil {
 		return err
 	}

pkg/libmachine/persist/filestore.go

@@ -31,7 +31,7 @@ func (s Filestore) saveToFile(data []byte, file string) error {
 	}
 	defer os.Remove(tmpfi.Name())
 
-	if err = os.WriteFile(tmpfi.Name(), data, 0600); err != nil {
+	if err = os.WriteFile(tmpfi.Name(), data, 0600); err != nil { // nolint:gosec // G703: paths from CreateTemp
 		return err
 	}
 
@@ -43,7 +43,7 @@ func (s Filestore) saveToFile(data []byte, file string) error {
 		return err
 	}
 
-	err = os.Rename(tmpfi.Name(), file)
+	err = os.Rename(tmpfi.Name(), file) // nolint:gosec // G703: paths from CreateTemp and caller
 	return err
 }