Rename error functions to adopt format convention

NewF => Newf

Author: praveenkumar

pkg/crc/config/viper_config.go

@@ -33,11 +33,11 @@ func Unset(key string) error {
 	delete(ViperConfig, key)
 	encodedConfig, err := json.MarshalIndent(ViperConfig, "", " ")
 	if err != nil {
-		return errors.NewF("Error encoding config to JSON: %v", err)
+		return errors.Newf("Error encoding config to JSON: %v", err)
 	}
 	err = globalViper.ReadConfig(bytes.NewBuffer(encodedConfig))
 	if err != nil {
-		return errors.NewF("Error reading in new config: %s : %v", constants.ConfigFile, err)
+		return errors.Newf("Error reading in new config: %s : %v", constants.ConfigFile, err)
 	}
 	return nil
 }

pkg/crc/errors/error.go

@@ -12,7 +12,7 @@ func New(text string) error {
 	return goerrors.New(text)
 }
 
-func NewF(text string, args ...interface{}) error {
+func Newf(text string, args ...interface{}) error {
 	logging.Errorf(fmt.Sprintf("Error occurred: %s", text), args...)
 	return fmt.Errorf(text, args...)
 }

pkg/crc/machine/driver.go

@@ -32,5 +32,5 @@ func getDriverInfo(driver string) (*MachineDriver, error) {
 			return &d, nil
 		}
 	}
-	return nil, errors.NewF("No info about unknown driver: %s", driver)
+	return nil, errors.Newf("No info about unknown driver: %s", driver)
 }

pkg/crc/machine/machine.go

@@ -124,7 +124,7 @@ func Start(startConfig StartConfig) (StartResult, error) {
 		}
 
 		if host.Driver.DriverName() != startConfig.VMDriver {
-			err := errors.NewF("VM driver '%s' was requested, but loaded VM is using '%s' instead",
+			err := errors.Newf("VM driver '%s' was requested, but loaded VM is using '%s' instead",
 				startConfig.VMDriver, host.Driver.DriverName())
 			result.Error = err.Error()
 			return *result, err
@@ -453,7 +453,7 @@ func Status(statusConfig ClusterStatusConfig) (ClusterStatusResult, error) {
 func existVM(api libmachine.API, machineConfig config.MachineConfig) (bool, error) {
 	exists, err := api.Exists(machineConfig.Name)
 	if err != nil {
-		return false, errors.NewF("Error checking if the host exists: %s", err)
+		return false, errors.Newf("Error checking if the host exists: %s", err)
 	}
 	return exists, nil
 }
@@ -465,11 +465,11 @@ func createHost(api libmachine.API, driverPath string, machineConfig config.Mach
 	vm, err := api.NewHost(machineConfig.VMDriver, driverPath, jsonDriverConfig)
 
 	if err != nil {
-		return nil, errors.NewF("Error creating new host: %s", err)
+		return nil, errors.Newf("Error creating new host: %s", err)
 	}
 
 	if err := api.Create(vm); err != nil {
-		return nil, errors.NewF("Error creating the VM. %s", err)
+		return nil, errors.Newf("Error creating the VM. %s", err)
 	}
 
 	return vm, nil

pkg/crc/validation/validation.go

@@ -21,21 +21,21 @@ func ValidateDriver(driver string) error {
 			return nil
 		}
 	}
-	return errors.NewF("Unsupported driver: %s, use '--vm-driver' option to provide a supported driver %s\n", driver, machine.SupportedDriverValues())
+	return errors.Newf("Unsupported driver: %s, use '--vm-driver' option to provide a supported driver %s\n", driver, machine.SupportedDriverValues())
 }
 
 // ValidateCPUs checks if provided cpus count is valid
 func ValidateCPUs(value int) error {
 	if value < constants.DefaultCPUs {
-		return errors.NewF("CPUs required >=%d", constants.DefaultCPUs)
+		return errors.Newf("CPUs required >=%d", constants.DefaultCPUs)
 	}
 	return nil
 }
 
 // ValidateMemory checks if provided Memory count is valid
 func ValidateMemory(value int) error {
 	if value < constants.DefaultMemory {
-		return errors.NewF("Memory required >=%d", constants.DefaultMemory)
+		return errors.Newf("Memory required >=%d", constants.DefaultMemory)
 	}
 	return nil
 }
@@ -49,7 +49,7 @@ func ValidateBundle(bundle string) error {
 	releaseBundleVersion := version.GetBundleVersion()
 	userProvidedBundleVersion := filepath.Base(bundle)
 	if !strings.Contains(userProvidedBundleVersion, fmt.Sprintf("%s.crcbundle", releaseBundleVersion)) {
-		return errors.NewF("%s bundle is not supported for this release use updated one (crc_<hypervisor>_%s.crcbundle)", userProvidedBundleVersion, releaseBundleVersion)
+		return errors.Newf("%s bundle is not supported for this release use updated one (crc_<hypervisor>_%s.crcbundle)", userProvidedBundleVersion, releaseBundleVersion)
 	}
 	return nil
 }
@@ -58,15 +58,15 @@ func ValidateBundle(bundle string) error {
 func ValidateIpAddress(ipAddress string) error {
 	ip := net.ParseIP(ipAddress).To4()
 	if ip == nil {
-		return errors.NewF("IPv4 address is not valid: '%s'", ipAddress)
+		return errors.Newf("IPv4 address is not valid: '%s'", ipAddress)
 	}
 	return nil
 }
 
 // ValidatePath check if provide path is exist
 func ValidatePath(path string) error {
 	if _, err := os.Stat(path); os.IsNotExist(err) {
-		return errors.NewF("File %s does not exist", path)
+		return errors.Newf("File %s does not exist", path)
 	}
 	return nil
 }

pkg/download/download.go

@@ -13,12 +13,12 @@ func Download(uri, destination string) (string, error) {
 	client := grab.NewClient()
 	req, err := grab.NewRequest(destination, uri)
 	if err != nil {
-		return "", errors.NewF("Not able to get response from %s: %v", uri, err)
+		return "", errors.Newf("Not able to get response from %s: %v", uri, err)
 	}
 	resp := client.Do(req)
 	// check for errors
 	if err := resp.Err(); err != nil {
-		return "", errors.NewF("Download failed: %v\n", err)
+		return "", errors.Newf("Download failed: %v\n", err)
 	}
 
 	logging.Debugf("Download saved to %v \n", resp.Filename)