libmachine: move config version constant along with the struct Host

Version belongs only to this struct.

Author: guillaumerose

pkg/libmachine/host/host.go

@@ -12,6 +12,11 @@ import (
 	"github.com/code-ready/machine/libmachine/state"
 )
 
+// ConfigVersion dictates which version of the config.json format is
+// used. It needs to be bumped if there is a breaking change, and
+// therefore migration, introduced to the config file format.
+const Version = 3
+
 type Host struct {
 	ConfigVersion int
 	Driver        drivers.Driver

pkg/libmachine/host/migrate.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 
 	"github.com/code-ready/crc/pkg/drivers/none"
-	"github.com/code-ready/crc/pkg/libmachine/version"
 )
 
 var (
@@ -37,7 +36,7 @@ func MigrateHost(name string, data []byte) (*Host, error) {
 		return nil, err
 	}
 
-	if hostMetadata.ConfigVersion != version.ConfigVersion {
+	if hostMetadata.ConfigVersion != Version {
 		return nil, errUnexpectedConfigVersion
 	}
 

pkg/libmachine/libmachine.go

@@ -10,7 +10,6 @@ import (
 	"github.com/code-ready/crc/pkg/libmachine/host"
 	"github.com/code-ready/crc/pkg/libmachine/mcnutils"
 	"github.com/code-ready/crc/pkg/libmachine/persist"
-	"github.com/code-ready/crc/pkg/libmachine/version"
 	"github.com/code-ready/machine/libmachine/drivers"
 	rpcdriver "github.com/code-ready/machine/libmachine/drivers/rpc"
 	"github.com/code-ready/machine/libmachine/state"
@@ -52,7 +51,7 @@ func (api *Client) NewHost(driverName string, driverPath string, rawDriver []byt
 	}
 
 	return &host.Host{
-		ConfigVersion: version.ConfigVersion,
+		ConfigVersion: host.Version,
 		Name:          driver.GetMachineName(),
 		Driver:        driver,
 		DriverName:    driver.DriverName(),

pkg/libmachine/persist/filestore_test.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/code-ready/crc/pkg/drivers/none"
 	"github.com/code-ready/crc/pkg/libmachine/host"
-	"github.com/code-ready/crc/pkg/libmachine/version"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -125,7 +124,7 @@ func TestStoreLoad(t *testing.T) {
 
 func testHost() *host.Host {
 	return &host.Host{
-		ConfigVersion: version.ConfigVersion,
+		ConfigVersion: host.Version,
 		Name:          "test-host",
 		Driver:        none.NewDriver("test-host", "/tmp/artifacts"),
 		DriverName:    "none",