Fix react tests

petehunt · zpao · commit 70a0746e9f98 · 2014-01-06T18:35:54.000-08:00
diff --git a/src/core/__tests__/ReactRenderDocument-test.js b/src/core/__tests__/ReactRenderDocument-test.js
@@ -58,7 +58,7 @@ describe('rendering React components at document', function() {
     });
 
     React.renderComponentToString(<Root />, function(markup) {
-      testDocument.innerHTML = markup;
+      testDocument = getTestDocument(markup);
       var component = React.renderComponent(<Root />, testDocument);
       expect(testDocument.body.innerHTML).toBe(' Hello world ');
 
@@ -86,7 +86,7 @@ describe('rendering React components at document', function() {
     });
 
     React.renderComponentToString(<Root />, function(markup) {
-      testDocument.innerHTML = markup;
+      testDocument = getTestDocument(markup);
       React.renderComponent(<Root />, testDocument);
       expect(testDocument.body.innerHTML).toBe(' Hello world ');
 
@@ -137,7 +137,7 @@ describe('rendering React components at document', function() {
     });
 
     React.renderComponentToString(<Component />, function(markup) {
-      testDocument.innerHTML = markup;
+      testDocument = getTestDocument(markup);
 
       React.renderComponent(<Component />, testDocument);
 
@@ -180,7 +180,7 @@ describe('rendering React components at document', function() {
     React.renderComponentToString(
       <Component text="Hello world" />,
       function(markup) {
-        testDocument.innerHTML = markup;
+        testDocument = getTestDocument(markup);
 
         React.renderComponent(<Component text="Hello world" />, testDocument);
 
@@ -210,7 +210,7 @@ describe('rendering React components at document', function() {
     React.renderComponentToString(
       <Component text="Goodbye world" />,
       function(markup) {
-        testDocument.innerHTML = markup;
+        testDocument = getTestDocument(markup);
 
         expect(function() {
           // Notice the text is different!
diff --git a/src/test/getTestDocument.js b/src/test/getTestDocument.js
@@ -16,14 +16,16 @@
  * @providesModule getTestDocument
  */
 
-function getTestDocument() {
+function getTestDocument(markup) {
   var iframe = document.createElement('iframe');
   iframe.style.display = 'none';
   document.body.appendChild(iframe);
 
   var testDocument = iframe.contentDocument || iframe.contentWindow.document;
   testDocument.open();
-  testDocument.write('<!doctype html><html><meta charset=utf-8><title>test doc</title>');
+  testDocument.write(
+    markup || '<!doctype html><html><meta charset=utf-8><title>test doc</title>'
+  );
   testDocument.close();
 
   iframe.parentNode.removeChild(iframe);
