Make logging set up part of exporter startup, not import side effect (#633)

* make logging set up part of exporter startup, not import side effect

Signed-off-by: Kevin M Granger <kgranger@redhat.com>

* Add logging setup to log unit test

Signed-off-by: Kevin M Granger <kgranger@redhat.com>

* Set up logging for release time exporter

Signed-off-by: Kevin M Granger <kgranger@redhat.com>

Author: KevinMGranger

exporters/committime/app.py

@@ -156,6 +156,7 @@ def make_collector(self) -> AbstractCommitCollector:
 
 
 if __name__ == "__main__":
+    pelorus.setup_logging()
     provider_config = load_and_log(CommittimeTypeConfig)
 
     dyn_client = pelorus.utils.get_k8s_client()

exporters/deploytime/app.py

@@ -208,6 +208,7 @@ def get_replicas(
 
 
 if __name__ == "__main__":
+    pelorus.setup_logging()
     dyn_client = pelorus.utils.get_k8s_client()
 
     namespaces = {

exporters/extra/releasetime/app.py

@@ -3,9 +3,11 @@
 from prometheus_client import start_http_server
 from prometheus_client.core import REGISTRY
 
+import pelorus
 from extra.releasetime import collector_github
 
 if __name__ == "__main__":
+    pelorus.setup_logging()
     collector = collector_github.make_collector()
 
     REGISTRY.register(collector)

exporters/failure/app.py

@@ -70,6 +70,7 @@ def getCollector() -> AbstractFailureCollector:
 
 
 if __name__ == "__main__":
+    pelorus.setup_logging()
     logging.info("===== Starting Failure Collector =====")
 
     collector = TrackerFactory.getCollector()

exporters/pelorus/__init__.py

@@ -55,7 +55,7 @@ def _print_version():
 
 
 # region: logging setup
-def _setup_logging():
+def setup_logging():
     _print_version()
     loglevel = utils.get_env_var("LOG_LEVEL", DEFAULT_LOG_LEVEL).upper()
     numeric_level = getattr(logging, loglevel, None)
@@ -72,9 +72,6 @@ def _setup_logging():
     print(f"Initializing Logger with LogLevel: {loglevel}")
 
 
-_setup_logging()
-
-
 # endregion
 
 # A NamespaceSpec lists namespaces to restrict the search to.

exporters/tests/test_config.py

@@ -3,6 +3,7 @@
 import pytest
 from attrs import define, field
 
+import pelorus
 from pelorus.config import load_and_log
 from pelorus.config.converters import comma_separated
 from pelorus.config.loading import env_vars, no_env_vars
@@ -86,6 +87,8 @@ class OtherConfig:
 
 
 def test_logging(caplog: pytest.LogCaptureFixture):
+    pelorus.setup_logging()
+
     @define(kw_only=True)
     class Loggable:
         regular_field: str = field(default="LOG ME 1")