Skip to content

Commit 9867dee

Browse files
Update chart linting (#325)
* Update chart_schema from latest ct upstream * Update chart linting action * Add Chart lock file to gitignore. * Add exporters explicit dependency to pelorus chart * Fix mangled gitignore line
1 parent 3e91ef8 commit 9867dee

4 files changed

Lines changed: 35 additions & 9 deletions

File tree

.github/workflows/chart-lint.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ jobs:
2020
steps:
2121
- name: Checkout code
2222
uses: actions/checkout@v1
23-
24-
- name: Lint Helm charts
25-
uses: helm/chart-testing-action@v1.0.0-rc.2
23+
24+
- name: Install chart-testing tool `ct`
25+
uses: helm/chart-testing-action@v2.1.0
2626
with:
27-
command: lint
28-
config: ct.yaml
27+
version: "v3.4.0"
28+
29+
- name: Lint charts
30+
run: ct lint --config ct.yaml

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,4 +146,7 @@ policy/
146146

147147
# BATS
148148
_test/test_helper/
149-
_test/prometheus/rules.yaml
149+
_test/prometheus/rules.yaml
150+
151+
# Helm
152+
charts/pelorus/Chart.lock

chart_schema.yaml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,37 @@
11
name: str()
22
home: str(required=False)
33
version: str()
4+
apiVersion: str()
45
appVersion: any(str(), num(), required=False)
56
description: str(required=False)
67
keywords: list(str(), required=False)
78
sources: list(str(), required=False)
89
maintainers: list(include('maintainer'), required=False)
10+
dependencies: list(include('dependency'), required=False)
911
icon: str(required=False)
1012
engine: str(required=False)
1113
condition: str(required=False)
1214
tags: str(required=False)
1315
deprecated: bool(required=False)
1416
kubeVersion: str(required=False)
1517
annotations: map(str(), str(), required=False)
18+
type: str(required=False)
1619
---
1720
maintainer:
18-
name: str(required=False)
21+
name: str()
1922
email: str(required=False)
20-
url: str(required=False)
23+
url: str(required=False)
24+
---
25+
dependency:
26+
name: str()
27+
version: str()
28+
repository: str(required=False)
29+
condition: str(required=False)
30+
tags: list(str(), required=False)
31+
enabled: bool(required=False)
32+
import-values: any(list(str()), list(include('import-value')), required=False)
33+
alias: str(required=False)
34+
---
35+
import-value:
36+
child: str()
37+
parent: str()

charts/pelorus/Chart.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,8 @@ type: application
1414

1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
17-
version: 1.4.2
17+
version: 1.4.3
18+
19+
dependencies:
20+
- name: exporters
21+
version: "v1.3.0"

0 commit comments

Comments
 (0)