refactor: move common error messages to lang

Author: ycnmhd

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "lineage",
 	"name": "Lineage",
-	"version": "0.5.0-dev",
+	"version": "0.5.1",
 	"minAppVersion": "0.15.0",
 	"description": "A writing interface that combines structure and content. Inspired by Gingko Writer.",
 	"author": "ycnmhd",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lineage",
-  "version": "0.5.0-dev",
+  "version": "0.5.1",
   "description": "",
   "scripts": {
     "dev": "node esbuild.config.mjs",

src/helpers/store/on-plugin-error.ts

@@ -1,5 +1,6 @@
 import { SilentError } from 'src/stores/view/helpers/errors';
 import { Notice } from 'obsidian';
+import { lang } from 'src/lang/lang';
 
 export const onPluginError = (
     error: Error,
@@ -11,6 +12,8 @@ export const onPluginError = (
         console.error(`[${location}] action: `, action);
         // eslint-disable-next-line no-console
         console.error(`[${location}]`, error);
-        new Notice('Lineage plugin: ' + error.message);
+        const message = error.message.replace(/Invariant failed(: )?/, '');
+        if (message) new Notice(message);
+        else new Notice(lang.error_generic);
     }
 };

src/lang/lang.ts

@@ -7,4 +7,10 @@ export const lang = {
     new_file: 'New lineage document',
     format_headings: 'Format headings',
     extract_branch: 'Extract branch to a new document',
+    error_apply_snapshot_while_editing: 'Cannot apply a snapshot while editing',
+    error_delete_last_node: 'Cannot delete the last card',
+    error_generic:
+        'Something went wrong\nFurther details may be available in the developer console',
+    error_parent_not_found: (full: string) =>
+        `Could not find the parent section of ${full}`,
 };

src/stores/document/reducers/delete-node/delete-node.ts

@@ -5,6 +5,7 @@ import { isLastRootNode } from 'src/stores/document/reducers/delete-node/helpers
 import invariant from 'tiny-invariant';
 import { findNextActiveNode } from 'src/stores/view/reducers/document/helpers/find-next-node/find-next-active-node';
 import { deleteNodeById } from 'src/stores/document/reducers/delete-node/helpers/delete-node-by-id';
+import { lang } from 'src/lang/lang';
 
 export type DeleteNodeAction = {
     type: 'DOCUMENT/DELETE_NODE';
@@ -17,15 +18,15 @@ export const deleteNode = (document: LineageDocument, nodeId: string) => {
     invariant(nodeId);
 
     const lastNode = isLastRootNode(document.columns, nodeId);
-    if (lastNode) throw new Error('cannot delete last root node');
+    if (lastNode) throw new Error(lang.error_delete_last_node);
 
     const nextNode = findNextActiveNode(document.columns, nodeId, {
         type: 'DOCUMENT/DELETE_NODE',
         payload: {
             activeNodeId: nodeId,
         },
     });
-    if (!nextNode) throw new Error('could not find next node');
+    invariant(nextNode);
     deleteChildNodes(document, nodeId);
     deleteNodeById(document.columns, document.content, nodeId);
     cleanAndSortColumns(document);

src/stores/document/reducers/insert-node/insert-node.ts

@@ -30,14 +30,13 @@ export const insertNode = (
             payload.activeNodeId,
         );
         const column = document.columns[columnIndex];
+        invariant(column);
         const group = findGroupByNodeId([column], payload.activeNodeId);
         invariant(group, 'could not find group of ' + payload.activeNodeId);
 
         const groupIndex = group.nodes.findIndex(
             (c) => c === payload.activeNodeId,
         );
-        if (columnIndex === -1 || groupIndex === -1)
-            throw new Error('could not find node index');
 
         const insertionIndex =
             action.payload.position === 'up' ? groupIndex : groupIndex + 1;

src/stores/hotkeys/reducers/load-custom-hotkeys.ts

@@ -5,6 +5,7 @@ import { updateHotkey } from 'src/stores/hotkeys/reducers/update-hotkey';
 import { Hotkey } from 'obsidian';
 import { CustomHotkeys } from 'src/stores/settings/settings-type';
 import { commandToHotkeys } from 'src/stores/hotkeys/reducers/helpers/command-to-hotkeys';
+import invariant from 'tiny-invariant';
 
 export type LoadCustomHotkeysAction = {
     type: 'SETTINGS/LOAD_CUSTOM_HOTKEYS';
@@ -24,8 +25,7 @@ export const loadCustomHotkeys = (
             state.customHotkeys[name as CommandName] = customHotkey;
         }
     }
-    if (!pluginCommands.current)
-        throw new Error('plugin commands are undefined');
+    invariant(pluginCommands.current);
     state.hotkeys = [];
     for (const pluginCommand of pluginCommands.current) {
         const hotkey: CommandHotkeys = commandToHotkeys(pluginCommand);

src/stores/view/helpers/json-to-md/markdown-to-json/markdown-to-json.ts

@@ -1,5 +1,6 @@
 import { parseDelimiter } from 'src/stores/view/helpers/json-to-md/markdown-to-json/helpers/delimiter';
 import { TreeNode } from 'src/stores/view/helpers/json-to-md/columns-to-json/columns-to-json-tree';
+import { lang } from 'src/lang/lang';
 
 const depthLevel = (number: string) => {
     if (number.includes('.')) {
@@ -46,7 +47,7 @@ export const markdownToJson = (text: string) => {
                     depthLevel(parent) > depthLevel(currentParentNumber);
                 if (isChild) {
                     if (!currentNode) {
-                        throw new Error(`could not find parent of ${full}`);
+                        throw new Error(lang.error_parent_not_found(full));
                     }
                     trimCurrentNode(currentNode);
                     currentNode.children.push(newNode);
@@ -59,7 +60,7 @@ export const markdownToJson = (text: string) => {
                     } else {
                         const parentNode = map[parent];
                         if (!parentNode) {
-                            throw new Error(`could not find parent of ${full}`);
+                            throw new Error(lang.error_parent_not_found(full));
                         }
                         if (currentNode) trimCurrentNode(currentNode);
                         parentNode.children.push(newNode);

src/view/components/container/controls-bar/controls-container.svelte

@@ -31,7 +31,7 @@
     const history = historyStore(view);
     const handleNextClick = () => {
         if (viewStore.getValue().document.editing.activeNodeId)
-            new Notice('cannot apply snapshot while editing');
+            new Notice(lang.error_apply_snapshot_while_editing );
         else
             documentStore.dispatch({
                 type: 'HISTORY/APPLY_NEXT_SNAPSHOT',
@@ -40,7 +40,7 @@
 
     const handlePreviousClick = () => {
         if (viewStore.getValue().document.editing.activeNodeId)
-            new Notice('cannot apply snapshot while editing');
+            new Notice(lang.error_apply_snapshot_while_editing);
         else
             documentStore.dispatch({
                 type: 'HISTORY/APPLY_PREVIOUS_SNAPSHOT',

src/view/components/container/controls-bar/modals/snapshots-list/components/snapshot-button.svelte

@@ -7,6 +7,7 @@
     import { getView } from '../../../../context';
     import { Notice } from 'obsidian';
     import invariant from 'tiny-invariant';
+    import { lang } from 'src/lang/lang';
 
     export let snapshot: Snapshot;
     export let active: boolean;
@@ -32,7 +33,7 @@
     class:selected={active}
     on:click={() => {
         if (viewStore.getValue().document.editing.activeNodeId)
-            new Notice('cannot apply snapshot while editing');
+            new Notice(lang.error_apply_snapshot_while_editing);
         else
             documentStore.dispatch({
                 type: 'HISTORY/SELECT_SNAPSHOT',