Fix unused-function warning. (libarchive#2114)

adrianiainlam · web-flow · commit b5182fa98c4a · 2024-04-12T22:13:42.000-07:00
`string_to_size` is only used in a code block conditionally compiled
with `#if HAVE_ZSTD_H &amp;&amp; HAVE_ZSTD_compressStream`. If this block is not
compiled, GCC raises a warning with -Wunused-function.
diff --git a/libarchive/archive_write_add_filter_zstd.c b/libarchive/archive_write_add_filter_zstd.c
@@ -190,6 +190,7 @@ string_to_number(const char *string, intmax_t *numberp)
 	return (ARCHIVE_OK);
 }
 
+#if HAVE_ZSTD_H && HAVE_ZSTD_compressStream
 static int
 string_to_size(const char *string, size_t *numberp)
 {
@@ -224,6 +225,7 @@ string_to_size(const char *string, size_t *numberp)
 	*numberp = (size_t)(number << shift);
 	return (ARCHIVE_OK);
 }
+#endif
 
 /*
  * Set write options.

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,7 @@ string_to_number(const char string, intmax_t numberp)`
`190`	`190`	`return (ARCHIVE_OK);`
`191`	`191`	`}`
`192`	`192`
	`193`	`+#if HAVE_ZSTD_H && HAVE_ZSTD_compressStream`
`193`	`194`	`static int`
`194`	`195`	`string_to_size(const char string, size_t numberp)`
`195`	`196`	`{`
`@@ -224,6 +225,7 @@ string_to_size(const char string, size_t numberp)`
`224`	`225`	`*numberp = (size_t)(number << shift);`
`225`	`226`	`return (ARCHIVE_OK);`
`226`	`227`	`}`
	`228`	`+#endif`
`227`	`229`
`228`	`230`	`/*`
`229`	`231`	`* Set write options.`