Shutdown: Cleanup

Author: Goldfish64

MacHyperVSupport/IntegrationComponents/Shutdown/HyperVShutdownUserClient.cpp

@@ -14,9 +14,9 @@ const IOExternalMethodDispatch HyperVShutdownUserClient::sShutdownMethods[kHyper
   { // kHyperVShutdownUserClientMethodReportShutdownAbility
     reinterpret_cast<IOExternalMethodAction>(&HyperVShutdownUserClient::methodReportShutdownAbility),  // Method pointer
     1,                                        // Num of scalar input values
-    0,                                        // Num of struct input values
+    0,                                        // Size of struct input
     0,                                        // Num of scalar output values
-    0                                         // Num of struct output values
+    0                                         // Size of struct output
   }
 };
 
@@ -68,6 +68,7 @@ IOReturn HyperVShutdownUserClient::externalMethod(uint32_t selector, IOExternalM
 
   return super::externalMethod(selector, arguments, dispatch, target, reference);
 }
+#else
 #endif
 
 IOReturn HyperVShutdownUserClient::notifyClientApplication(HyperVShutdownUserClientNotificationType type) {

MacHyperVSupport/IntegrationComponents/Shutdown/HyperVShutdownUserClient.h

@@ -11,7 +11,7 @@
 #include <libkern/OSTypes.h>
 #include <mach/message.h>
 
-typedef enum {
+typedef enum : UInt32 {
   kHyperVShutdownUserClientMethodReportShutdownAbility,
 
   kHyperVShutdownUserClientMethodNumberOfMethods

MacHyperVSupport/IntegrationComponents/Shutdown/HyperVShutdownUserClientInternal.hpp

@@ -15,7 +15,7 @@ class HyperVShutdownUserClient : public HyperVICUserClient {
   OSDeclareDefaultStructors(HyperVShutdownUserClient);
   HVDeclareLogFunctions("shutuser");
   typedef HyperVICUserClient super;
-  
+
 private:
   bool _isShutdownSupported = false;
 
@@ -25,6 +25,10 @@ class HyperVShutdownUserClient : public HyperVICUserClient {
 #endif
 
   IOReturn notifyClientApplication(HyperVShutdownUserClientNotificationType type);
+
+  //
+  // Userspace external methods.
+  //
   static IOReturn methodReportShutdownAbility(HyperVShutdownUserClient *target, void *ref, IOExternalMethodArguments *args);
 
 public: