Fix coverity issues

Author: Goldfish64

MacHyperVSupport/Controller/HyperVControllerInterrupts.cpp

@@ -264,7 +264,7 @@ void HyperVController::handleInterrupt(OSObject *target, void *refCon, IOService
     //
     // Check each channel for pending interrupt and invoke handler.
     //
-    for (UInt32 i = 1; i <= kVMBusMaxChannels; i++) {
+    for (UInt32 i = 1; i < kVMBusMaxChannels; i++) {
       if (sync_test_and_clear_bit(i, _vmbusRxEventFlags->flags32)) {
         _hvInterruptController->handleInterrupt(nullptr, nullptr, i);
       }
@@ -273,7 +273,7 @@ void HyperVController::handleInterrupt(OSObject *target, void *refCon, IOService
     //
     // Check each channel for pending interrupt and invoke handler.
     //
-    for (UInt32 i = 1; i <= kVMBusMaxChannels; i++) {
+    for (UInt32 i = 1; i < kVMBusMaxChannels; i++) {
       if (sync_test_and_clear_bit(i, _cpuData[cpuIndex].eventFlags[kVMBusInterruptMessage].flags32)) {
         _hvInterruptController->handleInterrupt(nullptr, nullptr, i);
       }

MacHyperVSupport/Keyboard/HyperVKeyboard.cpp

@@ -108,7 +108,7 @@ void HyperVKeyboard::dispatchUnicodeKeyboardEvent(UInt16 unicodeChar, bool isBre
     return;
   }
 
-  if (unicodeChar > arrsize(UnicodeToADBMap)) {
+  if (unicodeChar >= arrsize(UnicodeToADBMap)) {
     HVDBGLOG("Unknown Unicode character 0x%X break: %u", unicodeChar, isBreak);
     return;
   }

MacHyperVSupport/VMBus/HyperVVMBusChannel.cpp

@@ -8,7 +8,7 @@
 #include "HyperVVMBus.hpp"
 
 VMBusChannelStatus HyperVVMBus::getVMBusChannelStatus(UInt32 channelId) {
-  if (channelId == 0 || channelId > kVMBusMaxChannels) {
+  if (channelId == 0 || channelId >= kVMBusMaxChannels) {
     HVDBGLOG("One or more incorrect arguments provided");
     return kVMBusChannelStatusNotPresent;
   }
@@ -29,7 +29,7 @@ IOReturn HyperVVMBus::openVMBusChannel(UInt32 channelId, UInt32 txBufferSize, VM
   //
   // TX and RX buffer sizes must be page-aligned.
   //
-  if (channelId == 0 || channelId > kVMBusMaxChannels
+  if (channelId == 0 || channelId >= kVMBusMaxChannels
       || txBufferSize == 0 || txBuffer == nullptr
       || rxBufferSize == 0 || rxBuffer == nullptr) {
     HVDBGLOG("One or more incorrect arguments provided");
@@ -126,7 +126,7 @@ IOReturn HyperVVMBus::closeVMBusChannel(UInt32 channelId) {
 
   VMBusChannelMessageChannelClose closeMsg;
 
-  if (channelId == 0 || channelId > kVMBusMaxChannels) {
+  if (channelId == 0 || channelId >= kVMBusMaxChannels) {
     HVDBGLOG("One or more incorrect arguments provided");
     return kIOReturnBadArgument;
   }
@@ -187,7 +187,7 @@ IOReturn HyperVVMBus::initVMBusChannelGPADL(UInt32 channelId, HyperVDMABuffer *d
   //
   // DMA buffer size must be page-aligned.
   //
-  if (channelId == 0 || channelId > kVMBusMaxChannels
+  if (channelId == 0 || channelId >= kVMBusMaxChannels
       || dmaBuffer == nullptr || gpadlHandle == nullptr) {
     HVDBGLOG("One or more incorrect arguments provided");
     return kIOReturnBadArgument;
@@ -328,7 +328,7 @@ IOReturn HyperVVMBus::freeVMBusChannelGPADL(UInt32 channelId, UInt32 gpadlHandle
   VMBusChannelMessageGPADLTeardown         gpadlTeardownMsg;
   VMBusChannelMessageGPADLTeardownResponse gpadlTeardownResponseMsg;
 
-  if (channelId == 0 || channelId > kVMBusMaxChannels) {
+  if (channelId == 0 || channelId >= kVMBusMaxChannels) {
     HVDBGLOG("One or more incorrect arguments provided");
     return kIOReturnBadArgument;
   }