Skip to content

Commit b3ac294

Browse files
committed
python: Stop using xrange().
Python 2 had range() and xrange(). xrange() is more efficient, but behaves differently so range() was retained for compatibility. Python 3 only has range() and it behaves like Python 2's xrange(). Remove explicit use of xrange() and use six.moves.range() to make sure we're using xrange() from Python 2 or range() from Python 3. Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
1 parent 73eb682 commit b3ac294

9 files changed

Lines changed: 16 additions & 2 deletions

File tree

debian/ovs-monitor-ipsec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import ovs.db.idl
3939
import ovs.unixctl
4040
import ovs.unixctl.server
4141
import ovs.vlog
42+
from six.moves import range
4243

4344
vlog = ovs.vlog.Vlog("ovs-monitor-ipsec")
4445
root_prefix = '' # Prefix for absolute file names, for testing.

python/ovs/json.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
import StringIO
1717
import sys
1818

19+
from six.moves import range
20+
1921
__pychecker__ = 'no-stringiter'
2022

2123
escapes = {ord('"'): u"\\\"",

python/ovs/ovsuuid.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import re
1616
import uuid
1717

18+
from six.moves import range
19+
1820
from ovs.db import error
1921
import ovs.db.parser
2022

python/ovs/socket_util.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import socket
2020
import sys
2121

22+
from six.moves import range
23+
2224
import ovs.fatal_signal
2325
import ovs.poller
2426
import ovs.vlog
@@ -32,7 +34,7 @@ def make_short_name(long_name):
3234
long_name = os.path.abspath(long_name)
3335
long_dirname = os.path.dirname(long_name)
3436
tmpdir = os.getenv('TMPDIR', '/tmp')
35-
for x in xrange(0, 1000):
37+
for x in range(0, 1000):
3638
link_name = \
3739
'%s/ovs-un-py-%d-%d' % (tmpdir, random.randint(0, 10000), x)
3840
try:

python/ovs/unixctl/server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import os
1818
import types
1919

20+
from six.moves import range
21+
2022
import ovs.dirs
2123
import ovs.jsonrpc
2224
import ovs.stream

python/ovs/vlog.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import sys
2323
import threading
2424

25+
from six.moves import range
26+
2527
import ovs.dirs
2628
import ovs.unixctl
2729
import ovs.util

python/ovstest/util.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import subprocess
2727
import re
2828

29+
from six.moves import range
2930
import six.moves.xmlrpc_client
3031

3132

tests/test-vlog.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@
1515
import argparse
1616

1717
import ovs.vlog
18+
from six.moves import range
1819

1920

2021
def main():
21-
modules = [ovs.vlog.Vlog("module_%d" % i) for i in xrange(3)]
22+
modules = [ovs.vlog.Vlog("module_%d" % i) for i in range(3)]
2223

2324
parser = argparse.ArgumentParser(description="Vlog Module Tester")
2425
ovs.vlog.add_args(parser)

vtep/ovs-vtep

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import ovs.util
2929
import ovs.daemon
3030
import ovs.unixctl.server
3131
import ovs.vlog
32+
from six.moves import range
3233

3334

3435
VERSION = "0.99"

0 commit comments

Comments
 (0)