Skip to content

Commit 992cb6a

Browse files
authored
enhace: optimize alter collection log print (milvus-io#31275)
issue: milvus-io#31142 Signed-off-by: sunby <sunbingyi1992@gmail.com>
1 parent bdc70df commit 992cb6a

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

internal/proxy/impl.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,8 @@ func (node *Proxy) AlterCollection(ctx context.Context, request *milvuspb.AlterC
10491049
log := log.Ctx(ctx).With(
10501050
zap.String("role", typeutil.ProxyRole),
10511051
zap.String("db", request.DbName),
1052-
zap.String("collection", request.CollectionName))
1052+
zap.String("collection", request.CollectionName),
1053+
zap.Any("props", request.Properties))
10531054

10541055
log.Info(
10551056
rpcReceived(method))

internal/rootcoord/broker.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ func (b *ServerBroker) GetSegmentIndexState(ctx context.Context, collID UniqueID
259259
}
260260

261261
func (b *ServerBroker) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
262-
log.Info("broadcasting request to alter collection", zap.String("collectionName", req.GetCollectionName()), zap.Int64("collectionID", req.GetCollectionID()))
262+
log.Info("broadcasting request to alter collection", zap.String("collectionName", req.GetCollectionName()), zap.Int64("collectionID", req.GetCollectionID()), zap.Any("props", req.GetProperties()))
263263

264264
colMeta, err := b.s.meta.GetCollectionByID(ctx, req.GetDbName(), req.GetCollectionID(), typeutil.MaxTimestamp, false)
265265
if err != nil {
@@ -291,7 +291,7 @@ func (b *ServerBroker) BroadcastAlteredCollection(ctx context.Context, req *milv
291291
if resp.ErrorCode != commonpb.ErrorCode_Success {
292292
return errors.New(resp.Reason)
293293
}
294-
log.Info("done to broadcast request to alter collection", zap.String("collectionName", req.GetCollectionName()), zap.Int64("collectionID", req.GetCollectionID()))
294+
log.Info("done to broadcast request to alter collection", zap.String("collectionName", req.GetCollectionName()), zap.Int64("collectionID", req.GetCollectionID()), zap.Any("props", req.GetProperties()))
295295
return nil
296296
}
297297

internal/rootcoord/root_coord.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1272,7 +1272,8 @@ func (c *Core) AlterCollection(ctx context.Context, in *milvuspb.AlterCollection
12721272

12731273
log.Ctx(ctx).Info("received request to alter collection",
12741274
zap.String("role", typeutil.RootCoordRole),
1275-
zap.String("name", in.GetCollectionName()))
1275+
zap.String("name", in.GetCollectionName()),
1276+
zap.Any("props", in.Properties))
12761277

12771278
t := &alterCollectionTask{
12781279
baseTask: newBaseTask(ctx, c),

0 commit comments

Comments
 (0)