Skip to content

Commit 9dbd678

Browse files
authored
enhance: use mmap prefix to define all mmap related configs (milvus-io#31436)
Signed-off-by: sunby <sunbingyi1992@gmail.com>
1 parent 0c153a5 commit 9dbd678

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

configs/milvus.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,8 @@ queryNode:
356356
taskQueueExpire: 60 # 1 min by default, expire time of inner user task queue since queue is empty.
357357
enableCrossUserGrouping: false # false by default Enable Cross user grouping when using user-task-polling policy. (close it if task of any user can not merge others).
358358
maxPendingTaskPerUser: 1024 # 50 by default, max pending task in scheduler per user.
359-
mmapEnabled: false # enable mmap global, if set true, will use mmap to load segment data
359+
mmap:
360+
mmapEnabled: false # enable mmap global, if set true, will use mmap to load segment data
360361

361362
# can specify ip for example
362363
# ip: 127.0.0.1

pkg/util/paramtable/component_param.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2205,17 +2205,19 @@ func (p *queryNodeConfig) init(base *BaseTable) {
22052205
p.CacheEnabled.Init(base.mgr)
22062206

22072207
p.MmapDirPath = ParamItem{
2208-
Key: "queryNode.mmapDirPath",
2208+
Key: "queryNode.mmap.mmapDirPath",
22092209
Version: "2.3.0",
22102210
DefaultValue: "",
2211+
FallbackKeys: []string{"queryNode.mmapDirPath"},
22112212
Doc: "The folder that storing data files for mmap, setting to a path will enable Milvus to load data with mmap",
22122213
}
22132214
p.MmapDirPath.Init(base.mgr)
22142215

22152216
p.MmapEnabled = ParamItem{
2216-
Key: "queryNode.mmapEnabled",
2217+
Key: "queryNode.mmap.mmapEnabled",
22172218
Version: "2.4.0",
22182219
DefaultValue: "false",
2220+
FallbackKeys: []string{"queryNode.mmapEnabled"},
22192221
Doc: "Enable mmap for loading data",
22202222
}
22212223
p.MmapEnabled.Init(base.mgr)

0 commit comments

Comments
 (0)