Skip to content

Commit fa97f86

Browse files
authored
Clean up not used id_cache related code (milvus-io#16655)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
1 parent 337ad53 commit fa97f86

7 files changed

Lines changed: 0 additions & 95 deletions

File tree

configs/embedded-milvus.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ proxy:
130130
maxDimension: 32768 # Maximum dimension of a vector
131131
maxShardNum: 256 # Maximum number of shards in a collection
132132
maxTaskNum: 1024 # max task number of proxy task queue
133-
bufFlagExpireTime: 3600 # second, the time to expire bufFlag from cache in collectResultLoop
134-
bufFlagCleanupInterval: 600 # second, the interval to clean bufFlag cache in collectResultLoop
135133
# please adjust in embedded Milvus: false
136134
ginLogging: false # Whether to produce gin logs.
137135

configs/milvus.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ proxy:
131131
maxDimension: 32768 # Maximum dimension of a vector
132132
maxShardNum: 256 # Maximum number of shards in a collection
133133
maxTaskNum: 1024 # max task number of proxy task queue
134-
bufFlagExpireTime: 3600 # second, the time to expire bufFlag from cache in collectResultLoop
135-
bufFlagCleanupInterval: 600 # second, the interval to clean bufFlag cache in collectResultLoop
136134
# please adjust in embedded Milvus: false
137135
ginLogging: true # Whether to produce gin logs.
138136

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ require (
3131
github.com/mitchellh/mapstructure v1.4.1
3232
github.com/opentracing/opentracing-go v1.2.0
3333
github.com/panjf2000/ants/v2 v2.4.8 // indirect
34-
github.com/patrickmn/go-cache v2.1.0+incompatible
3534
github.com/pierrec/lz4 v2.5.2+incompatible // indirect
3635
github.com/pkg/errors v0.9.1
3736
github.com/prometheus/client_golang v1.11.0

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -534,8 +534,6 @@ github.com/pact-foundation/pact-go v1.0.4/go.mod h1:uExwJY4kCzNPcHRj+hCR/HBbOOIw
534534
github.com/panjf2000/ants/v2 v2.4.8 h1:JgTbolX6K6RreZ4+bfctI0Ifs+3mrE5BIHudQxUDQ9k=
535535
github.com/panjf2000/ants/v2 v2.4.8/go.mod h1:f6F0NZVFsGCp5A7QW/Zj/m92atWwOkY0OIhFxRNFr4A=
536536
github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc=
537-
github.com/patrickmn/go-cache v2.1.0+incompatible h1:HRMgzkcYKYpi3C8ajMPV8OFXaaRUnok+kx1WdO15EQc=
538-
github.com/patrickmn/go-cache v2.1.0+incompatible/go.mod h1:3Qf8kWWT7OJRJbdiICTKqZju1ZixQ/KpMGzzAfe6+WQ=
539537
github.com/pborman/uuid v1.2.0/go.mod h1:X/NO0urCmaxf9VXbdlT7C2Yzkj2IKimNn4k+gtPdI/k=
540538
github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic=
541539
github.com/pelletier/go-toml v1.9.3 h1:zeC5b1GviRUyKYd6OJPvBU/mcVDVoL1OhT17FCt5dSQ=

internal/proxy/id_cache.go

Lines changed: 0 additions & 47 deletions
This file was deleted.

internal/proxy/id_cache_test.go

Lines changed: 0 additions & 27 deletions
This file was deleted.

internal/util/paramtable/component_param.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,6 @@ type proxyConfig struct {
431431
MaxFieldNum int64
432432
MaxShardNum int32
433433
MaxDimension int64
434-
BufFlagExpireTime time.Duration
435-
BufFlagCleanupInterval time.Duration
436434
GinLogging bool
437435

438436
// required from QueryCoord
@@ -460,8 +458,6 @@ func (p *proxyConfig) init(base *BaseTable) {
460458
p.initMaxDimension()
461459

462460
p.initMaxTaskNum()
463-
p.initBufFlagExpireTime()
464-
p.initBufFlagCleanupInterval()
465461
p.initGinLogging()
466462
}
467463

@@ -546,16 +542,6 @@ func (p *proxyConfig) initMaxTaskNum() {
546542
p.MaxTaskNum = p.Base.ParseInt64WithDefault("proxy.maxTaskNum", 1024)
547543
}
548544

549-
func (p *proxyConfig) initBufFlagExpireTime() {
550-
expireTime := p.Base.ParseInt64WithDefault("proxy.bufFlagExpireTime", 3600)
551-
p.BufFlagExpireTime = time.Duration(expireTime) * time.Second
552-
}
553-
554-
func (p *proxyConfig) initBufFlagCleanupInterval() {
555-
interval := p.Base.ParseInt64WithDefault("proxy.bufFlagCleanupInterval", 600)
556-
p.BufFlagCleanupInterval = time.Duration(interval) * time.Second
557-
}
558-
559545
func (p *proxyConfig) initGinLogging() {
560546
// Gin logging is on by default.
561547
p.GinLogging = p.Base.ParseBool("proxy.ginLogging", true)

0 commit comments

Comments
 (0)