Fix bug in micromdm#430 (micromdm#433)

jessepeterson · groob · commit 037a0b999fe4 · 2018-06-11T11:00:18.000-07:00
diff --git a/pkg/crypto/password/password.go b/pkg/crypto/password/password.go
@@ -50,7 +50,7 @@ func SaltedSHA512PBKDF2(plaintext string) (SaltedSHA512PBKDF2Dictionary, error)
 // password dictionary.
 func Verify(plaintext string, h SaltedSHA512PBKDF2Dictionary) error {
 	hashed := pbkdf2.Key([]byte(plaintext), h.Salt, h.Iterations, macKeyLen, sha512.New)
-	if 1 == subtle.ConstantTimeCompare(h.Entropy, hashed) {
+	if 1 != subtle.ConstantTimeCompare(h.Entropy, hashed) {
 		return ErrNoMatch
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func SaltedSHA512PBKDF2(plaintext string) (SaltedSHA512PBKDF2Dictionary, error)`
`50`	`50`	`// password dictionary.`
`51`	`51`	`func Verify(plaintext string, h SaltedSHA512PBKDF2Dictionary) error {`
`52`	`52`	`hashed := pbkdf2.Key([]byte(plaintext), h.Salt, h.Iterations, macKeyLen, sha512.New)`
`53`		`- if 1 == subtle.ConstantTimeCompare(h.Entropy, hashed) {`
	`53`	`+ if 1 != subtle.ConstantTimeCompare(h.Entropy, hashed) {`
`54`	`54`	`return ErrNoMatch`
`55`	`55`	`}`
`56`	`56`	`return nil`