Fix Copilot suggestions in metrics-hooks.js

Signed-off-by: matanbaruch <matan.baruch@unity3d.com>

Author: matanbaruch

lib/util/metrics-hooks.js

@@ -24,18 +24,22 @@ class MetricsHooks {
   static onDeviceStatusChanged(device) {
     // Update device status metrics
     try {
-      let status = 'offline'
+      const previousStatus = device.previousStatus || 'offline';
+      let newStatus = 'offline';
       if (device.present) {
-        status = device.owner ? 'busy' : 'available'
+        newStatus = device.owner ? 'busy' : 'available';
+      }
+      // Update metrics if the status has changed
+      if (previousStatus !== newStatus) {
+        // Decrement the count for the previous status
+        metrics.metrics.devicesByStatus.dec({ status: previousStatus });
+        // Increment the count for the new status
+        metrics.metrics.devicesByStatus.inc({ status: newStatus });
+        log.debug('Device status changed:', device.serial, 'from:', previousStatus, 'to:', newStatus);
       }
-      
-      // This is a simple approximation - in a real implementation
-      // you'd want to track the previous status and update accordingly
-      log.debug('Device status changed:', device.serial, 'status:', status)
     }
     catch (error) {
-      log.error('Error updating device status metrics:', error)
-    }
+      log.error('Error updating device status metrics:', error);    }
   }
 
   static onUserAdded() {