fix(core): parse favicon host via tldts

Use tldts domain parsing in favicon resolution and add its dependency.

Author: aryasaatvik

bun.lock

@@ -15,7 +15,8 @@
     "@executor/codemode-core": "workspace:*",
     "@executor/ir": "workspace:*",
     "@modelcontextprotocol/sdk": "^1.26.0",
-    "effect": "catalog:"
+    "effect": "catalog:",
+    "tldts": "^7.0.27"
   },
   "devDependencies": {
     "@types/node": "catalog:",

packages/sources/core/package.json

@@ -1,16 +1,4 @@
-const COMMON_COMPOUND_SUFFIXES = new Set([
-  "ac.uk",
-  "co.in",
-  "co.jp",
-  "co.nz",
-  "co.uk",
-  "com.au",
-  "com.br",
-  "com.mx",
-  "net.au",
-  "org.au",
-  "org.uk",
-]);
+import { parse as parseDomain } from "tldts";
 
 const RAW_HOSTS = new Set([
   "cdn.jsdelivr.net",
@@ -19,49 +7,13 @@ const RAW_HOSTS = new Set([
   "unpkg.com",
 ]);
 
-function trimOrNull(value: string | null | undefined): string | null {
-  if (value == null) {
-    return null;
-  }
-
-  const trimmed = value.trim();
-  return trimmed.length > 0 ? trimmed : null;
-}
-
-function isIpv4Address(value: string): boolean {
-  return /^\d{1,3}(?:\.\d{1,3}){3}$/.test(value);
-}
-
-export function getRegistrableDomain(hostname: string): string | null {
-  const normalized = hostname.trim().toLowerCase().replace(/^\.+|\.+$/g, "");
-  if (!normalized) {
-    return null;
-  }
-
-  if (normalized === "localhost" || isIpv4Address(normalized)) {
-    return normalized;
-  }
-
-  const parts = normalized.split(".").filter((part) => part.length > 0);
-  if (parts.length < 2) {
-    return null;
-  }
-
-  const suffix = parts.slice(-2).join(".");
-  if (parts.length >= 3 && COMMON_COMPOUND_SUFFIXES.has(suffix)) {
-    return parts.slice(-3).join(".");
-  }
-
-  return parts.slice(-2).join(".");
-}
-
 export function getFaviconUrlForRemoteUrl(
   value: string | null | undefined,
   options: {
     allowRawHosts?: boolean;
   } = {},
 ): string | null {
-  const trimmed = trimOrNull(value);
+  const trimmed = value?.trim();
   if (!trimmed) {
     return null;
   }
@@ -76,10 +28,9 @@ export function getFaviconUrlForRemoteUrl(
       return null;
     }
 
-    const domain = getRegistrableDomain(url.hostname);
-    return domain
-      ? `https://www.google.com/s2/favicons?domain=${encodeURIComponent(domain)}&sz=32`
-      : null;
+    const parsed = parseDomain(url.hostname);
+    const domain = parsed.domain ?? url.hostname;
+    return `https://www.google.com/s2/favicons?domain=${encodeURIComponent(domain)}&sz=32`;
   } catch {
     return null;
   }