Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8

My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178

Author: kmaglione

browser/base/content/test/about/browser.ini

@@ -10,6 +10,7 @@ prefs =
   browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar=false
 
 [browser_aboutCertError.js]
+skip-if = fission
 [browser_aboutCertError_clockSkew.js]
 [browser_aboutCertError_exception.js]
 [browser_aboutCertError_mitm.js]
@@ -26,4 +27,4 @@ skip-if = os == "mac" || (os == "linux" && (!debug || bits == 64)) || (os == 'wi
 [browser_aboutSupport.js]
 [browser_aboutSupport_newtab_security_state.js]
 [browser_bug435325.js]
-skip-if = verify && !debug && os == 'mac'
+skip-if = fission || (verify && !debug && os == 'mac')

browser/base/content/test/favicons/browser.ini

@@ -17,6 +17,7 @@ prefs =
 support-files =
   file_favicon_change.html
 [browser_favicon_change_not_in_document.js]
+fail-if = fission
 support-files =
   file_favicon_change_not_in_document.html
 [browser_multiple_icons_in_short_timeframe.js]

browser/base/content/test/general/browser.ini

@@ -62,6 +62,7 @@ support-files =
 [browser_addKeywordSearch.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_alltabslistener.js]
+fail-if = fission
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_backButtonFitts.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
@@ -98,16 +99,19 @@ skip-if = true # bug 428712
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug431826.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_bug432599.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug441778.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_bug455852.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug462289.js]
 skip-if = toolkit == "cocoa"
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug462673.js]
+fail-if = fission
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug477014.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
@@ -157,6 +161,7 @@ skip-if = toolkit != "cocoa" # Because of tests for supporting pasting from Serv
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug575561.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_bug575830.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug577121.js]
@@ -189,6 +194,7 @@ skip-if = (verify && debug && (os == 'linux'))
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug633691.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_bug647886.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug664672.js]
@@ -220,6 +226,7 @@ uses-unsafe-cpows = true
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug839103.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_bug882977.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug970746.js]
@@ -306,7 +313,7 @@ support-files = test_offline_gzip.html gZipOfflineChild.cacheManifest gZipOfflin
 [browser_plainTextLinks.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_printpreview.js]
-skip-if = os == 'win' # Bug 1384127
+skip-if = fission || os == 'win' # Bug 1384127
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_private_browsing_window.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
@@ -353,6 +360,7 @@ support-files =
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_ssl_error_reports.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_star_hsts.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_storagePressure_notification.js]
@@ -365,6 +373,7 @@ skip-if = verify
 [browser_tab_detach_restore.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_tab_drag_drop_perwindow.js]
+fail-if = fission
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_tab_dragdrop.js]
 skip-if = debug || (os == 'linux') || (os == 'mac') || (os == 'win' && asan) # Bug 1312436, Bug 1388973
@@ -381,6 +390,7 @@ support-files =
   close_beforeunload_opens_second_tab.html
   close_beforeunload.html
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_tabs_isActive.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_tabs_owner.js]
@@ -391,6 +401,7 @@ run-if = e10s
 [browser_typeAheadFind.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_unknownContentType_title.js]
+fail-if = fission
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_unloaddialogs.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
@@ -408,11 +419,13 @@ skip-if = (os == "win" && !debug)
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_web_channel.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_zbug569342.js]
 skip-if = e10s || debug # Bug 1094240 - has findbar-related failures
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_addCertException.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
+skip-if = fission
 [browser_blockHPKP.js]
 skip-if = verify && !debug
 uses-unsafe-cpows = true
@@ -429,13 +442,12 @@ support-files =
 [browser_domFullscreen_fullscreenMode.js]
 tags = fullscreen
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
-# DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_newTabDrop.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_newWindowDrop.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_newwindow_focus.js]
-skip-if = (os == "linux" && !e10s) # Bug 1263254 - Perma fails on Linux without e10s for some reason.
+skip-if = fission || (os == "linux" && !e10s) # Bug 1263254 - Perma fails on Linux without e10s for some reason.
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug1299667.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.

browser/base/content/test/performance/browser.ini

@@ -19,6 +19,7 @@ support-files =
 [browser_appmenu.js]
 skip-if = asan || debug || (os == 'win' && bits == 32) || (os == 'win' && processor == 'aarch64') # Bug 1382809, bug 1369959, Win32 because of intermittent OOM failures, bug 1533141 for aarch64
 [browser_preferences_usage.js]
+fail-if = fission
 skip-if = !debug
 [browser_startup.js]
 [browser_startup_content.js]

browser/base/content/test/permissions/browser.ini

@@ -15,6 +15,7 @@ support-files=
   dummy.js
 [browser_reservedkey.js]
 [browser_temporary_permissions.js]
+fail-if = fission
 support-files =
   temporary_permissions_subframe.html
   ../webrtc/get_user_media.html

browser/base/content/test/plugins/browser.ini

@@ -49,12 +49,14 @@ support-files =
 [browser_bug743421.js]
 tags = blocklist
 [browser_bug744745.js]
+fail-if = fission
 [browser_bug787619.js]
 [browser_bug797677.js]
 [browser_bug812562.js]
 tags = blocklist
 [browser_bug818118.js]
 [browser_bug820497.js]
+fail-if = fission
 [browser_clearplugindata.js]
 tags = blocklist
 [browser_CTP_context_menu.js]
@@ -98,8 +100,9 @@ skip-if = (os == 'win' && processor == 'aarch64') # bug 1533164
 [browser_globalplugin_crashinfobar.js]
 skip-if = !crashreporter
 [browser_pluginCrashCommentAndURL.js]
-skip-if = !crashreporter
+skip-if = fission || !crashreporter
 [browser_pluginCrashReportNonDeterminism.js]
 skip-if = !crashreporter
 [browser_private_clicktoplay.js]
 [browser_subframe_access_hidden_plugins.js]
+fail-if = fission

browser/base/content/test/popupNotifications/browser.ini

@@ -9,7 +9,7 @@ skip-if = (os == "linux" && (debug || asan))
 [browser_popupNotification_2.js]
 skip-if = (os == "linux" && (debug || asan))
 [browser_popupNotification_3.js]
-skip-if = (os == "linux" && (debug || asan)) || verify
+skip-if = fission || (os == "linux" && (debug || asan)) || verify
 [browser_popupNotification_4.js]
 skip-if = (os == "linux" && (debug || asan))
 [browser_popupNotification_5.js]

browser/base/content/test/popups/browser.ini

@@ -7,6 +7,7 @@ support-files =
   popup_blocker_10_popups.html
 skip-if = (os == 'linux') || (e10s && debug) # Frequent bug 1081925 and bug 1125520 failures
 [browser_popup_frames.js]
+fail-if = fission
 support-files =
   popup_blocker.html
   popup_blocker_a.html

browser/base/content/test/siteIdentity/browser.ini

@@ -33,6 +33,7 @@ support-files =
   file_bug906190.js
   file_bug906190.sjs
 [browser_bug1045809.js]
+fail-if = fission
 tags = mcb
 support-files =
   file_bug1045809_1.html
@@ -46,10 +47,12 @@ support-files =
 [browser_getSecurityInfo.js]
 support-files =
   dummy_iframe_page.html
+skip-if = fission
 [browser_identity_UI.js]
 [browser_identityBlock_focus.js]
 support-files = ../permissions/permissions.html
 [browser_identityPopup_clearSiteData.js]
+skip-if = fission
 [browser_identityPopup_custom_roots.js]
 [browser_identityPopup_focus.js]
 [browser_identityPopup_telemetry.js]
@@ -59,6 +62,7 @@ support-files =
   !/toolkit/components/passwordmgr/test/browser/form_basic.html
   !/toolkit/components/passwordmgr/test/browser/insecure_test.html
   !/toolkit/components/passwordmgr/test/browser/insecure_test_subframe.html
+skip-if = fission
 [browser_mcb_redirect.js]
 tags = mcb
 support-files =
@@ -68,7 +72,7 @@ support-files =
   test_mcb_redirect.js
   test_mcb_redirect.sjs
 [browser_mixed_content_cert_override.js]
-skip-if = verify
+skip-if = fission || verify
 tags = mcb
 support-files =
   test-mixedcontent-securityerrors.html
@@ -81,6 +85,7 @@ tags = mcb
 support-files =
   test-mixedcontent-securityerrors.html
 [browser_mixedContentFramesOnHttp.js]
+fail-if = fission
 tags = mcb
 support-files =
   file_mixedContentFramesOnHttp.html
@@ -110,6 +115,7 @@ tags = mcb
 support-files =
   test_no_mcb_for_onions.html
 [browser_check_identity_state.js]
+skip-if = fission
 [browser_iframe_navigation.js]
 support-files =
   iframe_navigation.html

browser/base/content/test/tabs/browser.ini

@@ -26,6 +26,7 @@ support-files =
   file_about_child.html
   file_about_parent.html
 [browser_e10s_switchbrowser.js]
+fail-if = fission
 [browser_e10s_about_process.js]
 [browser_e10s_mozillaweb_process.js]
 [browser_e10s_chrome_process.js]
@@ -60,16 +61,19 @@ skip-if = os == 'mac' # Skipped because macOS keyboard support requires changing
 [browser_multiselect_tabs_using_Shift.js]
 [browser_navigatePinnedTab.js]
 [browser_new_file_whitelisted_http_tab.js]
+fail-if = fission
 skip-if = !e10s # Test only relevant for e10s.
 [browser_new_tab_insert_position.js]
 skip-if = (debug && os == 'linux' && bits == 32) #Bug 1455882, disabled on Linux32 for almost permafailing
 support-files = file_new_tab_page.html
 [browser_new_tab_in_privilegedabout_process_pref.js]
+fail-if = fission
 skip-if = !e10s # Pref and test only relevant for e10s.
 [browser_privilegedmozilla_process_pref.js]
+fail-if = fission
 skip-if = !e10s # Pref and test only relevant for e10s.
 [browser_new_web_tab_in_file_process_pref.js]
-skip-if = !e10s # Pref and test only relevant for e10s.
+skip-if = fission || !e10s # Pref and test only relevant for e10s.
 [browser_newwindow_tabstrip_overflow.js]
 [browser_open_newtab_start_observer_notification.js]
 [browser_opened_file_tab_navigated_to_web.js]
@@ -103,3 +107,4 @@ skip-if = os == 'mac'
 [browser_visibleTabs_contextMenu.js]
 [browser_tabswitch_window_focus.js]
 support-files = open_window_in_new_tab.html
+skip-if = fission