Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 099bd2c

Browse files
committed
Bug 1380690 - Part 1 - Save repo and object dir paths in Mac bundle Info.plist files. r=gps
On Mac developer builds, add $topsrcdir and $topobjdir paths to the application bundle Info.plist files for the main process and plugin-container, removing the dependency on MOZ_DEVELOPER_REPO_DIR and MOZ_DEVELOPER_OBJ_DIR environment variables. MozReview-Commit-ID: JfFFK9sEayn --HG-- extra : rebase_source : ab2d8dd625783326b4108eb1e4ebaf49ef8fbedb
1 parent 7231c87 commit 099bd2c

4 files changed

Lines changed: 10 additions & 2 deletions

File tree

browser/app/Makefile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ tools repackage:: $(DIST)/bin/$(MOZ_APP_NAME)
8989
$(MKDIR) -p $(dist_dest)/$(LPROJ)
9090
rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents $(dist_dest) --exclude English.lproj
9191
rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents/Resources/English.lproj/ $(dist_dest)/$(LPROJ)
92-
sed -e 's/%APP_VERSION%/$(MOZ_APP_VERSION)/' -e 's/%MAC_APP_NAME%/$(MAC_APP_NAME)/' -e 's/%MOZ_MACBUNDLE_ID%/$(MOZ_MACBUNDLE_ID)/' -e 's/%MAC_BUNDLE_VERSION%/$(MAC_BUNDLE_VERSION)/' $(srcdir)/macbuild/Contents/Info.plist.in > $(dist_dest)/Contents/Info.plist
92+
sed -e 's/%APP_VERSION%/$(MOZ_APP_VERSION)/' -e 's/%MAC_APP_NAME%/$(MAC_APP_NAME)/' -e 's/%MOZ_MACBUNDLE_ID%/$(MOZ_MACBUNDLE_ID)/' -e 's/%MAC_BUNDLE_VERSION%/$(MAC_BUNDLE_VERSION)/' -e 's|%MOZ_DEVELOPER_REPO_PATH%|$(topsrcdir)|' -e 's|%MOZ_DEVELOPER_OBJ_PATH%|$(topobjdir)|' $(srcdir)/macbuild/Contents/Info.plist.in > $(dist_dest)/Contents/Info.plist
9393
sed -e 's/%MAC_APP_NAME%/$(MAC_APP_NAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | iconv -f UTF-8 -t UTF-16 > $(dist_dest)/$(LPROJ)/InfoPlist.strings
9494
rsync -a --exclude-from='$(srcdir)/macbuild/Contents/MacOS-files.in' $(DIST)/bin/ $(dist_dest)/Contents/Resources
9595
rsync -a --include-from='$(srcdir)/macbuild/Contents/MacOS-files.in' --exclude '*' $(DIST)/bin/ $(dist_dest)/Contents/MacOS

browser/app/macbuild/Contents/Info.plist.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,5 +220,9 @@
220220
</dict>
221221
<key>NSDisablePersistence</key>
222222
<true/>
223+
<key>MozillaDeveloperRepoPath</key>
224+
<string>%MOZ_DEVELOPER_REPO_PATH%</string>
225+
<key>MozillaDeveloperObjPath</key>
226+
<string>%MOZ_DEVELOPER_OBJ_PATH%</string>
223227
</dict>
224228
</plist>

ipc/app/Makefile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) #{
3333
libs::
3434
$(NSINSTALL) -D $(DIST)/bin/$(PROGRAM).app
3535
rsync -a -C --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app
36-
sed -e 's/%PROGRAM%/$(MOZ_CHILD_PROCESS_NAME)/' $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/Info.plist
36+
sed -e 's/%PROGRAM%/$(MOZ_CHILD_PROCESS_NAME)/' -e 's|%MOZ_DEVELOPER_REPO_PATH%|$(topsrcdir)|' -e 's|%MOZ_DEVELOPER_OBJ_PATH%|$(topobjdir)|' $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/Info.plist
3737
sed -e 's/%APP_NAME%/$(MOZ_CHILD_PROCESS_BUNDLENAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \
3838
iconv -f UTF-8 -t UTF-16 > $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/Resources/English.lproj/InfoPlist.strings
3939
$(NSINSTALL) -D $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/MacOS

ipc/app/macbuild/Contents/Info.plist.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,9 @@
3131
<true/>
3232
<key>NSHighResolutionCapable</key>
3333
<true/>
34+
<key>MozillaDeveloperRepoPath</key>
35+
<string>%MOZ_DEVELOPER_REPO_PATH%</string>
36+
<key>MozillaDeveloperObjPath</key>
37+
<string>%MOZ_DEVELOPER_OBJ_PATH%</string>
3438
</dict>
3539
</plist>

0 commit comments

Comments
 (0)