Bug 1730290 - Replace $LocalAppData in NSIS. r=bytesized,mhowell

1. $LocalAppData behavior changes in NSIS 3.02, previously it always
used CSIDL_LOCAL_APPDATA but it now depends on context, work around
that by directly calling SHGetSpecialFolderPathW.

2. Refactor several other calls to SHGetSpecialFolderPathW for
CSIDL_COMMON_APPDATA and CSIDL_PROGRAMS.

3. Remove broken default path fallback to $APPDATA. I was in this
code for 1. and realized it hadn't worked properly in the full
installer since bug 367539, and it must have never worked in the stub.

4. Remove unused CleanUpdateDirectories and DeleteRelativeProfiles
macros rather than trying to fix them.

Differential Revision: https://phabricator.services.mozilla.com/D125490

Author: agashlin

browser/installer/windows/nsis/installer.nsi

@@ -1262,7 +1262,8 @@ Function WriteInstallationTelemetryData
 
   ; Check for top-level profile directory
   ; Note: This is the same check used to set $ExistingProfile in stub.nsi
-  ${If} ${FileExists} "$LOCALAPPDATA\Mozilla\Firefox"
+  ${GetLocalAppDataFolder} $0
+  ${If} ${FileExists} "$0\Mozilla\Firefox"
     StrCpy $1 "true"
   ${Else}
     StrCpy $1 "false"

browser/installer/windows/nsis/shared.nsh

@@ -417,9 +417,8 @@ ${RemoveDefaultBrowserAgentShortcut}
   Push $2
   Push $3
 
-  ; 2 is CSIDL_PROGRAMS, it's simpler to use this to get the user's Start Menu Programs than
-  ; to use $SMPROGRAMS and rely on SetShellVarContext current.
-  System::Call "Shell32::SHGetSpecialFolderPathW(p 0, t.r1, i 2, i 0)"
+  ; Get the current user's Start Menu Programs.
+  ${GetProgramsFolder} $1
 
   ; The shortcut would have been named MOZ_BASE_NAME regardless of branding.
   ; According to defines.nsi.in AppName should match application.ini, and application.ini.in sets

browser/installer/windows/nsis/stub.nsi

@@ -429,21 +429,13 @@ Function .onInit
 
   SetShellVarContext all ; Set SHCTX to All Users
   ; If the user doesn't have write access to the installation directory set
-  ; the installation directory to a subdirectory of the All Users application
-  ; directory and if the user can't write to that location set the installation
-  ; directory to a subdirectory of the users local application directory
-  ; (e.g. non-roaming).
+  ; the installation directory to a subdirectory of the user's local
+  ; application directory (e.g. non-roaming).
   Call CanWrite
   ${If} "$CanWriteToInstallDir" == "false"
-    StrCpy $INSTDIR "$APPDATA\${BrandFullName}\"
+    ${GetLocalAppDataFolder} $0
+    StrCpy $INSTDIR "$0\${BrandFullName}\"
     Call CanWrite
-    ${If} "$CanWriteToInstallDir" == "false"
-      ; This should never happen but just in case.
-      StrCpy $CanWriteToInstallDir "false"
-    ${Else}
-      StrCpy $INSTDIR "$LOCALAPPDATA\${BrandFullName}\"
-      Call CanWrite
-    ${EndIf}
   ${EndIf}
 
   Call CheckSpace
@@ -692,7 +684,8 @@ Function createInstall
     StrCpy $ExistingBuildID "0"
   ${EndIf}
 
-  ${If} ${FileExists} "$LOCALAPPDATA\Mozilla\Firefox"
+  ${GetLocalAppDataFolder} $0
+  ${If} ${FileExists} "$0\Mozilla\Firefox"
     StrCpy $ExistingProfile "1"
   ${Else}
     StrCpy $ExistingProfile "0"

browser/installer/windows/nsis/uninstaller.nsi

@@ -332,8 +332,8 @@ Function un.GetCommonDirectory
   Push $0   ; Save $0
 
   ; This gets C:\ProgramData or the equivalent.
-  ; 0x23 is CSIDL_COMMON_APPDATA, see CreateUpdateDir in common.nsh.
-  System::Call "Shell32::SHGetSpecialFolderPathW(p 0, t.r0, i 0x23, i 0)"
+  ${GetCommonAppDataFolder} $0
+
   ; Add our subdirectory, this is hardcoded as grandparent of the update directory in
   ; several other places.
   StrCpy $0 "$0\Mozilla"