Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 18fae65

Browse files
committed
Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs files. The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h, and is used in `Codegen.py` because doing something smarter is tricky and suitable for a follow-up. As a result, any change to StaticPrefList.yaml will still trigger recompilation of all the generated DOM bindings files, but that's still a big improvement over trigger recompilation of every file that uses static prefs. Most of the changes in this commit are very boring. The only changes that are not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml. Differential Revision: https://phabricator.services.mozilla.com/D39138 --HG-- extra : moz-landing-system : lando
1 parent 329127d commit 18fae65

386 files changed

Lines changed: 509 additions & 363 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docshell/base/nsDefaultURIFixup.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
#include "mozilla/Unused.h"
2626
#include "nsIObserverService.h"
2727
#include "nsXULAppAPI.h"
28+
#include "mozilla/StaticPrefs_browser.h"
29+
#include "mozilla/StaticPrefs_keyword.h"
2830

2931
// Used to check if external protocol schemes are usable
3032
#include "nsCExternalHandlerService.h"

docshell/base/nsDocShell.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@
3232
#include "mozilla/ResultExtensions.h"
3333
#include "mozilla/ScrollTypes.h"
3434
#include "mozilla/Services.h"
35-
#include "mozilla/StaticPrefs.h"
35+
#include "mozilla/StaticPrefs_browser.h"
36+
#include "mozilla/StaticPrefs_dom.h"
37+
#include "mozilla/StaticPrefs_extensions.h"
38+
#include "mozilla/StaticPrefs_privacy.h"
39+
#include "mozilla/StaticPrefs_ui.h"
3640
#include "mozilla/StartupTimeline.h"
3741
#include "mozilla/StorageAccess.h"
3842
#include "mozilla/Telemetry.h"

docshell/base/nsDocShell.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "mozilla/LinkedList.h"
1313
#include "mozilla/Maybe.h"
1414
#include "mozilla/Move.h"
15-
#include "mozilla/StaticPrefs.h"
15+
#include "mozilla/StaticPrefs_browser.h"
1616
#include "mozilla/TimeStamp.h"
1717
#include "mozilla/UniquePtr.h"
1818
#include "mozilla/WeakPtr.h"

dom/animation/KeyframeEffect.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
#include "mozilla/PresShell.h"
2424
#include "mozilla/PresShellInlines.h"
2525
#include "mozilla/ServoBindings.h"
26-
#include "mozilla/StaticPrefs.h"
26+
#include "mozilla/StaticPrefs_dom.h"
27+
#include "mozilla/StaticPrefs_gfx.h"
2728
#include "mozilla/TypeTraits.h"
2829
#include "Layers.h" // For Layer
2930
#include "nsComputedDOMStyle.h" // nsComputedDOMStyle::GetComputedStyle

dom/animation/KeyframeUtils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "mozilla/ServoBindingTypes.h"
1515
#include "mozilla/ServoCSSParser.h"
1616
#include "mozilla/StyleAnimationValue.h"
17-
#include "mozilla/StaticPrefs.h"
17+
#include "mozilla/StaticPrefs_dom.h"
1818
#include "mozilla/TimingParams.h"
1919
#include "mozilla/dom/BaseKeyframeTypesBinding.h" // For FastBaseKeyframe etc.
2020
#include "mozilla/dom/Document.h" // For Document::AreWebAnimationsImplicitKeyframesEnabled

dom/base/ContentBlockingLog.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
#include "mozilla/dom/ContentChild.h"
1212
#include "mozilla/HashFunctions.h"
1313
#include "mozilla/RandomNum.h"
14+
#include "mozilla/StaticPrefs_browser.h"
15+
#include "mozilla/StaticPrefs_privacy.h"
16+
#include "mozilla/StaticPrefs_telemetry.h"
1417
#include "mozilla/Telemetry.h"
1518
#include "mozilla/Unused.h"
1619
#include "mozilla/XorShift128PlusRNG.h"

dom/base/ContentBlockingLog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "mozilla/AntiTrackingCommon.h"
1111
#include "mozilla/JSONWriter.h"
1212
#include "mozilla/Maybe.h"
13-
#include "mozilla/StaticPrefs.h"
13+
#include "mozilla/StaticPrefs_browser.h"
1414
#include "mozilla/Tuple.h"
1515
#include "mozilla/UniquePtr.h"
1616
#include "nsIWebProgressListener.h"

dom/base/DocGroup.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "mozilla/AbstractThread.h"
1111
#include "mozilla/PerformanceUtils.h"
1212
#include "mozilla/ThrottledEventQueue.h"
13-
#include "mozilla/StaticPrefs.h"
13+
#include "mozilla/StaticPrefs_dom.h"
1414
#include "mozilla/Telemetry.h"
1515
#include "nsIDocShell.h"
1616
#include "nsDOMMutationObserver.h"

dom/base/Document.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,13 @@
3030
#include "mozilla/PresShell.h"
3131
#include "mozilla/PresShellInlines.h"
3232
#include "mozilla/RestyleManager.h"
33-
#include "mozilla/StaticPrefs.h"
33+
#include "mozilla/StaticPrefs_browser.h"
34+
#include "mozilla/StaticPrefs_dom.h"
35+
#include "mozilla/StaticPrefs_full_screen_api.h"
36+
#include "mozilla/StaticPrefs_layout.h"
37+
#include "mozilla/StaticPrefs_plugins.h"
38+
#include "mozilla/StaticPrefs_privacy.h"
39+
#include "mozilla/StaticPrefs_security.h"
3440
#include "mozilla/StorageAccess.h"
3541
#include "mozilla/TextEditor.h"
3642
#include "mozilla/URLExtraData.h"

dom/base/Element.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414

1515
#include "AnimationCommon.h"
1616
#include "mozilla/DebugOnly.h"
17-
#include "mozilla/StaticPrefs.h"
17+
#include "mozilla/StaticPrefs_dom.h"
18+
#include "mozilla/StaticPrefs_layout.h"
1819
#include "mozilla/dom/Animation.h"
1920
#include "mozilla/dom/Attr.h"
2021
#include "mozilla/dom/BindContext.h"

0 commit comments

Comments
 (0)