Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 2023646

Browse files
committed
Bug 1583907 - Add MOZ_NEVER_INLINE to LifoAlloc::mark to work around Clang 9 miscompilation on Android. r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D47435 --HG-- extra : moz-landing-system : lando
1 parent b483d7e commit 2023646

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

js/src/ds/LifoAlloc.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,11 @@ class LifoAlloc {
764764
detail::BumpChunk::Mark chunk;
765765
detail::BumpChunk::Mark oversize;
766766
};
767-
Mark mark();
767+
768+
// Note: MOZ_NEVER_INLINE is a work around for a Clang 9 (PGO) miscompilation.
769+
// See bug 1583907.
770+
MOZ_NEVER_INLINE Mark mark();
771+
768772
void release(Mark mark);
769773

770774
private:

0 commit comments

Comments
 (0)