Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 3b034fc

Browse files
committed
Bug 1351910 - Build more files as unified in ipc/glue. r=billm
One file was excluded for using plarena which it did not. The other was excluded for "clashes with strdup," it does not use strdup. MozReview-Commit-ID: 5X5H9S4j903
1 parent 08fc406 commit 3b034fc

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

ipc/glue/IPCStreamUtils.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,11 @@
2323
#include "nsIAsyncInputStream.h"
2424
#include "nsIAsyncOutputStream.h"
2525
#include "nsIPipe.h"
26+
#include "nsNetCID.h"
2627
#include "nsStreamUtils.h"
2728

29+
using namespace mozilla::dom;
30+
2831
namespace mozilla {
2932
namespace ipc {
3033

ipc/glue/moz.build

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ UNIFIED_SOURCES += [
142142
'CrashReporterMetadataShmem.cpp',
143143
'FileDescriptor.cpp',
144144
'FileDescriptorUtils.cpp',
145+
'GeckoChildProcessHost.cpp',
145146
'InputStreamUtils.cpp',
146147
'IPCMessageUtils.cpp',
147148
'IPCStreamChild.cpp',
@@ -158,17 +159,14 @@ UNIFIED_SOURCES += [
158159
'SharedMemory.cpp',
159160
'Shmem.cpp',
160161
'StringUtil.cpp',
162+
'URIUtils.cpp',
161163
]
162164

163-
# GeckoChildProcessHost.cpp cannot be built in unified mode because it uses plarena.h.
164-
# URIUtils.cpp cannot be built in unified mode because of name clashes on strdup.
165165
SOURCES += [
166166
'BackgroundChildImpl.cpp',
167167
'BackgroundParentImpl.cpp',
168168
'FileDescriptorSetChild.cpp',
169169
'FileDescriptorSetParent.cpp',
170-
'GeckoChildProcessHost.cpp',
171-
'URIUtils.cpp',
172170
]
173171

174172
if CONFIG['_MSC_VER']:

0 commit comments

Comments
 (0)