Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 51a3c01

Browse files
shindlishindli
committed
Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676) Backed out changeset ed554dbb062f (bug 1485676) Backed out changeset 6e78058df94d (bug 1485676) Backed out changeset 3a6f1b0e71f4 (bug 1485676) Backed out changeset 16d2403aa787 (bug 1485676) Backed out changeset 454eddf52157 (bug 1485676) Backed out changeset 926f725f2183 (bug 1485676) Backed out changeset fb03f174bd5f (bug 1485676) Backed out changeset ceb93dd1799a (bug 1485676)
1 parent 25f9ad8 commit 51a3c01

193 files changed

Lines changed: 518 additions & 596 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎browser/components/extensions/parent/ext-devtools.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function getDevToolsPrefBranchName(extensionId) {
3535
*/
3636
global.getDevToolsTargetForContext = async (context) => {
3737
if (context.devToolsTarget) {
38-
await context.devToolsTarget.attach();
38+
await context.devToolsTarget.makeRemote();
3939
return context.devToolsTarget;
4040
}
4141

@@ -48,8 +48,9 @@ global.getDevToolsTargetForContext = async (context) => {
4848
}
4949

5050
const tab = context.devToolsToolbox.target.tab;
51-
context.devToolsTarget = await DevToolsShim.createTargetForTab(tab);
52-
await context.devToolsTarget.attach();
51+
context.devToolsTarget = DevToolsShim.createTargetForTab(tab);
52+
53+
await context.devToolsTarget.makeRemote();
5354

5455
return context.devToolsTarget;
5556
};

‎browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ add_task(async function test_devtools_inspectedWindow_tabId() {
106106

107107
let backgroundPageCurrentTabId = await extension.awaitMessage("current-tab-id");
108108

109-
let target = await gDevTools.getTargetForTab(tab);
109+
let target = gDevTools.getTargetForTab(tab);
110110

111111
await gDevTools.showToolbox(target, "webconsole");
112112
info("developer toolbox opened");
@@ -174,7 +174,7 @@ add_task(async function test_devtools_inspectedWindow_eval() {
174174

175175
await extension.startup();
176176

177-
let target = await gDevTools.getTargetForTab(tab);
177+
let target = gDevTools.getTargetForTab(tab);
178178

179179
await gDevTools.showToolbox(target, "webconsole");
180180
info("developer toolbox opened");
@@ -336,7 +336,7 @@ add_task(async function test_devtools_inspectedWindow_eval_in_page_and_panel() {
336336

337337
await extension.startup();
338338

339-
const target = await gDevTools.getTargetForTab(tab);
339+
const target = gDevTools.getTargetForTab(tab);
340340
const toolbox = await gDevTools.showToolbox(target, "webconsole");
341341
info("developer toolbox opened");
342342

‎browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow_eval_bindings.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ add_task(async function test_devtools_inspectedWindow_eval_bindings() {
5454

5555
await extension.startup();
5656

57-
const target = await gDevTools.getTargetForTab(tab);
57+
const target = gDevTools.getTargetForTab(tab);
5858
// Open the toolbox on the styleeditor, so that the inspector and the
5959
// console panel have not been explicitly activated yet.
6060
const toolbox = await gDevTools.showToolbox(target, "styleeditor");

‎browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow_reload.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ async function runReloadTestCase({urlParams, background, devtoolsPage, testCase}
3737

3838
await extension.startup();
3939

40-
let target = await gDevTools.getTargetForTab(tab);
40+
let target = gDevTools.getTargetForTab(tab);
4141

4242
await gDevTools.showToolbox(target, "webconsole");
4343
info("developer toolbox opened");

‎browser/components/extensions/test/browser/browser_ext_devtools_network.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ add_task(async function test_devtools_network_on_navigated() {
134134
await extension.startup();
135135
await extension.awaitMessage("ready");
136136

137-
let target = await gDevTools.getTargetForTab(tab);
137+
let target = gDevTools.getTargetForTab(tab);
138138

139139
await gDevTools.showToolbox(target, "webconsole");
140140
info("Developer toolbox opened.");
@@ -172,7 +172,7 @@ add_task(async function test_devtools_network_get_har() {
172172
await extension.startup();
173173
await extension.awaitMessage("ready");
174174

175-
let target = await gDevTools.getTargetForTab(tab);
175+
let target = gDevTools.getTargetForTab(tab);
176176

177177
// Open the Toolbox
178178
let toolbox = await gDevTools.showToolbox(target, "webconsole");
@@ -223,7 +223,7 @@ add_task(async function test_devtools_network_on_request_finished() {
223223

224224
await extension.startup();
225225
await extension.awaitMessage("ready");
226-
let target = await gDevTools.getTargetForTab(tab);
226+
let target = gDevTools.getTargetForTab(tab);
227227

228228
// Open the Toolbox
229229
let toolbox = await gDevTools.showToolbox(target, "webconsole");

‎browser/components/extensions/test/browser/browser_ext_devtools_page.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ add_task(async function test_devtools_page_runtime_api_messaging() {
119119
info("Wait the content script load");
120120
await extension.awaitMessage("content_script_loaded");
121121

122-
let target = await gDevTools.getTargetForTab(tab);
122+
let target = gDevTools.getTargetForTab(tab);
123123

124124
info("Open the developer toolbox");
125125
await gDevTools.showToolbox(target, "webconsole");
@@ -247,7 +247,7 @@ add_task(async function test_devtools_page_and_extension_tab_messaging() {
247247
info("Wait the extension tab page load");
248248
await extension.awaitMessage("extension_tab_loaded");
249249

250-
let target = await gDevTools.getTargetForTab(tab);
250+
let target = gDevTools.getTargetForTab(tab);
251251

252252
info("Open the developer toolbox");
253253
await gDevTools.showToolbox(target, "webconsole");

‎browser/components/extensions/test/browser/browser_ext_devtools_panel.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ const DEVTOOLS_THEME_PREF = "devtools.theme";
2525
*/
2626

2727
async function openToolboxForTab(tab) {
28-
const target = await gDevTools.getTargetForTab(tab);
28+
const target = gDevTools.getTargetForTab(tab);
2929
const toolbox = await gDevTools.showToolbox(target, "testBlankPanel");
3030
info("Developer toolbox opened");
3131
return {toolbox, target};
3232
}
3333

3434
async function closeToolboxForTab(tab) {
35-
const target = await gDevTools.getTargetForTab(tab);
35+
const target = gDevTools.getTargetForTab(tab);
3636
await gDevTools.closeToolbox(target);
3737
await target.destroy();
3838
info("Developer toolbox closed");

‎browser/components/extensions/test/browser/browser_ext_devtools_panels_elements.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ add_task(async function test_devtools_panels_elements_onSelectionChanged() {
7979

8080
await extension.startup();
8181

82-
let target = await devtools.TargetFactory.forTab(tab);
82+
let target = devtools.TargetFactory.forTab(tab);
8383

8484
const toolbox = await gDevTools.showToolbox(target, "webconsole");
8585
info("developer toolbox opened");

‎browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ add_task(async function test_devtools_panels_elements_sidebar() {
114114

115115
await extension.startup();
116116

117-
let target = await devtools.TargetFactory.forTab(tab);
117+
let target = devtools.TargetFactory.forTab(tab);
118118

119119
const toolbox = await gDevTools.showToolbox(target, "webconsole");
120120
info("developer toolbox opened");

‎devtools/client/accessibility/panel.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ AccessibilityPanel.prototype = {
6161

6262
// Local monitoring needs to make the target remote.
6363
if (!this.target.isRemote) {
64-
await this.target.attach();
64+
await this.target.makeRemote();
6565
}
6666

6767
this._telemetry = new Telemetry();

0 commit comments

Comments
 (0)