Bug 898156 - crash in thumbnail generation @ mozilla::net::FTPChannelParent::OnStartRequest r=mcmanus

Author: jduell

netwerk/protocol/ftp/FTPChannelParent.cpp

@@ -190,21 +190,39 @@ FTPChannelParent::OnStartRequest(nsIRequest* aRequest, nsISupports* aContext)
 {
   LOG(("FTPChannelParent::OnStartRequest [this=%p]\n", this));
 
-  nsFtpChannel* chan = static_cast<nsFtpChannel*>(aRequest);
+  nsCOMPtr<nsIChannel> chan = do_QueryInterface(aRequest);
+  MOZ_ASSERT(chan);
+  NS_ENSURE_TRUE(chan, NS_ERROR_UNEXPECTED);
+
   int64_t contentLength;
   chan->GetContentLength(&contentLength);
   nsCString contentType;
   chan->GetContentType(contentType);
+
   nsCString entityID;
-  chan->GetEntityID(entityID);
-  PRTime lastModified;
-  chan->GetLastModifiedTime(&lastModified);
+  nsCOMPtr<nsIResumableChannel> resChan = do_QueryInterface(aRequest);
+  MOZ_ASSERT(resChan); // both FTP and HTTP should implement nsIResumableChannel
+  if (resChan) {
+    resChan->GetEntityID(entityID);
+  }
+
+  nsCOMPtr<nsIFTPChannel> ftpChan = do_QueryInterface(aRequest);
+  PRTime lastModified = 0;
+  if (ftpChan) {
+    ftpChan->GetLastModifiedTime(&lastModified);
+  } else {
+    // Temporary hack: if we were redirected to use an HTTP channel (ie FTP is
+    // using an HTTP proxy), cancel, as we don't support those redirects yet.
+    aRequest->Cancel(NS_ERROR_NOT_IMPLEMENTED);
+  }
 
-  URIParams uri;
-  SerializeURI(chan->URI(), uri);
+  URIParams uriparam;
+  nsCOMPtr<nsIURI> uri;
+  chan->GetURI(getter_AddRefs(uri));
+  SerializeURI(uri, uriparam);
 
   if (mIPCClosed || !SendOnStartRequest(contentLength, contentType,
-                                       lastModified, entityID, uri)) {
+                                       lastModified, entityID, uriparam)) {
     return NS_ERROR_UNEXPECTED;
   }