Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit b86f050

Browse files
committed
Bug 1195477 - part 1 - use -no-integrated-as for clang builds on ARM, moz.build changes; r=glandium
We have a lot of assembly written assuming gas's conventions, which clang's integrated assembler doesn't support. Disable the integrated assembler for those pieces of code.
1 parent bb70efd commit b86f050

4 files changed

Lines changed: 19 additions & 0 deletions

File tree

gfx/cairo/libpixman/src/moz.build

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ if CONFIG['OS_ARCH'] != 'Darwin' and CONFIG['GNU_CC']:
2424
'pixman-arm-simd-asm-scaled.S',
2525
'pixman-arm-simd-asm.S',
2626
]
27+
if CONFIG['CLANG_CXX']:
28+
ASFLAGS += [
29+
'-no-integrated-as',
30+
]
2731

2832
SOURCES += [
2933
'pixman-access-accessors.c',

media/libtheora/moz.build

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,3 +104,8 @@ if CONFIG['GNU_AS']:
104104
'-march=armv7-a',
105105
'-mfpu=neon',
106106
]
107+
108+
if CONFIG['CLANG_CXX']:
109+
ASFLAGS += [
110+
'-no-integrated-as',
111+
]

media/libvpx/moz.build

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ if CONFIG['VPX_ARM_ASM']:
5151
LOCAL_INCLUDES += [
5252
'%%%s/sources/android/cpufeatures' % CONFIG['ANDROID_NDK'],
5353
]
54+
if CONFIG['CLANG_CXX']:
55+
ASFLAGS += [
56+
'-no-integrated-as',
57+
]
5458

5559
# boolhuff_armv5te.asm defines the same functions as boolhuff.c instead of
5660
# using RTCD, so we have to make sure we only add one of the two.

media/openmax_dl/dl/moz.build

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,9 @@ if CONFIG['CPU_ARCH'] == 'arm' and CONFIG['BUILD_ARM_NEON']:
8484
DEFINES['BIG_FFT_TABLE'] = True
8585

8686
FINAL_LIBRARY = 'xul'
87+
88+
if CONFIG['CLANG_CXX']:
89+
ASFLAGS += [
90+
'-no-integrated-as',
91+
]
92+

0 commit comments

Comments
 (0)