Bug 1722086 - Part 1: Set default browser from WDBA with UserChoice. r=bytesized

Differential Revision: https://phabricator.services.mozilla.com/D121558

Author: agashlin

toolkit/mozapps/defaultagent/Notification.cpp

@@ -22,6 +22,7 @@
 #include "DefaultBrowser.h"
 #include "EventLog.h"
 #include "Registry.h"
+#include "SetDefaultBrowser.h"
 
 #include "wintoastlib.h"
 
@@ -90,6 +91,14 @@ static ULONGLONG GetFollowupNotificationRequestTime() {
       .valueOr(0);
 }
 
+// Returns false if no value is set.
+static bool GetPrefSetDefaultBrowserUserChoice() {
+  return RegistryGetValueBool(IsPrefixed::Prefixed,
+                              L"SetDefaultBrowserUserChoice")
+      .unwrapOr(mozilla::Some(false))
+      .valueOr(false);
+}
+
 struct ToastStrings {
   mozilla::UniquePtr<wchar_t[]> text1;
   mozilla::UniquePtr<wchar_t[]> text2;
@@ -226,6 +235,35 @@ static bool GetStrings(Strings& strings) {
   return true;
 }
 
+/*
+ * Set the default browser.
+ *
+ * First check if we can directly write UserChoice, if so attempt that.
+ * If we can't write UserChoice, or if the attempt fails, fall back to
+ * showing the Default Apps page of Settings.
+ *
+ * @param aAumi The AUMI of the installation to set as default.
+ *
+ * @return Success (SUCCEEDED(hr)) if all associations were set with
+ *         UserChoice and checked successfully.
+ *         Other return codes indicate a failure which causes us to
+ *         fall back to Settings, see return codes of
+ *         SetDefaultBrowserUserChoice().
+ */
+static HRESULT SetDefaultBrowserFromNotification(const wchar_t* aumi) {
+  // TODO maybe fall back to protocol dialog on Windows 11 (bug 1719832)?
+
+  HRESULT hr = E_FAIL;
+  if (GetPrefSetDefaultBrowserUserChoice()) {
+    hr = SetDefaultBrowserUserChoice(aumi);
+  }
+
+  if (FAILED(hr)) {
+    LaunchModernSettingsDialogDefaultApps();
+  }
+  return hr;
+}
+
 // This encapsulates the data that needs to be protected by a mutex because it
 // will be shared by the main thread and the handler thread.
 // To ensure the data is only written once, handlerDataHasBeenSet should be
@@ -254,14 +292,15 @@ class ToastHandler : public WinToastLib::IWinToastHandler {
   NotificationType mWhichNotification;
   bool mIsLocalizedNotification;
   HANDLE mEvent;
+  const std::wstring mAumiStr;
 
  public:
   ToastHandler(NotificationType whichNotification, bool isEnglishInstall,
-               HANDLE event) {
-    mWhichNotification = whichNotification;
-    mIsLocalizedNotification = !isEnglishInstall;
-    mEvent = event;
-  }
+               HANDLE event, const wchar_t* aumi)
+      : mWhichNotification(whichNotification),
+        mIsLocalizedNotification(!isEnglishInstall),
+        mEvent(event),
+        mAumiStr(aumi) {}
 
   void FinishHandler(NotificationActivities& returnData) const {
     SetReturnData(returnData);
@@ -305,6 +344,9 @@ class ToastHandler : public WinToastLib::IWinToastHandler {
     activitiesPerformed.shown = NotificationShown::Shown;
     activitiesPerformed.action = NotificationAction::ToastClicked;
 
+    // An activation without clicking a specific button does not clearly
+    // signal that the default should be changed, so just show the settings
+    // dialog instead of SetDefaultBrowserFromNotification().
     LaunchModernSettingsDialogDefaultApps();
 
     FinishHandler(activitiesPerformed);
@@ -343,7 +385,8 @@ class ToastHandler : public WinToastLib::IWinToastHandler {
       // "Make Firefox the default" button, on both the initial and followup
       // notifications. "Yes" button on the localized notification.
       activitiesPerformed.action = NotificationAction::MakeFirefoxDefaultButton;
-      LaunchModernSettingsDialogDefaultApps();
+
+      SetDefaultBrowserFromNotification(mAumiStr.c_str());
     }
 
     FinishHandler(activitiesPerformed);
@@ -481,7 +524,7 @@ static NotificationActivities ShowNotification(
   toastTemplate.addAction(toastStrings->action2.get());
   toastTemplate.setImagePath(absImagePath.get());
   ToastHandler* handler =
-      new ToastHandler(whichNotification, isEnglishInstall, event.get());
+      new ToastHandler(whichNotification, isEnglishInstall, event.get(), aumi);
   INT64 id = WinToast::instance()->showToast(toastTemplate, handler, &error);
   if (id < 0) {
     LOG_ERROR_MESSAGE(WinToast::strerror(error).c_str());

toolkit/xre/nsAppRunner.cpp

@@ -266,6 +266,8 @@ static const char kPrefDefaultAgentEnabled[] = "default-browser-agent.enabled";
 static const char kPrefServicesSettingsServer[] = "services.settings.server";
 static const char kPrefSecurityContentSignatureRootHash[] =
     "security.content.signature.root_hash";
+static const char kPrefSetDefaultBrowserUserChoicePref[] =
+    "browser.shell.setDefaultBrowserUserChoice";
 #endif  // defined(MOZ_DEFAULT_BROWSER_AGENT)
 
 #if defined(XP_WIN)
@@ -2133,6 +2135,32 @@ static void OnDefaultAgentTelemetryPrefChanged(const char* aPref, void* aData) {
   NS_ENSURE_SUCCESS_VOID(rv);
 }
 
+static void OnSetDefaultBrowserUserChoicePrefChanged(const char* aPref,
+                                                     void* aData) {
+  nsresult rv;
+  if (strcmp(aPref, kPrefSetDefaultBrowserUserChoicePref) != 0) {
+    return;
+  }
+  nsAutoString valueName;
+  valueName.AssignLiteral("SetDefaultBrowserUserChoice");
+  rv = PrependRegistryValueName(valueName);
+  NS_ENSURE_SUCCESS_VOID(rv);
+
+  nsCOMPtr<nsIWindowsRegKey> regKey =
+      do_CreateInstance("@mozilla.org/windows-registry-key;1", &rv);
+  NS_ENSURE_SUCCESS_VOID(rv);
+
+  nsAutoString keyName;
+  keyName.AppendLiteral(DEFAULT_BROWSER_AGENT_KEY_NAME);
+  rv = regKey->Create(nsIWindowsRegKey::ROOT_KEY_CURRENT_USER, keyName,
+                      nsIWindowsRegKey::ACCESS_WRITE);
+
+  bool prefVal = Preferences::GetBool(aPref, true);
+
+  rv = regKey->WriteIntValue(valueName, prefVal);
+  NS_ENSURE_SUCCESS_VOID(rv);
+}
+
 static void OnDefaultAgentRemoteSettingsPrefChanged(const char* aPref,
                                                     void* aData) {
   nsresult rv;
@@ -5119,6 +5147,11 @@ nsresult XREMain::XRE_mainRun() {
         Preferences::RegisterCallbackAndCall(
             &OnDefaultAgentRemoteSettingsPrefChanged,
             kPrefSecurityContentSignatureRootHash);
+
+        Preferences::RegisterCallbackAndCall(
+            &OnSetDefaultBrowserUserChoicePrefChanged,
+            kPrefSetDefaultBrowserUserChoicePref);
+
         SetDefaultAgentLastRunTime();
       }
 #  endif  // defined(MOZ_DEFAULT_BROWSER_AGENT)