Bug 1430707: Don't MOZ_CRASH when conduit operations fail. r=drno

docfaraday · docfaraday · commit ea3dd6304c80 · 2018-01-19T08:39:59.000-06:00
MozReview-Commit-ID: 32nYEJ3hht2

--HG--
extra : rebase_source : c18a30c442da5ca646943d7ecee37f0cd06d4c71
diff --git a/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp b/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
@@ -487,14 +487,12 @@ PeerConnectionMedia::UpdateMediaPipelines()
   for (RefPtr<TransceiverImpl>& transceiver : mTransceivers) {
     nsresult rv = transceiver->UpdateConduit();
     if (NS_FAILED(rv)) {
-      MOZ_CRASH();
       return rv;
     }
 
     if (!transceiver->IsVideo()) {
       rv = transceiver->SyncWithMatchingVideoConduits(mTransceivers);
       if (NS_FAILED(rv)) {
-        MOZ_CRASH();
         return rv;
       }
       // TODO: If there is no audio, we should probably de-sync. However, this

Original file line number	Diff line number	Diff line change
`@@ -487,14 +487,12 @@ PeerConnectionMedia::UpdateMediaPipelines()`
`487`	`487`	`for (RefPtr<TransceiverImpl>& transceiver : mTransceivers) {`
`488`	`488`	`nsresult rv = transceiver->UpdateConduit();`
`489`	`489`	`if (NS_FAILED(rv)) {`
`490`		`- MOZ_CRASH();`
`491`	`490`	`return rv;`
`492`	`491`	`}`
`493`	`492`
`494`	`493`	`if (!transceiver->IsVideo()) {`
`495`	`494`	`rv = transceiver->SyncWithMatchingVideoConduits(mTransceivers);`
`496`	`495`	`if (NS_FAILED(rv)) {`
`497`		`- MOZ_CRASH();`
`498`	`496`	`return rv;`
`499`	`497`	`}`
`500`	`498`	`// TODO: If there is no audio, we should probably de-sync. However, this`