Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit fd61454

Browse files
committed
Bug 861852 - Telemetry data from the remote protocol always appear in the remote buckets; r=rcampbell
1 parent 1be1928 commit fd61454

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

toolkit/devtools/debugger/dbg-client.jsm

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,15 +245,14 @@ DebuggerClient.requester = function DC_requester(aPacketSkeleton, { telemetry,
245245
return function (...args) {
246246
let histogram, startTime;
247247
if (telemetry) {
248-
let transportType = this._transport instanceof LocalDebuggerTransport
248+
let transportType = this._transport.onOutputStreamReady === undefined
249249
? "LOCAL_"
250250
: "REMOTE_";
251251
let histogramId = "DEVTOOLS_DEBUGGER_RDP_"
252252
+ transportType + telemetry + "_MS";
253253
histogram = Services.telemetry.getHistogramById(histogramId);
254254
startTime = +new Date;
255255
}
256-
257256
let outgoingPacket = {
258257
to: aPacketSkeleton.to || this.actor
259258
};
@@ -831,6 +830,7 @@ function TabClient(aClient, aActor) {
831830

832831
TabClient.prototype = {
833832
get actor() { return this._actor },
833+
get _transport() { return this._client._transport; },
834834

835835
/**
836836
* Detach the client from the tab actor.
@@ -885,6 +885,7 @@ ThreadClient.prototype = {
885885
get actor() { return this._actor; },
886886

887887
get compat() { return this._client.compat; },
888+
get _transport() { return this._client._transport; },
888889

889890
_assertPaused: function TC_assertPaused(aCommand) {
890891
if (!this.paused) {
@@ -1410,6 +1411,7 @@ function GripClient(aClient, aGrip)
14101411

14111412
GripClient.prototype = {
14121413
get actor() { return this._grip.actor },
1414+
get _transport() { return this._client._transport; },
14131415

14141416
valid: true,
14151417

@@ -1500,6 +1502,7 @@ LongStringClient.prototype = {
15001502
get actor() { return this._grip.actor; },
15011503
get length() { return this._grip.length; },
15021504
get initial() { return this._grip.initial; },
1505+
get _transport() { return this._client._transport; },
15031506

15041507
valid: true,
15051508

@@ -1536,6 +1539,8 @@ function SourceClient(aClient, aForm) {
15361539
}
15371540

15381541
SourceClient.prototype = {
1542+
get _transport() { return this._client._transport; },
1543+
15391544
/**
15401545
* Get a long string grip for this SourceClient's source.
15411546
*/
@@ -1593,6 +1598,7 @@ BreakpointClient.prototype = {
15931598

15941599
_actor: null,
15951600
get actor() { return this._actor; },
1601+
get _transport() { return this._client._transport; },
15961602

15971603
/**
15981604
* Remove the breakpoint from the server.

0 commit comments

Comments
 (0)