Fix helidon-io#329 Use JsonBuilderFactory instead of Json.create (helidon-io#330)

* Fix helidon-io#329 Use JsonBuilderFactory instead of Json.create()

Author: barchetta

docs/src/main/docs/webserver/08_json-support.adoc

@@ -56,16 +56,19 @@ Routing.builder()
 [source,java]
 .Handler that receives and returns JSON objects
 ----
-private void sayHello(ServerRequest req, ServerResponse res, JsonObject json) { // <1>
-        JsonObject msg = Json.createObjectBuilder()   // <2>
+private static final JsonBuilderFactory jsonFactory = Json.createBuilderFactory(Collections.emptyMap()); <1>
+
+private void sayHello(ServerRequest req, ServerResponse res, JsonObject json) { // <2>
+        JsonObject msg = jsonFactory.createObjectBuilder()   // <3>
           .add("message", "Hello " + json.getString("name"))
           .build();
-        res.send(msg);                            // <3>
+        res.send(msg);                            // <4>
 }
 ----
-<1> JsonObject is passed to handler
-<2> Create a JsonObject using JSON-P to hold return data
-<3> Send JsonObject in response
+<1> Using a `JsonBuilderFactory` is more efficient than `Json.createObjectBuilder()`
+<2> JsonObject is passed to handler
+<3> Create a JsonObject using JSON-P to hold return data
+<4> Send JsonObject in response
 
 [source,bash]
 .Example of posting JSON to sayHello endpoint

examples/guides/mp-restful-webservice/src/main/java/io/helidon/guides/mp/restfulwebservice/GreetResource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,10 +16,13 @@
 
 package io.helidon.guides.mp.restfulwebservice;
 
+import java.util.Collections;
+
 // tag::javaxImports[]
 import javax.enterprise.context.RequestScoped;
 import javax.inject.Inject;
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 import javax.ws.rs.GET;
 import javax.ws.rs.PUT;
@@ -53,6 +56,9 @@
 @RequestScoped
 public class GreetResource {
 // end::classDecl[]
+
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     /**
      * The greeting message provider.
      */
@@ -128,7 +134,7 @@ public JsonObject getMessage(@PathParam("name") String name) { // <4>
     public JsonObject updateGreeting(@PathParam("greeting") String newGreeting) { // <4>
         greeting.setMessage(newGreeting);
 
-        return Json.createObjectBuilder()
+        return JSON.createObjectBuilder()
                 .add("greeting", newGreeting)
                 .build();
     }
@@ -138,7 +144,7 @@ public JsonObject updateGreeting(@PathParam("greeting") String newGreeting) { //
     private JsonObject createResponse(String who) { // <1>
         String msg = String.format("%s %s!", greeting.getMessage(), who); // <2>
 
-        return Json.createObjectBuilder() // <3>
+        return JSON.createObjectBuilder() // <3>
                 .add("message", msg)
                 .build();
     }

examples/guides/mp-restful-webservice/src/main/java/io/helidon/guides/mp/restfulwebservice/HealthResource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,10 +15,13 @@
  */
 package io.helidon.guides.mp.restfulwebservice;
 
+import java.util.Collections;
+
 // tag::javaxImports[]
 import javax.enterprise.context.RequestScoped;
 import javax.inject.Inject;
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
@@ -35,6 +38,8 @@
 public class HealthResource {
 // end::classDecl[]
 
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     // tag::greetingDecl[]
     @Inject // <1>
     private GreetingMessage greeting; // <2>
@@ -56,7 +61,7 @@ public Response alive() {
         if (greetResourceError == null) {  // <4>
             response = Response.ok().build();
         } else {
-            JsonObject returnObject = Json.createObjectBuilder()
+            JsonObject returnObject = JSON.createObjectBuilder()
                     .add("error", greetResourceError)
                     .build();
             response = Response

examples/guides/se-restful-webservice/src/main/java-start/io/helidon/guides/se/restfulwebservice/GreetService.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,7 +16,10 @@
 
 package io.helidon.guides.se.restfulwebservice;
 
+import java.util.Collections;
+
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 
 import io.helidon.config.Config;
@@ -48,6 +51,8 @@ public class GreetService implements Service {
      */
     private static final Config CONFIG = Config.create().get("app");
 
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     /**
      * The config value for the key {@code greeting}.
      */
@@ -74,7 +79,7 @@ private void getDefaultMessage(final ServerRequest request,
                                    final ServerResponse response) {
         String msg = String.format("%s %s!", greeting, "World");
 
-        JsonObject returnObject = Json.createObjectBuilder()
+        JsonObject returnObject = JSON.createObjectBuilder()
                 .add("message", msg)
                 .build();
         response.send(returnObject);
@@ -90,7 +95,7 @@ private void getMessage(final ServerRequest request,
         String name = request.path().param("name");
         String msg = String.format("%s %s!", greeting, name);
 
-        JsonObject returnObject = Json.createObjectBuilder()
+        JsonObject returnObject = JSON.createObjectBuilder()
                 .add("message", msg)
                 .build();
         response.send(returnObject);
@@ -105,7 +110,7 @@ private void updateGreeting(final ServerRequest request,
                                 final ServerResponse response) {
         greeting = request.path().param("greeting");
 
-        JsonObject returnObject = Json.createObjectBuilder()
+        JsonObject returnObject = JSON.createObjectBuilder()
                 .add("greeting", greeting)
                 .build();
         response.send(returnObject);

examples/guides/se-restful-webservice/src/main/java/io/helidon/guides/se/restfulwebservice/GreetService.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,8 +16,11 @@
 
 package io.helidon.guides.se.restfulwebservice;
 
+import java.util.Collections;
+
 //tag::importsStart[]
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 
 import io.helidon.config.Config;
@@ -61,6 +64,8 @@ public class GreetService implements Service {
     private static final Config CONFIG = Config.create().get("app"); // <1>
     // end::CONFIG[]
 
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     /**
      * The config value for the key {@code greeting}.
      */
@@ -112,7 +117,7 @@ private void getDefaultMessage(final ServerRequest request,
                                    final ServerResponse response) {
         String msg = String.format("%s %s!", greeting, "World"); // <1>
 
-        JsonObject returnObject = Json.createObjectBuilder()
+        JsonObject returnObject = JSON.createObjectBuilder()
                 .add("message", msg) // <2>
                 .build();
         response.send(returnObject); // <3>
@@ -130,7 +135,7 @@ private void getMessage(final ServerRequest request,
         String name = request.path().param("name"); // <1>
         String msg = String.format("%s %s!", greeting, name);
 
-        JsonObject returnObject = Json.createObjectBuilder()
+        JsonObject returnObject = JSON.createObjectBuilder()
                 .add("message", msg)
                 .build();
         response.send(returnObject);
@@ -147,7 +152,7 @@ private void updateGreeting(final ServerRequest request,
                                 final ServerResponse response) {
         greeting = request.path().param("greeting"); // <1>
 
-        JsonObject returnObject = Json.createObjectBuilder() // <2>
+        JsonObject returnObject = JSON.createObjectBuilder() // <2>
                 .add("greeting", greeting)
                 .build();
         response.send(returnObject);

examples/guides/se-restful-webservice/src/main/java/io/helidon/guides/se/restfulwebservice/Main.java

@@ -17,6 +17,7 @@
 package io.helidon.guides.se.restfulwebservice;
 
 import java.io.IOException;
+import java.util.Collections;
 import java.util.logging.LogManager;
 
 // tag::importsHealth1[]
@@ -42,6 +43,7 @@
 // end::importsEnd[]
 // tag::importsHealth3[]
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 // end::importsHealth3[]
 
@@ -54,6 +56,8 @@ public final class Main {
     private static GreetService greetService;
     // end::greetServiceDecl[]
 
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     /**
      * Cannot be instantiated.
      */
@@ -156,7 +160,7 @@ private static void alive(final ServerRequest request,
                     .status(Http.Status.OK_200) //<2>
                     .send();
         } else {
-            JsonObject returnObject = Json.createObjectBuilder() //<3>
+            JsonObject returnObject = JSON.createObjectBuilder() //<3>
                     .add("error", greetServiceError)
                     .build();
             response

examples/guides/se-restful-webservice/src/test/java/io/helidon/guides/se/restfulwebservice/MainTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,13 +16,15 @@
 
 package io.helidon.guides.se.restfulwebservice;
 
+import java.util.Collections;
 import java.util.concurrent.TimeUnit;
 import java.net.URL;
 import java.net.HttpURLConnection;
 
 import javax.json.Json;
 import javax.json.JsonObject;
 import javax.json.JsonReader;
+import javax.json.JsonReaderFactory;
 
 import io.helidon.webserver.WebServer;
 
@@ -34,6 +36,7 @@
 public class MainTest {
 
     private static WebServer webServer;
+    private static final JsonReaderFactory JSON = Json.createReaderFactory(Collections.emptyMap());
 
     @BeforeAll
     public static void startTheServer() throws Exception {
@@ -58,14 +61,14 @@ public void testHelloWorld() throws Exception {
 
         conn = getURLConnection("GET","/greet");
         Assertions.assertEquals(200, conn.getResponseCode(), "HTTP response1");
-        JsonReader jsonReader = Json.createReader(conn.getInputStream());
+        JsonReader jsonReader = JSON.createReader(conn.getInputStream());
         JsonObject jsonObject = jsonReader.readObject();
         Assertions.assertEquals("Hello World!", jsonObject.getString("message"),
                 "default message");
 
         conn = getURLConnection("GET", "/greet/Joe");
         Assertions.assertEquals(200, conn.getResponseCode(), "HTTP response2");
-        jsonReader = Json.createReader(conn.getInputStream());
+        jsonReader = JSON.createReader(conn.getInputStream());
         jsonObject = jsonReader.readObject();
         Assertions.assertEquals("Hello Joe!", jsonObject.getString("message"),
                 "hello Joe message");
@@ -74,7 +77,7 @@ public void testHelloWorld() throws Exception {
         Assertions.assertEquals(200, conn.getResponseCode(), "HTTP response3");
         conn = getURLConnection("GET", "/greet/Jose");
         Assertions.assertEquals(200, conn.getResponseCode(), "HTTP response4");
-        jsonReader = Json.createReader(conn.getInputStream());
+        jsonReader = JSON.createReader(conn.getInputStream());
         jsonObject = jsonReader.readObject();
         Assertions.assertEquals("Hola Jose!", jsonObject.getString("message"),
                 "hola Jose message");

examples/microprofile/hello-world-explicit/src/main/java/io/helidon/microprofile/example/helloworld/explicit/HelloWorldResource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,11 +17,13 @@
 package io.helidon.microprofile.example.helloworld.explicit;
 
 import java.net.URI;
+import java.util.Collections;
 
 import javax.enterprise.context.RequestScoped;
 import javax.enterprise.inject.spi.BeanManager;
 import javax.inject.Inject;
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
@@ -39,6 +41,7 @@
 @Path("helloworld")
 @RequestScoped
 public class HelloWorldResource {
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
     private final Config config;
     private final String applicationName;
     private final URI applicationUri;
@@ -84,7 +87,7 @@ public String message() {
     @GET
     @Produces(MediaType.APPLICATION_JSON)
     public JsonObject getHello(@PathParam("name") String name) {
-        return Json.createObjectBuilder()
+        return JSON.createObjectBuilder()
                 .add("name", name)
                 .add("appName", applicationName)
                 .add("appUri", String.valueOf(applicationUri))

examples/microprofile/hello-world-implicit/src/main/java/io/helidon/microprofile/example/helloworld/implicit/HelloWorldResource.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,12 +17,14 @@
 package io.helidon.microprofile.example.helloworld.implicit;
 
 import java.net.URI;
+import java.util.Collections;
 import java.util.logging.Logger;
 
 import javax.enterprise.context.RequestScoped;
 import javax.enterprise.inject.spi.BeanManager;
 import javax.inject.Inject;
 import javax.json.Json;
+import javax.json.JsonBuilderFactory;
 import javax.json.JsonObject;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
@@ -43,6 +45,9 @@
 @Path("helloworld")
 @RequestScoped
 public class HelloWorldResource {
+
+    private static final JsonBuilderFactory JSON = Json.createBuilderFactory(Collections.emptyMap());
+
     private final Config config;
     private final Logger logger;
     private final int requestId;
@@ -96,7 +101,7 @@ public String message() {
     @GET
     @Produces(MediaType.APPLICATION_JSON)
     public JsonObject getHello(@PathParam("name") String name) {
-        return Json.createObjectBuilder()
+        return JSON.createObjectBuilder()
                 .add("name", name)
                 .add("requestId", requestId)
                 .add("appName", applicationName)