Add the position of the last character (#2146)

* Add the position of the last character
* Add a NEWS bullet
* Bump version

Co-authored-by: christophe dervieux <christophe.dervieux@gmail.com>

Author: oliviermeslin

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: rmarkdown
 Type: Package
 Title: Dynamic Documents for R
-Version: 2.8.3
+Version: 2.8.4
 Authors@R: c(
   person("JJ", "Allaire", role = "aut", email = "jj@rstudio.com"),
   person("Yihui", "Xie", role = c("aut", "cre"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),

NEWS.md

@@ -1,6 +1,8 @@
 rmarkdown 2.9
 ================================================================================
 
+- Fixed an issue with `copy_ressource = TRUE` in `html_document_base` where very long HTML documents were truncated during post processing (thanks, @oliviermeslin, #2145).
+
 - When rendering a `runtime: shiny` document, an extra temp folder will be used in the output path. With the extra temp random folder in the path, predictable output file names may be used. (#2137)
 
 - Floating ToC in `html_document` can now hide headings with unnumbered and unlisted classes (thanks, @atusy, #1993).

R/html_resource_copy.R

@@ -102,10 +102,11 @@ copy_resources <- function(input_str, lib_dir, output_dir, resource_locator) {
 
       # the text from the current replacement to the end of the output,
       # if applicable
-      after <- if (res_rep == length(res_replacements))
-        substring(input_str, ch_pos)
-      else
+      after <- if (res_rep == length(res_replacements)) {
+        substring(input_str, ch_pos, last = nchar(input_str, type = "bytes"))
+      } else {
         ""
+      }
 
       # compose the next segment of the output from the text between
       # replacements and the current replacement text