Skip to content

Commit bd34a42

Browse files
fix(cli): lazily load settings in onModelChange to prevent stale closure data loss (google-gemini#20403)
Co-authored-by: Spencer <spencertang@google.com>
1 parent e2658cc commit bd34a42

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

packages/cli/src/config/config.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,6 @@ export async function loadCliConfig(
430430
const { cwd = process.cwd(), projectHooks } = options;
431431
const debugMode = isDebugMode(argv);
432432

433-
const loadedSettings = loadSettings(cwd);
434-
435433
if (argv.sandbox) {
436434
process.env['GEMINI_SANDBOX'] = 'true';
437435
}
@@ -886,7 +884,7 @@ export async function loadCliConfig(
886884
hooks: settings.hooks || {},
887885
disabledHooks: settings.hooksConfig?.disabled || [],
888886
projectHooks: projectHooks || {},
889-
onModelChange: (model: string) => saveModelChange(loadedSettings, model),
887+
onModelChange: (model: string) => saveModelChange(loadSettings(cwd), model),
890888
onReload: async () => {
891889
const refreshedSettings = loadSettings(cwd);
892890
return {

0 commit comments

Comments
 (0)