Skip to content

Commit 01c6de8

Browse files
authored
3.x supress graphql-data-loader false positive (helidon-io#6563)
* Replace example token with text * Upgrade owasp dependency check to 8.2.1 * Suppress graphql-data-loader false postive. Remove some old suppressions
1 parent 8d3c271 commit 01c6de8

3 files changed

Lines changed: 11 additions & 55 deletions

File tree

etc/dependency-check-suppression.xml

Lines changed: 9 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -50,45 +50,25 @@
5050
<vulnerabilityName>CVE-2021-0341</vulnerabilityName>
5151
</suppress>
5252

53-
<!-- False Positive. This is a CVE again Payara. This is generating a number of false positives.
54-
See https://github.com/jeremylong/DependencyCheck/issues/4781 for one example
53+
<!-- False Positive. This CVE is against graphql-java, not the microprofile-graphql-api
5554
-->
5655
<suppress>
5756
<notes><![CDATA[
58-
file name: jakarta.resource-api-2.0.0.jar
59-
]]></notes>
60-
<packageUrl regex="true">^pkg:maven/jakarta\.resource/jakarta\.resource\-api@.*$</packageUrl>
61-
<cve>CVE-2022-37422</cve>
62-
</suppress>
63-
<suppress>
64-
<notes><![CDATA[
65-
file name: microprofile-jwt-auth-api-2.0.jar
57+
file name: microprofile-graphql-api-2.0.jar
6658
]]></notes>
67-
<packageUrl regex="true">^pkg:maven/org\.eclipse\.microprofile\.jwt/microprofile\-jwt\-auth\-api@.*$</packageUrl>
68-
<cve>CVE-2022-37422</cve>
59+
<packageUrl regex="true">^pkg:maven/org\.eclipse\.microprofile\.graphql/microprofile\-graphql\-api@.*$</packageUrl>
60+
<cve>CVE-2022-37734</cve>
6961
</suppress>
7062

71-
<!--
72-
We use SafeConstructor() or an even more limited custom constructor so this CVE does not apply.
73-
SnakeYaml maintainer has closed their issue as "will not fix".
74-
https://bitbucket.org/snakeyaml/snakeyaml/issues/561/cve-2022-1471-vulnerability-in
63+
<!-- False Positive. This CVE is against graphql-java, not graphql-java-dataloader
64+
See https://github.com/jeremylong/DependencyCheck/issues/5641
7565
-->
7666
<suppress>
7767
<notes><![CDATA[
78-
file name: snakeyaml-1.32.jar
68+
file name: java-dataloader-3.1.0.jar
7969
]]></notes>
80-
<packageUrl regex="true">^pkg:maven/org\.yaml/snakeyaml@.*$</packageUrl>
81-
<vulnerabilityName>CVE-2022-1471</vulnerabilityName>
82-
</suppress>
83-
84-
<!-- False Positive. This CVE is against graphql-java, not the microprofile-graphql-api
85-
-->
86-
<suppress>
87-
<notes><![CDATA[
88-
file name: microprofile-graphql-api-2.0.jar
89-
]]></notes>
90-
<packageUrl regex="true">^pkg:maven/org\.eclipse\.microprofile\.graphql/microprofile\-graphql\-api@.*$</packageUrl>
91-
<cve>CVE-2022-37734</cve>
70+
<packageUrl regex="true">^pkg:maven/com\.graphql\-java/java\-dataloader@.*$</packageUrl>
71+
<cve>CVE-2023-28867</cve>
9272
</suppress>
9373

9474
<!-- False Postive. This CVE is against the kafka server. This is the kafka client
@@ -101,30 +81,6 @@
10181
<cve>CVE-2022-34917</cve>
10282
</suppress>
10383

104-
<!-- False Postives. CVE CVE-2022-45129 is against Payara not jakarta.resource-api nor microprofile
105-
-->
106-
<suppress>
107-
<notes><![CDATA[
108-
file name: jakarta.resource-api-2.0.0.jar
109-
]]></notes>
110-
<packageUrl regex="true">^pkg:maven/jakarta\.resource/jakarta\.resource\-api@.*$</packageUrl>
111-
<cve>CVE-2022-45129</cve>
112-
</suppress>
113-
<suppress>
114-
<notes><![CDATA[
115-
file name: microprofile-config-api-3.0.1.jar
116-
]]></notes>
117-
<packageUrl regex="true">^pkg:maven/org\.eclipse\.microprofile\.config/microprofile\-config\-api@.*$</packageUrl>
118-
<cve>CVE-2022-45129</cve>
119-
</suppress>
120-
<suppress>
121-
<notes><![CDATA[
122-
file name: microprofile-jwt-auth-api-2.0.jar
123-
]]></notes>
124-
<packageUrl regex="true">^pkg:maven/org\.eclipse\.microprofile\.jwt/microprofile\-jwt\-auth\-api@.*$</packageUrl>
125-
<cve>CVE-2022-45129</cve>
126-
</suppress>
127-
12884
<!-- False Positive. CVE-2023-25194 is against Kafka Connect, not the client -->
12985
<!-- See https://github.com/jeremylong/DependencyCheck/issues/5469 -->
13086
<suppress>

integrations/vault/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ Example of obtaining vault instance using a token:
3636
```java
3737
Vault vault = Vault.builder()
3838
.address("http://localhost:8200")
39-
.token("s.oZZcsMzbasmwNqfAxPZOs8jw")
39+
.token("<put-token-here>")
4040
.build();
4141
```

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
<version.plugin.source>3.0.1</version.plugin.source>
121121
<version.plugin.spotbugs>4.4.2.2</version.plugin.spotbugs>
122122
<version.plugin.findsecbugs>1.11.0</version.plugin.findsecbugs>
123-
<version.plugin.dependency-check>8.1.1</version.plugin.dependency-check>
123+
<version.plugin.dependency-check>8.2.1</version.plugin.dependency-check>
124124
<version.plugin.surefire>3.0.0-M5</version.plugin.surefire>
125125
<version.plugin.toolchains>1.1</version.plugin.toolchains>
126126
<version.plugin.version-plugin>2.3</version.plugin.version-plugin>

0 commit comments

Comments
 (0)