Lowercase error messages (apple#945)

dkovba · jglogan · web-flow · commit 38960553cb11 · 2025-12-09T12:32:28.000-08:00
## Type of Change
- [x] Bug fix
- [ ] New feature  
- [ ] Breaking change
- [ ] Documentation update

## Motivation and Context
For consistency, all error messages are lowercased.

## Testing
- [ ] Tested locally
- [ ] Added/updated tests
- [ ] Added/updated docs

---------

Co-authored-by: J Logan &lt;sgtbakerrahulnet@yahoo.com&gt;
diff --git a/Sources/ContainerBuild/BuildPipelineHandler.swift b/Sources/ContainerBuild/BuildPipelineHandler.swift
@@ -105,7 +105,7 @@ public actor BuildPipeline {
             throw NSError(
                 domain: "untilFirstError",
                 code: 1,
-                userInfo: [NSLocalizedDescriptionKey: "Failed to initialize task continuation"])
+                userInfo: [NSLocalizedDescriptionKey: "failed to initialize task continuation"])
         }
         defer { taskContinuation.finish() }
         let stream = AsyncStream<Error> { continuation in
diff --git a/Sources/ContainerBuild/URL+Extensions.swift b/Sources/ContainerBuild/URL+Extensions.swift
@@ -228,7 +228,7 @@ public final class BufferedCopyReader: AsyncSequence {
         throw CocoaError(
             .fileReadUnsupportedScheme,
             userInfo: [
-                NSLocalizedDescriptionKey: "Reset not supported with InputStream-based implementation"
+                NSLocalizedDescriptionKey: "reset not supported with InputStream-based implementation"
             ])
     }
 
@@ -240,7 +240,7 @@ public final class BufferedCopyReader: AsyncSequence {
         throw CocoaError(
             .fileReadUnsupportedScheme,
             userInfo: [
-                NSLocalizedDescriptionKey: "Offset tracking not supported with InputStream-based implementation"
+                NSLocalizedDescriptionKey: "offset tracking not supported with InputStream-based implementation"
             ])
     }
 
@@ -252,7 +252,7 @@ public final class BufferedCopyReader: AsyncSequence {
         throw CocoaError(
             .fileReadUnsupportedScheme,
             userInfo: [
-                NSLocalizedDescriptionKey: "Seeking not supported with InputStream-based implementation"
+                NSLocalizedDescriptionKey: "seeking not supported with InputStream-based implementation"
             ])
     }
 
diff --git a/Sources/ContainerClient/Core/ClientDiskUsage.swift b/Sources/ContainerClient/Core/ClientDiskUsage.swift
@@ -31,7 +31,7 @@ public struct ClientDiskUsage {
         guard let responseData = reply.dataNoCopy(key: .diskUsageStats) else {
             throw ContainerizationError(
                 .internalError,
-                message: "Invalid response from server: missing disk usage data"
+                message: "invalid response from server: missing disk usage data"
             )
         }
 
diff --git a/Sources/ContainerClient/Core/ClientKernel.swift b/Sources/ContainerClient/Core/ClientKernel.swift
@@ -84,7 +84,7 @@ extension ClientKernel {
                 throw err
             }
             throw ContainerizationError(
-                .notFound, message: "Default kernel not configured for architecture \(platform.architecture). Please use the `container system kernel set` command to configure it")
+                .notFound, message: "default kernel not configured for architecture \(platform.architecture), please use the `container system kernel set` command to configure it")
         }
     }
 }
@@ -97,7 +97,7 @@ extension SystemPlatform {
         case "amd64":
             return .linuxAmd
         default:
-            fatalError("Unknown architecture")
+            fatalError("unknown architecture")
         }
     }
 }
diff --git a/Sources/ContainerClient/Core/ClientVolume.swift b/Sources/ContainerClient/Core/ClientVolume.swift
@@ -41,7 +41,7 @@ public struct ClientVolume {
         let reply = try await client.send(message)
 
         guard let responseData = reply.dataNoCopy(key: .volume) else {
-            throw VolumeError.storageError("Invalid response from server")
+            throw VolumeError.storageError("invalid response from server")
         }
 
         return try JSONDecoder().decode(Volume.self, from: responseData)
diff --git a/Sources/ContainerClient/Core/Volume.swift b/Sources/ContainerClient/Core/Volume.swift
@@ -80,17 +80,17 @@ public enum VolumeError: Error, LocalizedError {
     public var errorDescription: String? {
         switch self {
         case .volumeNotFound(let name):
-            return "Volume '\(name)' not found"
+            return "volume '\(name)' not found"
         case .volumeAlreadyExists(let name):
-            return "Volume '\(name)' already exists"
+            return "volume '\(name)' already exists"
         case .volumeInUse(let name):
-            return "Volume '\(name)' is currently in use and cannot be accessed by another container, or deleted."
+            return "volume '\(name)' is currently in use and cannot be accessed by another container, or deleted"
         case .invalidVolumeName(let name):
-            return "Invalid volume name '\(name)'"
+            return "invalid volume name '\(name)'"
         case .driverNotSupported(let driver):
-            return "Volume driver '\(driver)' is not supported"
+            return "volume driver '\(driver)' is not supported"
         case .storageError(let message):
-            return "Storage error: \(message)"
+            return "storage error: \(message)"
         }
     }
 }
diff --git a/Sources/ContainerClient/Parser.swift b/Sources/ContainerClient/Parser.swift
@@ -262,7 +262,7 @@ public struct Parser {
         }()
 
         guard let commandToRun = processArguments, commandToRun.count > 0 else {
-            throw ContainerizationError(.invalidArgument, message: "Command/Entrypoint not specified for container process")
+            throw ContainerizationError(.invalidArgument, message: "command/entrypoint not specified for container process")
         }
 
         let defaultUser: ProcessConfiguration.User = {
diff --git a/Sources/ContainerCommands/Container/ContainerStats.swift b/Sources/ContainerCommands/Container/ContainerStats.swift
@@ -74,7 +74,7 @@ extension Application {
                     guard let container = allContainers.first(where: { $0.id == containerId || $0.id.starts(with: containerId) }) else {
                         throw ContainerizationError(
                             .notFound,
-                            message: "Error: No such container: \(containerId)"
+                            message: "no such container: \(containerId)"
                         )
                     }
                     found.append(container)
@@ -102,7 +102,7 @@ extension Application {
                     guard allContainers.first(where: { $0.id == containerId || $0.id.starts(with: containerId) }) != nil else {
                         throw ContainerizationError(
                             .notFound,
-                            message: "Error: No such container: \(containerId)"
+                            message: "no such container: \(containerId)"
                         )
                     }
                 }
@@ -140,7 +140,7 @@ extension Application {
                     }
                 } catch {
                     clearScreen()
-                    print("Error collecting stats: \(error)")
+                    print("error collecting stats: \(error)")
                     try await Task.sleep(for: .seconds(2))
                 }
             }
diff --git a/Sources/ContainerCommands/DefaultCommand.swift b/Sources/ContainerCommands/DefaultCommand.swift
@@ -42,9 +42,9 @@ struct DefaultCommand: AsyncParsableCommand {
 
         // Check for edge cases and unknown options to match the behavior in the absence of plugins.
         if command.isEmpty {
-            throw ValidationError("Unknown argument '\(command)'")
+            throw ValidationError("unknown argument '\(command)'")
         } else if command.starts(with: "-") {
-            throw ValidationError("Unknown option '\(command)'")
+            throw ValidationError("unknown option '\(command)'")
         }
 
         // Compute canonical plugin directories to show in helpful errors (avoid hard-coded paths)
diff --git a/Sources/ContainerCommands/System/Kernel/KernelSet.swift b/Sources/ContainerCommands/System/Kernel/KernelSet.swift
@@ -67,7 +67,7 @@ extension Application {
 
         private func setKernelFromBinary() async throws {
             guard let binaryPath else {
-                throw ArgumentParser.ValidationError("Missing argument '--binary'")
+                throw ArgumentParser.ValidationError("missing argument '--binary'")
             }
             let absolutePath = URL(fileURLWithPath: binaryPath, relativeTo: .currentDirectory()).absoluteURL.absoluteString
             let platform = try getSystemPlatform()
@@ -76,10 +76,10 @@ extension Application {
 
         private func setKernelFromTar() async throws {
             guard let binaryPath else {
-                throw ArgumentParser.ValidationError("Missing argument '--binary'")
+                throw ArgumentParser.ValidationError("missing argument '--binary'")
             }
             guard let tarPath else {
-                throw ArgumentParser.ValidationError("Missing argument '--tar")
+                throw ArgumentParser.ValidationError("missing argument '--tar")
             }
             let platform = try getSystemPlatform()
             let localTarPath = URL(fileURLWithPath: tarPath, relativeTo: .currentDirectory()).path
diff --git a/Sources/ContainerCommands/System/SystemDF.swift b/Sources/ContainerCommands/System/SystemDF.swift
@@ -44,7 +44,7 @@ extension Application {
                 guard let jsonString = String(data: data, encoding: .utf8) else {
                     throw ContainerizationError(
                         .internalError,
-                        message: "Failed to encode JSON output"
+                        message: "failed to encode JSON output"
                     )
                 }
                 print(jsonString)
diff --git a/Sources/ContainerPersistence/DefaultsStore.swift b/Sources/ContainerPersistence/DefaultsStore.swift
@@ -84,7 +84,7 @@ public enum DefaultsStore {
 
     private static var udSuite: UserDefaults {
         guard let ud = UserDefaults.init(suiteName: self.userDefaultDomain) else {
-            fatalError("Failed to initialize UserDefaults for domain \(self.userDefaultDomain)")
+            fatalError("failed to initialize UserDefaults for domain \(self.userDefaultDomain)")
         }
         return ud
     }
diff --git a/Sources/ContainerPlugin/PluginLoader.swift b/Sources/ContainerPlugin/PluginLoader.swift
@@ -133,7 +133,7 @@ extension PluginLoader {
                             }.first)
                     else {
                         log?.warning(
-                            "Not installing plugin with missing configuration",
+                            "not installing plugin with missing configuration",
                             metadata: [
                                 "path": "\(installURL.path)"
                             ]
@@ -144,7 +144,7 @@ extension PluginLoader {
                     // Warn and skip if this plugin name has been encountered already
                     guard !pluginNames.contains(plugin.name) else {
                         log?.warning(
-                            "Not installing shadowed plugin",
+                            "not installing shadowed plugin",
                             metadata: [
                                 "path": "\(installURL.path)",
                                 "name": "\(plugin.name)",
@@ -157,7 +157,7 @@ extension PluginLoader {
                     pluginNames.insert(plugin.name)
                 } catch {
                     log?.warning(
-                        "Not installing plugin with invalid configuration",
+                        "not installing plugin with invalid configuration",
                         metadata: [
                             "path": "\(installURL.path)",
                             "error": "\(error)",
@@ -183,7 +183,7 @@ extension PluginLoader {
             }
         } catch {
             log?.warning(
-                "Not installing plugin with invalid configuration",
+                "not installing plugin with invalid configuration",
                 metadata: [
                     "name": "\(name)",
                     "error": "\(error)",
diff --git a/Sources/ContainerPlugin/ServiceManager.swift b/Sources/ContainerPlugin/ServiceManager.swift
@@ -72,12 +72,12 @@ public struct ServiceManager {
         let status = launchctl.terminationStatus
         guard status == 0 else {
             throw ContainerizationError(
-                .internalError, message: "command `launchctl list` failed with status \(status). Message: \(String(data: stderrData, encoding: .utf8) ?? "No error message")")
+                .internalError, message: "command `launchctl list` failed with status \(status), message: \(String(data: stderrData, encoding: .utf8) ?? "no error message")")
         }
 
         guard let outputText = String(data: outputData, encoding: .utf8) else {
             throw ContainerizationError(
-                .internalError, message: "could not decode output of command `launchctl list`. Message: \(String(data: stderrData, encoding: .utf8) ?? "No error message")")
+                .internalError, message: "could not decode output of command `launchctl list`, message: \(String(data: stderrData, encoding: .utf8) ?? "no error message")")
         }
 
         // The third field of each line of launchctl list output is the label
diff --git a/Sources/ContainerVersion/CommandLine+Executable.swift b/Sources/ContainerVersion/CommandLine+Executable.swift
@@ -26,7 +26,7 @@ extension CommandLine {
         /// Create the buffer and get the path
         buffer = [CChar](repeating: 0, count: Int(bufferSize))
         guard _NSGetExecutablePath(&buffer, &bufferSize) == 0 else {
-            fatalError("UNEXPECTED: failed to get executable path")
+            fatalError("unexpected: failed to get executable path")
         }
 
         /// Return the path with the executable file component removed the last component and
diff --git a/Sources/ContainerXPC/XPCServer.swift b/Sources/ContainerXPC/XPCServer.swift
@@ -239,12 +239,12 @@ extension xpc_object_t {
     }
 
     var connectionError: Bool {
-        precondition(isError, "Not an error")
+        precondition(isError, "not an error")
         return xpc_equal(self, XPC_ERROR_CONNECTION_INVALID) || xpc_equal(self, XPC_ERROR_CONNECTION_INTERRUPTED)
     }
 
     var connectionClosed: Bool {
-        precondition(isError, "Not an error")
+        precondition(isError, "not an error")
         return xpc_equal(self, XPC_ERROR_CONNECTION_INVALID)
     }
 
@@ -253,7 +253,7 @@ extension xpc_object_t {
     }
 
     var errorDescription: String? {
-        precondition(isError, "Not an error")
+        precondition(isError, "not an error")
         let cstring = xpc_dictionary_get_string(self, XPC_ERROR_KEY_DESCRIPTION)
         guard let cstring else {
             return nil
diff --git a/Sources/Helpers/APIServer/ContainerDNSHandler.swift b/Sources/Helpers/APIServer/ContainerDNSHandler.swift
@@ -97,12 +97,12 @@ struct ContainerDNSHandler: DNSHandler {
 
         let components = ipAllocation.address.split(separator: "/")
         guard !components.isEmpty else {
-            throw DNSResolverError.serverError("Invalid IP format: empty address")
+            throw DNSResolverError.serverError("invalid IP format: empty address")
         }
 
         let ipString = String(components[0])
         guard let ip = IPv4(ipString) else {
-            throw DNSResolverError.serverError("Failed to parse IP address: \(ipString)")
+            throw DNSResolverError.serverError("failed to parse IP address: \(ipString)")
         }
 
         return HostRecord<IPv4>(name: question.name, ttl: ttl, ip: ip)
diff --git a/Sources/Services/ContainerAPIService/Volumes/VolumesService.swift b/Sources/Services/ContainerAPIService/Volumes/VolumesService.swift
@@ -153,7 +153,7 @@ public actor VolumesService {
         let sizeInBytes = UInt64(bytes)
 
         guard sizeInBytes >= minSize else {
-            throw VolumeError.storageError("Volume size too small: minimum 1MiB")
+            throw VolumeError.storageError("volume size too small: minimum 1MiB")
         }
 
         return sizeInBytes
@@ -206,7 +206,7 @@ public actor VolumesService {
         labels: [String: String]
     ) async throws -> Volume {
         guard VolumeStorage.isValidVolumeName(name) else {
-            throw VolumeError.invalidVolumeName("Invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
+            throw VolumeError.invalidVolumeName("invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
         }
 
         // Check if volume already exists by trying to list and finding it
@@ -245,7 +245,7 @@ public actor VolumesService {
 
     private func _delete(name: String) async throws {
         guard VolumeStorage.isValidVolumeName(name) else {
-            throw VolumeError.invalidVolumeName("Invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
+            throw VolumeError.invalidVolumeName("invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
         }
 
         // Check if volume exists by trying to list and finding it
@@ -273,7 +273,7 @@ public actor VolumesService {
 
     private func _inspect(_ name: String) async throws -> Volume {
         guard VolumeStorage.isValidVolumeName(name) else {
-            throw VolumeError.invalidVolumeName("Invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
+            throw VolumeError.invalidVolumeName("invalid volume name '\(name)': must match \(VolumeStorage.volumeNamePattern)")
         }
 
         let volumes = try await store.list()
diff --git a/Sources/Services/ContainerImagesService/Server/ImageService.swift b/Sources/Services/ContainerImagesService/Server/ImageService.swift
@@ -235,7 +235,7 @@ extension ImagesService {
                 throw err
             }
             guard authentication != nil else {
-                throw ContainerizationError(.internalError, message: "\(String(describing: err)). No credentials found for host \(host)")
+                throw ContainerizationError(.internalError, message: "\(String(describing: err)), no credentials found for host \(host)")
             }
             throw err
         }
diff --git a/Sources/Services/ContainerImagesService/Server/SnapshotStore.swift b/Sources/Services/ContainerImagesService/Server/SnapshotStore.swift
@@ -84,7 +84,7 @@ public actor SnapshotStore {
                 throw ContainerizationError(.internalError, message: "missing platform for descriptor \(desc.digest)")
             }
             guard let unpacker = try await self.unpackStrategy(image, platform) else {
-                self.log?.warning("Skipping unpack for \(image.reference) for platform \(platform.description). No unpacker configured.")
+                self.log?.warning("no unpacker configured, skipping unpack for \(image.reference) for platform \(platform.description)")
                 continue
             }
             let currentSubTask = await taskManager.startTask()
diff --git a/Sources/TerminalProgress/ProgressConfig.swift b/Sources/TerminalProgress/ProgressConfig.swift
@@ -163,7 +163,7 @@ extension ProgressConfig {
         public var description: String {
             switch self {
             case .invalid(let reason):
-                return "Failed to validate config (\(reason))"
+                return "failed to validate config (\(reason))"
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public actor BuildPipeline {`
`105`	`105`	`throw NSError(`
`106`	`106`	`domain: "untilFirstError",`
`107`	`107`	`code: 1,`
`108`		`- userInfo: [NSLocalizedDescriptionKey: "Failed to initialize task continuation"])`
	`108`	`+ userInfo: [NSLocalizedDescriptionKey: "failed to initialize task continuation"])`
`109`	`109`	`}`
`110`	`110`	`defer { taskContinuation.finish() }`
`111`	`111`	`let stream = AsyncStream<Error> { continuation in`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public struct ClientDiskUsage {`
`31`	`31`	`guard let responseData = reply.dataNoCopy(key: .diskUsageStats) else {`
`32`	`32`	`throw ContainerizationError(`
`33`	`33`	`.internalError,`
`34`		`- message: "Invalid response from server: missing disk usage data"`
	`34`	`+ message: "invalid response from server: missing disk usage data"`
`35`	`35`	`)`
`36`	`36`	`}`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ extension ClientKernel {`
`84`	`84`	`throw err`
`85`	`85`	`}`
`86`	`86`	`throw ContainerizationError(`
`87`		- .notFound, message: "Default kernel not configured for architecture \(platform.architecture). Please use the `container system kernel set` command to configure it")
	`87`	+ .notFound, message: "default kernel not configured for architecture \(platform.architecture), please use the `container system kernel set` command to configure it")
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`	`}`
`@@ -97,7 +97,7 @@ extension SystemPlatform {`
`97`	`97`	`case "amd64":`
`98`	`98`	`return .linuxAmd`
`99`	`99`	`default:`
`100`		`- fatalError("Unknown architecture")`
	`100`	`+ fatalError("unknown architecture")`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public struct ClientVolume {`
`41`	`41`	`let reply = try await client.send(message)`
`42`	`42`
`43`	`43`	`guard let responseData = reply.dataNoCopy(key: .volume) else {`
`44`		`- throw VolumeError.storageError("Invalid response from server")`
	`44`	`+ throw VolumeError.storageError("invalid response from server")`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`return try JSONDecoder().decode(Volume.self, from: responseData)`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ public struct Parser {`
`262`	`262`	`}()`
`263`	`263`
`264`	`264`	`guard let commandToRun = processArguments, commandToRun.count > 0 else {`
`265`		`- throw ContainerizationError(.invalidArgument, message: "Command/Entrypoint not specified for container process")`
	`265`	`+ throw ContainerizationError(.invalidArgument, message: "command/entrypoint not specified for container process")`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`let defaultUser: ProcessConfiguration.User = {`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ extension Application {`
`74`	`74`	`guard let container = allContainers.first(where: { $0.id == containerId \|\| $0.id.starts(with: containerId) }) else {`
`75`	`75`	`throw ContainerizationError(`
`76`	`76`	`.notFound,`
`77`		`- message: "Error: No such container: \(containerId)"`
	`77`	`+ message: "no such container: \(containerId)"`
`78`	`78`	`)`
`79`	`79`	`}`
`80`	`80`	`found.append(container)`
`@@ -102,7 +102,7 @@ extension Application {`
`102`	`102`	`guard allContainers.first(where: { $0.id == containerId \|\| $0.id.starts(with: containerId) }) != nil else {`
`103`	`103`	`throw ContainerizationError(`
`104`	`104`	`.notFound,`
`105`		`- message: "Error: No such container: \(containerId)"`
	`105`	`+ message: "no such container: \(containerId)"`
`106`	`106`	`)`
`107`	`107`	`}`
`108`	`108`	`}`
`@@ -140,7 +140,7 @@ extension Application {`
`140`	`140`	`}`
`141`	`141`	`} catch {`
`142`	`142`	`clearScreen()`
`143`		`- print("Error collecting stats: \(error)")`
	`143`	`+ print("error collecting stats: \(error)")`
`144`	`144`	`try await Task.sleep(for: .seconds(2))`
`145`	`145`	`}`
`146`	`146`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ extension Application {`
`67`	`67`
`68`	`68`	`private func setKernelFromBinary() async throws {`
`69`	`69`	`guard let binaryPath else {`
`70`		`- throw ArgumentParser.ValidationError("Missing argument '--binary'")`
	`70`	`+ throw ArgumentParser.ValidationError("missing argument '--binary'")`
`71`	`71`	`}`
`72`	`72`	`let absolutePath = URL(fileURLWithPath: binaryPath, relativeTo: .currentDirectory()).absoluteURL.absoluteString`
`73`	`73`	`let platform = try getSystemPlatform()`
`@@ -76,10 +76,10 @@ extension Application {`
`76`	`76`
`77`	`77`	`private func setKernelFromTar() async throws {`
`78`	`78`	`guard let binaryPath else {`
`79`		`- throw ArgumentParser.ValidationError("Missing argument '--binary'")`
	`79`	`+ throw ArgumentParser.ValidationError("missing argument '--binary'")`
`80`	`80`	`}`
`81`	`81`	`guard let tarPath else {`
`82`		`- throw ArgumentParser.ValidationError("Missing argument '--tar")`
	`82`	`+ throw ArgumentParser.ValidationError("missing argument '--tar")`
`83`	`83`	`}`
`84`	`84`	`let platform = try getSystemPlatform()`
`85`	`85`	`let localTarPath = URL(fileURLWithPath: tarPath, relativeTo: .currentDirectory()).path`