Skip to content

Commit 6bd5d0b

Browse files
committed
Cleanup build scripts
1 parent 8aa2789 commit 6bd5d0b

4 files changed

Lines changed: 21 additions & 31 deletions

File tree

configure

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8433,21 +8433,17 @@ fi
84338433
84348434
fi
84358435
8436-
8437-
84388436
{ $as_echo "$as_me:${as_lineno-$LINENO}: Running qmake to generate the makefile..." >&5
84398437
$as_echo "$as_me: Running qmake to generate the makefile..." >&6;}
8440-
CONFDIR="$( cd "$( dirname "$0" )" && pwd )"
8441-
8442-
$QT_QMAKE -r $CONFDIR/qbittorrent.pro "QMAKE_LRELEASE=$QMAKE_LRELEASE"
8443-
8444-
ret="$?"
8438+
TOPDIR="$(cd "$(dirname "$0")" && pwd)"
8439+
$QT_QMAKE -r "$TOPDIR/qbittorrent.pro" "QMAKE_LRELEASE=$QMAKE_LRELEASE"
8440+
qmake_ret="$?"
84458441
84468442
$as_echo
8447-
if test "x$ret" = "x0"; then :
8448-
{ $as_echo "$as_me:${as_lineno-$LINENO}: Good, your configure finished." >&5
8449-
$as_echo "$as_me: Good, your configure finished." >&6;}
8450-
else
8451-
as_fn_error $? "Failed running $QT_QMAKE to generate the makefile" "$LINENO" 5
8443+
if test "x$qmake_ret" != "x0"; then :
8444+
as_fn_error $? "$QT_QMAKE failed to generate the makefile" "$LINENO" 5
84528445
fi
8446+
8447+
{ $as_echo "$as_me:${as_lineno-$LINENO}: Good, the configure finished." >&5
8448+
$as_echo "$as_me: Good, the configure finished." >&6;}
84538449
$as_echo

configure.ac

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,17 +292,14 @@ AC_OUTPUT(conf.pri)
292292
AS_IF([test "x$enable_systemd" = "xyes"],
293293
[AC_OUTPUT(dist/unix/systemd/qbittorrent-nox@.service)])
294294

295-
296-
297295
AC_MSG_NOTICE([Running qmake to generate the makefile...])
298-
CONFDIR="$( cd "$( dirname "$0" )" && pwd )"
299-
300-
$QT_QMAKE -r [$CONFDIR]/qbittorrent.pro "QMAKE_LRELEASE=$QMAKE_LRELEASE"
301-
302-
ret="$?"
296+
TOPDIR="$(cd "$(dirname "$0")" && pwd)"
297+
$QT_QMAKE -r "$TOPDIR/qbittorrent.pro" "QMAKE_LRELEASE=$QMAKE_LRELEASE"
298+
qmake_ret="$?"
303299

304300
AS_ECHO()
305-
AS_IF([test "x$ret" = "x0"],
306-
[AC_MSG_NOTICE([Good, your configure finished.])],
307-
[AC_MSG_ERROR([Failed running $QT_QMAKE to generate the makefile])])
301+
AS_IF([test "x$qmake_ret" != "x0"],
302+
[AC_MSG_ERROR([$QT_QMAKE failed to generate the makefile])])
303+
304+
AC_MSG_NOTICE([Good, the configure finished.])
308305
AS_ECHO()

macxconf.pri

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
# Generated by the configure file
2-
# Ignore any WARNING about 'conf.pri' missing during configure. The file should be found during make.
3-
# If not there will be a WARNING again.
41
# The first path is used when the source is being build by packagers (pbuilder/sbuild/etc)
52
# The second path is used when you manually run the configure script in the root folder (eg when using qt creator)
63
exists($$OUT_PWD/../conf.pri) {
74
include($$OUT_PWD/../conf.pri)
8-
} else {
5+
}
6+
else {
97
include(conf.pri)
108
}
119

unixconf.pri

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
# Generated by the configure file
2-
# Ignore any WARNING about 'conf.pri' missing during configure. The file should be found during make.
3-
# If not there will be a WARNING again.
41
# The first path is used when the source is being build by packagers (pbuilder/sbuild/etc)
52
# The second path is used when you manually run the configure script in the root folder (eg when using qt creator)
63
exists($$OUT_PWD/../conf.pri) {
74
include($$OUT_PWD/../conf.pri)
8-
} else {
5+
}
6+
else {
97
include(conf.pri)
108
}
119

@@ -18,7 +16,8 @@ QMAKE_CXXFLAGS += -Wall -Wextra -Wpedantic -Wformat-security
1816
# Man page
1917
nogui {
2018
man.files = ../doc/qbittorrent-nox.1
21-
} else {
19+
}
20+
else {
2221
man.files = ../doc/qbittorrent.1
2322
}
2423

0 commit comments

Comments
 (0)