Skip to content

Commit 6515fe8

Browse files
Copiloteos87
andauthored
chore: address review feedback on subscribers migration
Agent-Logs-Url: https://github.com/superdesk/superdesk-client-core/sessions/d3f35282-bf9b-42d6-bdbd-8360c01fcd7d Co-authored-by: eos87 <124766+eos87@users.noreply.github.com>
1 parent 6b988af commit 6515fe8

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

e2e/MIGRATION_REPORT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
## Migrated specs
1515
- Protractor `e2e/client/specs/workspace_spec.ts` -> `e2e/client/playwright/workspace.spec.ts` [65a6ef935] — Given the authenticated user is on the dashboard, when they use the workspace hotkeys, then the app switches to monitoring, spiked, personal, search, and back to dashboard.
1616
- Protractor `e2e/client/specs/vocabularies_spec.ts` -> `e2e/client/playwright/vocabularies.spec.ts` [4b719937a] — Given the vocabularies settings page is open, when the user edits the Categories vocabulary name and cancels, then the original vocabulary data is restored.
17-
- Protractor `e2e/client/specs/subscribers_spec.ts` -> `e2e/client/playwright/subscribers.spec.ts` [a50a98854] — Given the publish settings page is open, when the user inspects and edits the default subscriber from the snapshot, then the list shows that subscriber and the save button only enables after changing the target type and destination format.
17+
- Protractor `e2e/client/specs/subscribers_spec.ts` -> `e2e/client/playwright/subscribers.spec.ts` [a50a98854] — Given the publish settings page is open, when the user inspects and edits the default subscriber row from the snapshot, then the list shows that subscriber and the save button only enables after changing the target type and destination format.
1818
- Protractor `e2e/client/specs/suggest_spec.ts` -> `e2e/client/playwright/suggest.spec.ts` [df73cc578] — Given an authenticated user opens a new text item, when they open Live suggestions before changing the body, then the suggestions list is empty.
1919

2020
## Blocked

e2e/client/playwright/subscribers.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@ import {test, expect} from '@playwright/test';
22
import {restoreDatabaseSnapshot, s} from './utils';
33

44
test.describe('subscribers', () => {
5-
const subscriberName = 'Subscriber 1';
6-
75
test.beforeEach(async ({page}) => {
86
await restoreDatabaseSnapshot();
97
await page.goto('/#/settings/publish');
108
});
119

1210
test('lists the default subscriber', async ({page}) => {
13-
await expect(page.locator(s('subscriber-item'))).toHaveCount(1);
14-
await expect(page.locator(s(`subscriber-item=${subscriberName}`))).toBeVisible();
11+
const subscriberItems = page.locator(s('subscriber-item'));
12+
13+
await expect(subscriberItems).toHaveCount(1);
14+
await expect(subscriberItems.first()).toBeVisible();
1515
});
1616

1717
test('save button is disabled until subscriber type changes', async ({page}) => {
18-
const subscriberItem = page.locator(s(`subscriber-item=${subscriberName}`));
18+
const subscriberItem = page.locator(s('subscriber-item')).first();
1919

2020
await subscriberItem.click();
2121
await subscriberItem.locator(s('edit-subscriber-button')).click();

0 commit comments

Comments
 (0)