Skip to content

Commit 9475dfe

Browse files
ddiproiettoshettyg
authored andcommitted
acinclude.m4: Do not set vswitchd_ovs_vswitchd_LDFLAGS
Commit d731058 used vswitchd_ovs_vswitchd_LDFLAGS to link with DPDK. This made automake ignore AM_LDFLAGS while linking the daemon. This commit explicitly adds AM_LDFLAGS to vswitchd_ovs_vswitchd_LDFLAGS and moves it to vswitchd/automake.mk Reported-by: Gurucharan Shetty <gshetty@nicira.com> Suggested-by: Ben Pfaff <blp@nicira.com> Signed-off-by: Daniele Di Proietto <ddiproietto@vmware.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
1 parent 6ce798b commit 9475dfe

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

acinclude.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ AC_DEFUN([OVS_CHECK_DPDK], [
208208
#
209209
# These options are specified inside a single -Wl directive to prevent
210210
# autotools from reordering them.
211-
vswitchd_ovs_vswitchd_LDFLAGS=-Wl,--whole-archive,$DPDK_LIB,--no-whole-archive
212-
AC_SUBST([vswitchd_ovs_vswitchd_LDFLAGS])
211+
DPDK_vswitchd_LDFLAGS=-Wl,--whole-archive,$DPDK_LIB,--no-whole-archive
212+
AC_SUBST([DPDK_vswitchd_LDFLAGS])
213213
AC_DEFINE([DPDK_NETDEV], [1], [System uses the DPDK module.])
214214
else
215215
RTE_SDK=

vswitchd/automake.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ vswitchd_ovs_vswitchd_LDADD = \
1515
ofproto/libofproto.la \
1616
lib/libsflow.la \
1717
lib/libopenvswitch.la
18+
vswitchd_ovs_vswitchd_LDFLAGS = $(AM_LDFLAGS) $(DPDK_vswitchd_LDFLAGS)
1819
EXTRA_DIST += vswitchd/INTERNALS
1920
MAN_ROOTS += vswitchd/ovs-vswitchd.8.in
2021

0 commit comments

Comments
 (0)