Skip to content

Commit ecc798a

Browse files
author
Justin Pettit
committed
ovs-ofctl: Fix "cookie mask" issue in diff-flows command.
Commit e729e79 (Add ability to restrict flow mods and flow stats requests to cookies.) introduced a cookie_mask field to the ofputil_flow_stats_request struct that allowed restricting the flows to a particular cookie pattern. The diff-flows command uses the read_flows_from_switch() function, which did not properly initialize this field, which would cause it to miss flows. This commit sets the value to zero, which allows any cookie. Bug #8984 Signed-off-by: Justin Pettit <jpettit@nicira.com> Reported-by: Luca Giraudo <lgiraudo@nicira.com>
1 parent e729e79 commit ecc798a

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

utilities/ovs-ofctl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,6 +1180,7 @@ read_flows_from_switch(struct vconn *vconn, enum nx_flow_format flow_format,
11801180
cls_rule_init_catchall(&fsr.match, 0);
11811181
fsr.out_port = OFPP_NONE;
11821182
fsr.table_id = 0xff;
1183+
fsr.cookie = fsr.cookie_mask = htonll(0);
11831184
request = ofputil_encode_flow_stats_request(&fsr, flow_format);
11841185
send_xid = ((struct ofp_header *) request->data)->xid;
11851186
send_openflow_buffer(vconn, request);

0 commit comments

Comments
 (0)