Skip to content

Commit 7c47b03

Browse files
authored
ci: skip E2E (stdio MCP) on pull_request; scope marketing lint override to .ts (RhysSullivan#1220)
The local E2E scenario boots a real executor web plus a browser and is currently flaky on PRs, so gate it to push events (still runs on main). The marketing app is plain Astro/Cloudflare SSR, not Effect domain code, but its lib/*.ts files were subject to the Effect-only lint rules (no-try-catch-or-throw, no-promise-catch), breaking lint on main after the GitHub stars pill landed. Extend the existing marketing override from *.astro to *.{astro,ts,tsx} and disable no-promise-catch there too.
1 parent bb0a02b commit 7c47b03

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ jobs:
7676

7777
e2e-local:
7878
name: E2E (stdio MCP)
79+
# Skipped on pull_request: the local scenario boots a real `executor web`
80+
# plus a browser and is currently flaky on PRs. Still runs on push to main.
81+
if: github.event_name != 'pull_request'
7982
runs-on: ubuntu-latest
8083
steps:
8184
- uses: actions/checkout@v4

.oxlintrc.jsonc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,13 @@
101101
},
102102
},
103103
{
104-
"files": ["apps/marketing/src/**/*.astro"],
104+
"files": ["apps/marketing/src/**/*.{astro,ts,tsx}"],
105105
"rules": {
106106
"executor/no-effect-escape-hatch": "off",
107107
"executor/no-error-constructor": "off",
108108
"executor/no-instanceof-error": "off",
109109
"executor/no-json-parse": "off",
110+
"executor/no-promise-catch": "off",
110111
"executor/no-try-catch-or-throw": "off",
111112
"executor/no-unknown-error-message": "off",
112113
},

0 commit comments

Comments
 (0)